Skip to content

Drop availability checks for ios 14 and 15 in the embedder#188189

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
LouiseHsu:engine-version-bump
Jun 24, 2026
Merged

Drop availability checks for ios 14 and 15 in the embedder#188189
auto-submit[bot] merged 2 commits into
flutter:masterfrom
LouiseHsu:engine-version-bump

Conversation

@LouiseHsu

@LouiseHsu LouiseHsu commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of #187741
Land this after #188187

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026
@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin team-ios Owned by iOS platform team team-macos Owned by the macOS platform team labels Jun 18, 2026
@LouiseHsu
LouiseHsu force-pushed the engine-version-bump branch 2 times, most recently from de792eb to 41e2494 Compare June 18, 2026 20:44
@LouiseHsu
LouiseHsu force-pushed the engine-version-bump branch from 41e2494 to f050928 Compare June 18, 2026 20:57
@LouiseHsu LouiseHsu removed the CICD Run CI/CD label Jun 18, 2026
@github-actions github-actions Bot removed a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin team-macos Owned by the macOS platform team labels Jun 18, 2026
@LouiseHsu LouiseHsu added framework flutter/packages/flutter repository. See also f: labels. team-macos Owned by the macOS platform team CICD Run CI/CD labels Jun 18, 2026
@github-actions github-actions Bot removed framework flutter/packages/flutter repository. See also f: labels. team-macos Owned by the macOS platform team labels Jun 18, 2026
@flutter-dashboard

flutter-dashboard Bot commented Jun 18, 2026

Copy link
Copy Markdown

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: f050928.

Possible causes:

  • Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
  • Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

GitHub Error: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) If you reach out to GitHub Support for help, please include the request ID C0C2:32F66B:A805ECC:26B7AC9E:6A3465E5.

Stack trace:

#0      GitHub.handleStatusCode (package:github/src/common/github.dart:486:5)
#1      GitHub.request (package:github/src/common/github.dart:422:7)
<asynchronous suspension>
#2      GitHub.requestJson (package:github/src/common/github.dart:323:22)
<asynchronous suspension>
#3      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#4      LuciBuildService._scheduleTryBuilds (package:cocoon_service/src/service/luci_build_service.dart:307:26)
<asynchronous suspension>
#5      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1476:9)
<asynchronous suspension>
#6      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1527:7)
<asynchronous suspension>
#7      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1341:5)
<asynchronous suspension>
#8      Scheduler.processCheckRunCompleted (package:cocoon_service/src/service/scheduler.dart:1273:11)
<asynchronous suspension>
#9      PresubmitLuciSubscription.post (package:cocoon_service/src/request_handlers/presubmit_luci_subscription.dart:176:9)
<asynchronous suspension>
#10     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:42:20)
<asynchronous suspension>
#11     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:139:5)
<asynchronous suspension>
#12     createServer.<anonymous closure> (package:cocoon_service/server.dart:448:7)
<asynchronous suspension>
#13     main.<anonymous closure>.<anonymous closure> (file:///app/app_dart/bin/gae_server.dart:187:9)
<asynchronous suspension>

@LouiseHsu LouiseHsu added CICD Run CI/CD and removed CICD Run CI/CD labels Jun 18, 2026
@fluttergithubbot

fluttergithubbot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

An existing Git SHA, f050928f0e67151ff4cfc578d1adf07a0f002e37, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@LouiseHsu LouiseHsu changed the title Engine version bump Drop availability checks for ios 14 and 15 in the embedder Jun 18, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026
@LouiseHsu LouiseHsu added the CICD Run CI/CD label Jun 18, 2026
@LouiseHsu
LouiseHsu requested a review from vashworth June 19, 2026 00:24
@LouiseHsu
LouiseHsu marked this pull request as ready for review June 19, 2026 00:24
@LouiseHsu
LouiseHsu requested a review from a team as a code owner June 19, 2026 00:24
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 19, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes obsolete @available version checks for iOS 13.0, 14.0, 14.5, and 15.0 across multiple iOS platform files, including FlutterDartVMServicePublisher.mm, FlutterMetalLayer.mm, FlutterPlatformPlugin.mm, FlutterPlatformViews.mm, FlutterPlatformViewsController.mm, FlutterPluginAppLifeCycleDelegate.mm, and FlutterViewController.mm. There are no review comments to evaluate, and no further feedback is provided.

@LouiseHsu LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Jun 24, 2026
Merged via the queue into flutter:master with commit 269cef8 Jun 24, 2026
206 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2026
This was referenced Jun 25, 2026
Closed
Closed
Closed
Closed
Closed
via-guy pushed a commit to via-guy/flutter that referenced this pull request Jun 26, 2026
@LouiseHsu @via-guy
Drop availability checks for ios 14 and 15 in the embedder (flutter#1…
bb1bff4 
…88189)

Part of flutter#187741
Land this after flutter#188187

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
This was referenced Jun 26, 2026
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LouiseHsu @fluttergithubbot @vashworth