Skip to content

hello_world_windows_impeller bringup->false#188047

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
gaaclarke:hello-world-impeller-windows-bringup-false
Jun 24, 2026
Merged

hello_world_windows_impeller bringup->false#188047
auto-submit[bot] merged 2 commits into
flutter:masterfrom
gaaclarke:hello-world-impeller-windows-bringup-false

Conversation

@gaaclarke

Copy link
Copy Markdown
Member

testing: is a test

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 15, 2026
@gaaclarke
gaaclarke requested review from b-luk and jtmcdole June 15, 2026 21:33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the bringup: true configuration from the Windows hello_world_windows_impeller target in .ci.yaml. There are no review comments, and I have no feedback to provide.

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2026
@auto-submit

auto-submit Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/188047, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2026
@auto-submit

auto-submit Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/188047, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants