[Tool] Fix widget-preview crash by waiting for analysis server#187941
Merged
auto-submit[bot] merged 3 commits intoJun 23, 2026
Conversation
The `flutter widget-preview start` command was crashing with an `RpcException` (method not found) because it attempted to call `dart/workspace/getFlutterWidgetPreviews` immediately after the `Lsp` service was registered, but before the Analysis Server had finished its initial analysis and registered the specific method. This change: - Waits for the initial analysis to complete after initializing the LSP preview detector. - Increases the retry limit for DTD calls to the widget preview methods from 5 to 50 (with 200ms delay, increasing the total wait from 1s to 10s) to handle slower environments. - Adds a unit test to verify that the tool indeed waits for the analysis server to finish initial analysis. Fixes flutter#187367
github-actions
Bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the widget preview start command to wait for the initial analysis to complete before populating DTD connection info, and increases the maximum retry attempts for retrieving widget previews from 5 to 50. It also adds a corresponding test to verify that analysis completion is awaited. However, the retry logic in dtd_services.dart contains an infinite loop bug where caught RpcExceptions that do not meet the retry criteria are not rethrown, causing the loop to run indefinitely.
Refactored the retry logic in getFlutterWidgetPreviews and getFlutterWidgetPreviewsForFile to use a standard for-loop. This improves readability and addresses feedback regarding loop termination clarity.
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/187941, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
bkonyi
added
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Jun 24, 2026
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
…er#187941) The `flutter widget-preview start` command was crashing with an `RpcException` (method not found) because it attempted to call `dart/workspace/getFlutterWidgetPreviews` immediately after the `Lsp` service was registered, but before the Analysis Server had finished its initial analysis and registered the specific method. This change: - Waits for the initial analysis to complete after initializing the LSP preview detector. - Increases the retry limit for DTD calls to the widget preview methods from 5 to 50 (with 200ms delay, increasing the total wait from 1s to 10s) to handle slower environments. - Adds a unit test to verify that the tool indeed waits for the analysis server to finish initial analysis. Fixes flutter#187367
This was referenced Jun 29, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 29, 2026
…12041) Manual roll requested by [email protected] flutter/flutter@87224e0...11e339e 2026-06-23 [email protected] [flutter_tools] Migrate analysis_options.yaml to exclude build and platform directories by default (flutter/flutter#187940) 2026-06-23 [email protected] Update docs for PR limits (flutter/flutter#188388) 2026-06-23 [email protected] Roll Packages from cd5194a to 7d84a69 (4 revisions) (flutter/flutter#188383) 2026-06-23 [email protected] [Tool] Fix widget-preview crash by waiting for analysis server (flutter/flutter#187941) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
flutter widget-preview startcommand was crashing with anRpcException(method not found) because it attempted to calldart/workspace/getFlutterWidgetPreviewsimmediately after theLspservice was registered, but before the Analysis Server had finished its initial analysis and registered the specific method.This change:
Fixes #187367