Remove dynamic module loading code in flutter web engine#187777
Merged
mkustermann merged 2 commits intoJun 12, 2026
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Dynamic module support was removed from dart2wasm in [0]. The code in flutter web engine has no effect (and seems also untested). [0] dart-lang/sdk@d43d9df1a71b1e1
mkustermann
force-pushed
the
remove-dynamic-module-code
branch
from
June 11, 2026 13:16
b13cdc5 to
16def0f
Compare
mkustermann
enabled auto-merge
June 11, 2026 19:31
This was referenced Jun 12, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 12, 2026
flutter/flutter@8bdce07...b7cb925 2026-06-12 [email protected] Roll Skia from cadbde1ec4b7 to 8c89bf2b0ee3 (5 revisions) (flutter/flutter#187926) 2026-06-12 [email protected] Roll Packages from 1b56cde to b78ad83 (5 revisions) (flutter/flutter#187928) 2026-06-12 [email protected] Roll Dart SDK from f3441f2067ae to f6c31f4c3a63 (17 revisions) (flutter/flutter#187924) 2026-06-12 [email protected] Roll Fuchsia Linux SDK from 2KosSR4ONUjIB7tP_... to A3eaUn9mQ_EkSNxVI... (flutter/flutter#187923) 2026-06-12 [email protected] Roll Skia from a2228b926c68 to cadbde1ec4b7 (9 revisions) (flutter/flutter#187921) 2026-06-12 [email protected] Remove dynamic module loading code in flutter web engine (flutter/flutter#187777) 2026-06-12 [email protected] Remove EnableTransparentWindowBackground because it did nothing important and because Windows 10 does not support DWMWA_SYSTEMBACKDROP_TYPE (flutter/flutter#187848) 2026-06-12 [email protected] Roll Fuchsia Test Scripts from dQ4PjIJB5kZFU8Y32... to EmfiOMUge_nnNS33B... (flutter/flutter#187912) 2026-06-12 [email protected] Clarify RichText selection docs (flutter/flutter#186844) 2026-06-12 [email protected] Custom KGP task and migration to AGP api for geting kgp version (flutter/flutter#182788) 2026-06-12 [email protected] Roll Skia from f61acb31edf8 to a2228b926c68 (5 revisions) (flutter/flutter#187896) 2026-06-12 [email protected] [Flutter GPU] Expose ASTC HDR texture formats (flutter/flutter#187715) 2026-06-12 [email protected] Expand coverage of android_hardware_smoke_test. Add image, text, blend mode, and blur tests. (flutter/flutter#187600) 2026-06-11 [email protected] [Flutter GPU] Add blit operations (flutter/flutter#187289) 2026-06-11 [email protected] [flutter_tools] Fix version cache git fallback performance regression (flutter/flutter#187400) 2026-06-11 [email protected] Rewrite `-d web-server` hot reload/restart tests (flutter/flutter#187453) 2026-06-11 [email protected] [Impeller] Allow sampling textures with manually-uploaded mip levels (flutter/flutter#187729) 2026-06-11 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#187884) 2026-06-11 [email protected] iOS a11y sets header trait based on heading level (flutter/flutter#186916) 2026-06-11 [email protected] Roll Skia from 9f02102df298 to f61acb31edf8 (19 revisions) (flutter/flutter#187869) 2026-06-11 [email protected] Roll ICU from ee5f27adc28b to d578f2e8b7bd (8 revisions) (flutter/flutter#187829) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
) Dynamic module support was removed from dart2wasm in [0]. The code in flutter web engine has no effect (and seems also untested). [0] dart-lang/sdk@d43d9df1a71b1e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic module support was removed from dart2wasm in [0]. The code in flutter web engine has no effect (and seems also untested).
[0] dart-lang/sdk@d43d9df1a71b1e1