Skip to content

Flip from deprecated strict analysis modes to lint rules#187692

Merged
srawlins merged 6 commits into
flutter:masterfrom
srawlins:strict
Jul 12, 2026
Merged

Flip from deprecated strict analysis modes to lint rules#187692
srawlins merged 6 commits into
flutter:masterfrom
srawlins:strict

Conversation

@srawlins

@srawlins srawlins commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Work towards dart-lang/sdk#63517.

Each of the 'strict analysis modes' has been replaced with a lint rule, for consistency purposes.

Also some deprecated lint rules are removed from the file, as they will be removed soon.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the analysis_options.yaml file by removing deprecated language options and several linter rules, and adding new linter rules. Feedback points out that the newly added rules no_dynamic_casts and no_raw_types do not exist in the Dart SDK and should be replaced with strict_casts and strict_raw_types under the correct alphabetical section. Additionally, migrating the remaining strict-inference language option to the strict_inference linter rule is recommended for consistency.

Comment thread analysis_options.yaml Outdated
Comment thread analysis_options.yaml
Comment thread analysis_options.yaml
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 8, 2026
@Piinks Piinks added CICD Run CI/CD team-framework Owned by Framework team framework flutter/packages/flutter repository. See also f: labels. and removed team-framework Owned by Framework team labels Jun 8, 2026
@Piinks
Piinks self-requested a review June 9, 2026 22:22
@github-actions github-actions Bot removed framework flutter/packages/flutter repository. See also f: labels. CICD Run CI/CD labels Jun 19, 2026
@Piinks Piinks added the framework flutter/packages/flutter repository. See also f: labels. label Jun 22, 2026
@github-actions github-actions Bot removed the framework flutter/packages/flutter repository. See also f: labels. label Jun 29, 2026

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srawlins
srawlins enabled auto-merge July 8, 2026 17:06
@srawlins srawlins added the CICD Run CI/CD label Jul 11, 2026
@srawlins
srawlins added this pull request to the merge queue Jul 12, 2026
Merged via the queue into flutter:master with commit cf9e8af Jul 12, 2026
65 checks passed
@srawlins
srawlins deleted the strict branch July 12, 2026 17:51
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jul 12, 2026
flutter/flutter@f7b66f3...cf9e8af

2026-07-12 [email protected] Flip from deprecated strict analysis modes to lint rules (flutter/flutter#187692)
2026-07-12 [email protected] Roll Skia from 6ecffccd32d5 to 8bf65996caba (5 revisions) (flutter/flutter#189333)
2026-07-11 [email protected] Roll Fuchsia Linux SDK from czpzDg9ABY2oKLAOY... to vhIlDkWIy21IrlB9E... (flutter/flutter#189309)
2026-07-11 [email protected] iOS: clean up swiftc.py after migration to target triples (flutter/flutter#189240)
2026-07-10 [email protected] Increase number of 'Mac tool_integration_tests' subshards from 5 to 10 (flutter/flutter#189040)
2026-07-10 [email protected] Fix PopupWindowControllerLinux missing WindowControllerLinux implementation (flutter/flutter#189189)
2026-07-10 [email protected] [android_hardware_smoke_test] Synchronize platform view compositing (flutter/flutter#189151)
2026-07-10 [email protected] UberSDF thin roundrect handling (flutter/flutter#189224)
2026-07-10 [email protected] Roll Skia from ab3a7b98c94d to 6ecffccd32d5 (15 revisions) (flutter/flutter#189270)
2026-07-10 [email protected] [skwasm][canvaskit] Honor Paint.filterQuality in Canvas.drawAtlas (flutter/flutter#186108)
2026-07-10 [email protected] Android_hardware_smoke_test: Cache flutter engine when running vulkan backend instrumented tests (flutter/flutter#189026)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants