[macOS] Add FlutterPluginRegistrar.valuePublished(byPlugin:) just like iOS#187348
[macOS] Add FlutterPluginRegistrar.valuePublished(byPlugin:) just like iOS#187348bernaferrari wants to merge 0 commit into
FlutterPluginRegistrar.valuePublished(byPlugin:) just like iOS#187348Conversation
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the valuePublishedByPlugin: method to the macOS FlutterPluginRegistrar protocol and implements it in FlutterEngine to allow plugins to retrieve values published by other plugins. Unit tests have been added to verify this functionality. Feedback suggests using stringByAppendingPathComponent: instead of stringByAppendingString: for path manipulation in the test code to ensure robust path construction.
4d0442e to
9cf7904
Compare
bernaferrari
changed the title
FlutterPluginRegistrar.valuePublished(byPlugin:) just like iOS
9cf7904 to
4dc2342
Compare
|
I rebased, let's see if Google Testing begins now. |
4dc2342 to
2df82f9
Compare
|
/cc @hellohuanlin could you take a look at the google testing failure? |
|
The failure was just time-out. I've kicked off re-run and see how it goes |
|
Now it passed. Thanks! |
bernaferrari
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/187348, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
auto-submit
Bot
removed
the
autosubmit
2df82f9 to
cfb8130
Compare
|
I pressed the wrong button and accidentally killed the branch somehow instead of rebasing (I think I rebased on top of origin/main instead of origin/master and that broke the tree). And apparently there is no way to solve, so I cloned it under another PR. |
…e iOS (flutter#189614) Fix flutter#186911 <img width="1536" height="1024" alt="image" src="https://github.com/user-attachments/assets/bd266853-c939-412f-97de-0a0c3d1e1da6" /> Adds `valuePublishedByPlugin:` to the macOS `FlutterPluginRegistrar` protocol and forwards it through `FlutterEngineRegistrar` to the engine's existing published plugin value lookup. This makes the macOS plugin registrar API == iOS registrar API, allowing shared Darwin plugin code to retrieve values published by other plugins without platform-specific workarounds. The new macOS registrar comment is the same as iOS. --- Note: This replaces flutter#187348, which was accidentally closed during a rebase. Co-authored-by: Jenn Magder <[email protected]>
3 participants
Fix #186911
Adds
valuePublishedByPlugin:to the macOSFlutterPluginRegistrarprotocol and forwards it throughFlutterEngineRegistrarto the engine's existing published plugin value lookup.This makes the macOS plugin registrar API == iOS registrar API, allowing shared Darwin plugin code to retrieve values published by other plugins without platform-specific workarounds.
The new macOS registrar comment is the same as iOS.