[Impeller] Use glVertexAttribDivisor on GLES3 and glVertexAttribDivisorEXT on GLES2 with the extension#187313
Merged
auto-submit[bot] merged 4 commits intoJun 2, 2026
Conversation
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the standard VertexAttribDivisor in the GLES backend of Impeller, falling back to VertexAttribDivisorEXT if the standard version is unavailable. It also ensures VertexAttribDivisorEXT is reset if the GL_EXT_instanced_arrays extension is not present, and includes corresponding unit tests to verify this behavior. There are no review comments, and I have no additional feedback to provide.
Member
|
In const bool hardware_instanced = instanced && //
gl.DrawArraysInstancedEXT.IsAvailable() &&
gl.DrawElementsInstancedEXT.IsAvailable() &&
gl.VertexAttribDivisorEXT.IsAvailable();... and would need to incorporate Also, should we be giving this same treatment to |
Member
Author
|
Yes - Updated this to check for the |
bdero
previously approved these changes
May 29, 2026
…orEXT on GLES2 with the extension OpenGL ES 3.0 includes support for glVertexAttribDivisor. The glVertexAttribDivisorEXT API is available on OpenGL ES 2.0 devices with the GL_EXT_instanced_arrays extension. GLES3 devices may be able to resolve a glVertexAttribDivisorEXT function that is not actually implemented. This PR uses the glVertexAttribDivisor API if available and otherwise falls back to glVertexAttribDivisorEXT. See flutter#186653
jason-simmons
force-pushed
the
iplr_gles3_vertex_divisor
branch
from
May 31, 2026 03:08
1806afa to
6560dc5
Compare
jason-simmons
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Jun 2, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 2, 2026
flutter/flutter@54e199a...701665b 2026-06-02 [email protected] Roll Skia from c97e939eb5c9 to 279b17fe9fc1 (16 revisions) (flutter/flutter#187425) 2026-06-02 [email protected] [Flutter GPU] Add block-compressed texture format support (BC, ETC2, ASTC LDR) (flutter/flutter#187281) 2026-06-02 [email protected] [Impeller] Allow attaching specific texture mip levels and slices (flutter/flutter#187066) 2026-06-02 [email protected] [Impeller] Fix GLES command submission status before context is current (flutter/flutter#187293) 2026-06-02 [email protected] Roll Dart SDK from 3cdc25e8ffe9 to d39850bf4a01 (9 revisions) (flutter/flutter#187409) 2026-06-01 [email protected] [Impeller] Use glVertexAttribDivisor on GLES3 and glVertexAttribDivisorEXT on GLES2 with the extension (flutter/flutter#187313) 2026-06-01 [email protected] [Android] Add Javadoc documentation to TextInputChannel (flutter/flutter#186018) 2026-06-01 [email protected] Read FLTEnableWideGamut from Dart bundle (flutter/flutter#186509) 2026-06-01 [email protected] [flutter_tools] Remove obsolete AndroidX console warning during Gradle builds (flutter/flutter#186077) 2026-06-01 [email protected] [skia] Update gni file list name hsw -> ml3 (flutter/flutter#184892) 2026-06-01 [email protected] [web] Always sync slider input attrs regardless of gesture mode (flutter/flutter#187217) 2026-06-01 [email protected] [flutter_driver] Don't throw when stderr is unavailable on web (flutter/flutter#187190) 2026-06-01 [email protected] Remove unused code in `FlutterPluginUtils.kt` (flutter/flutter#187012) 2026-06-01 [email protected] [flutter_tools] Fix `flutter drive --chrome-binary` being ignored on web (flutter/flutter#185481) 2026-06-01 [email protected] Eager failure when building and no XCode build settings (flutter/flutter#184726) 2026-06-01 [email protected] Fix Windows Korean IME caret position during composition (flutter/flutter#186353) 2026-06-01 [email protected] iOS: update provisioning profile for 2026-2027 cert (flutter/flutter#187280) 2026-06-01 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#187380) 2026-06-01 [email protected] Reland "Move dart-lang/ai to a top level third party dependency in engine (#187268)" (flutter/flutter#187378) 2026-06-01 [email protected] Add vector_math to Framework triage (flutter/flutter#187389) 2026-06-01 [email protected] Roll Packages from e930ced to f5d50ca (4 revisions) (flutter/flutter#187381) 2026-06-01 [email protected] [flutter_tools] Reject archive entries that escape into a sibling directory by name prefix (#185794) (flutter/flutter#186647) 2026-06-01 [email protected] [flutter_tools] Fix widget_preview unawaited async write race condition (flutter/flutter#187177) 2026-06-01 [email protected] Roll pub packages (flutter/flutter#187375) 2026-06-01 [email protected] Roll Skia from 0aee4675e0ad to c97e939eb5c9 (7 revisions) (flutter/flutter#187371) 2026-06-01 [email protected] docs: Stack.clipBehavior = Clip.none does not extend hit testing (#160787) (flutter/flutter#186643) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11822) flutter/flutter@54e199a...701665b 2026-06-02 [email protected] Roll Skia from c97e939eb5c9 to 279b17fe9fc1 (16 revisions) (flutter/flutter#187425) 2026-06-02 [email protected] [Flutter GPU] Add block-compressed texture format support (BC, ETC2, ASTC LDR) (flutter/flutter#187281) 2026-06-02 [email protected] [Impeller] Allow attaching specific texture mip levels and slices (flutter/flutter#187066) 2026-06-02 [email protected] [Impeller] Fix GLES command submission status before context is current (flutter/flutter#187293) 2026-06-02 [email protected] Roll Dart SDK from 3cdc25e8ffe9 to d39850bf4a01 (9 revisions) (flutter/flutter#187409) 2026-06-01 [email protected] [Impeller] Use glVertexAttribDivisor on GLES3 and glVertexAttribDivisorEXT on GLES2 with the extension (flutter/flutter#187313) 2026-06-01 [email protected] [Android] Add Javadoc documentation to TextInputChannel (flutter/flutter#186018) 2026-06-01 [email protected] Read FLTEnableWideGamut from Dart bundle (flutter/flutter#186509) 2026-06-01 [email protected] [flutter_tools] Remove obsolete AndroidX console warning during Gradle builds (flutter/flutter#186077) 2026-06-01 [email protected] [skia] Update gni file list name hsw -> ml3 (flutter/flutter#184892) 2026-06-01 [email protected] [web] Always sync slider input attrs regardless of gesture mode (flutter/flutter#187217) 2026-06-01 [email protected] [flutter_driver] Don't throw when stderr is unavailable on web (flutter/flutter#187190) 2026-06-01 [email protected] Remove unused code in `FlutterPluginUtils.kt` (flutter/flutter#187012) 2026-06-01 [email protected] [flutter_tools] Fix `flutter drive --chrome-binary` being ignored on web (flutter/flutter#185481) 2026-06-01 [email protected] Eager failure when building and no XCode build settings (flutter/flutter#184726) 2026-06-01 [email protected] Fix Windows Korean IME caret position during composition (flutter/flutter#186353) 2026-06-01 [email protected] iOS: update provisioning profile for 2026-2027 cert (flutter/flutter#187280) 2026-06-01 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#187380) 2026-06-01 [email protected] Reland "Move dart-lang/ai to a top level third party dependency in engine (#187268)" (flutter/flutter#187378) 2026-06-01 [email protected] Add vector_math to Framework triage (flutter/flutter#187389) 2026-06-01 [email protected] Roll Packages from e930ced to f5d50ca (4 revisions) (flutter/flutter#187381) 2026-06-01 [email protected] [flutter_tools] Reject archive entries that escape into a sibling directory by name prefix (#185794) (flutter/flutter#186647) 2026-06-01 [email protected] [flutter_tools] Fix widget_preview unawaited async write race condition (flutter/flutter#187177) 2026-06-01 [email protected] Roll pub packages (flutter/flutter#187375) 2026-06-01 [email protected] Roll Skia from 0aee4675e0ad to c97e939eb5c9 (7 revisions) (flutter/flutter#187371) 2026-06-01 [email protected] docs: Stack.clipBehavior = Clip.none does not extend hit testing (#160787) (flutter/flutter#186643) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
…orEXT on GLES2 with the extension (flutter#187313) OpenGL ES 3.0 includes support for glVertexAttribDivisor. The glVertexAttribDivisorEXT API is available on OpenGL ES 2.0 devices with the GL_EXT_instanced_arrays extension. GLES3 devices may be able to resolve a glVertexAttribDivisorEXT function that is not actually implemented. This PR uses the glVertexAttribDivisor API if available and otherwise falls back to glVertexAttribDivisorEXT. See flutter#186653
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenGL ES 3.0 includes support for glVertexAttribDivisor. The glVertexAttribDivisorEXT API is available on OpenGL ES 2.0 devices with the GL_EXT_instanced_arrays extension.
GLES3 devices may be able to resolve a glVertexAttribDivisorEXT function that is not actually implemented. This PR uses the glVertexAttribDivisor API if available and otherwise falls back to glVertexAttribDivisorEXT.
See #186653