Skip to content

Improve error reporting for dumpsys meminfo - #187254

Merged
auto-submit[bot] merged 11 commits into
flutter:masterfrom
mboetger:resolve-issue-74085
Aug 18, 2026
Merged

Improve error reporting for dumpsys meminfo#187254
auto-submit[bot] merged 11 commits into
flutter:masterfrom
mboetger:resolve-issue-74085

Conversation

@mboetger

@mboetger mboetger commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Improve error reporting for dumpsys meminfo parsing in devicelab

Partially Addresses #74085

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

mboetger added 2 commits May 28, 2026 16:19
@mboetger
Resolve issue flutter#74085: Improve error reporting for dumpsys memi…
7caa7c9 
…nfo parsing in devicelab
@mboetger
fix(devicelab): throw controlled DeviceException instead of assert wh…
69f4937 
…en dumpsys meminfo fails to parse

Changes assert to controlled DeviceException throw inside AndroidDevice.getMemoryStats when dumpsys meminfo parsing fails, providing descriptive diagnostics in production. Adds adb_test.dart test coverage.

TAG=agy
CONV=c27e0d56-32a6-48b9-9054-daf87ae39aa1
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 28, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 28, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces an assertion with an explicit DeviceException when parsing dumpsys meminfo output fails in AndroidDevice.getMemoryStats, adds a corresponding unit test, and reformats a JSON decoding statement in IosDeviceDiscovery.discoverDevices. Feedback on the changes suggests simplifying the new unit test by removing the unnecessary async keyword and closure wrapper, allowing expect to handle the returned Future directly.

Comment thread dev/devicelab/test/adb_test.dart Resolved
@mboetger @gemini-code-assist
Update dev/devicelab/test/adb_test.dart
dd5b62e 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@github-actions github-actions Bot removed the CICD Run CI/CD label May 29, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 29, 2026
@Piinks Piinks added the team-android Owned by Android platform team label Jun 1, 2026
@mboetger
mboetger requested review from a team and jesswrd and removed request for a team June 2, 2026 18:22
@github-actions github-actions Bot removed team-android Owned by Android platform team CICD Run CI/CD labels Jun 10, 2026
@mboetger mboetger added the l:backlog LLM created PR addressing a backlog issue. label Jun 18, 2026
@Piinks Piinks added platform-android Android applications specifically team-android Owned by Android platform team labels Jun 22, 2026
@jesswrd jesswrd added the CICD Run CI/CD label Jun 29, 2026
jesswrd
jesswrd reviewed Jun 29, 2026
View reviewed changes

@jesswrd jesswrd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test for the "happy" path which is when dumpsys meminfo is successfully parsed.

Also, consider updating the PR description from "Fixes #74085" to "Partially Addresses #74085." I think this PR addresses the issue but does not fix it. I think this PR helps us better diagnose the flake but doesn't actually fix the flake.

@mboetger

mboetger commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Done. Added a happy path unit test for getMemoryStats in adb_test.dart to verify successful parsing, and updated the PR description to 'Partially Addresses #74085' since this PR improves diagnostics but does not fix the underlying flake.

@github-actions github-actions Bot removed platform-android Android applications specifically team-android Owned by Android platform team labels Jul 7, 2026
@mboetger
mboetger requested a review from jesswrd July 15, 2026 20:45
@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2026
@auto-submit

auto-submit Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/187254, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

@Piinks Piinks added platform-android Android applications specifically team-android Owned by Android platform team labels Aug 17, 2026
@github-actions github-actions Bot removed platform-android Android applications specifically team-android Owned by Android platform team labels Aug 18, 2026
@mboetger mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Aug 18, 2026
Merged via the queue into flutter:master with commit 47a975d Aug 18, 2026
22 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2026
This was referenced Aug 18, 2026
Closed
Closed
Closed
@justinmc justinmc mentioned this pull request Aug 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesswrd jesswrd jesswrd approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD l:backlog LLM created PR addressing a backlog issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mboetger @jesswrd @Piinks