Add --flavor support for Windows desktop builds by AngeloAvv · Pull Request #187034 · flutter/flutter

AngeloAvv · 2026-05-24T12:21:28Z

Flutter desktop on Windows currently has no equivalent of the --flavor plumbing that already exists for Android, iOS, and macOS: flutter build windows --flavor X is rejected at the command-parser level, flutter run -d windows --flavor X emits a "flavor only supported on Android, iOS, macOS" warning, and there is no convention for producing per-flavor binaries or build directories. This PR wires the existing flavor infrastructure end-to-end on Windows so that multiple flavors can coexist in the same project without colliding on disk or in the runner.

What changes

flutter build windows accepts --flavor via the shared usesFlavorOption() helper.
WindowsDevice.supportsFlavors returns true, so flutter run -d windows --flavor X no longer warns and now drives the flavored build pipeline.
Build directory is namespaced per flavor: build/windows/<arch>/<flavor>/runner/<Config>/ (parity with Android/iOS/macOS). Projects that don't pass --flavor keep the legacy build/windows/<arch>/runner/<Config>/ layout — no migration required.
CMake configure receives -DFLUTTER_APP_FLAVOR=<flavor> so the generated project can react to the flavor at configure time.
Generated CMake template (windows.tmpl/CMakeLists.txt.tmpl) suffixes BINARY_NAME with -<flavor> when FLUTTER_APP_FLAVOR is defined. The branch is guarded by if(DEFINED FLUTTER_APP_FLAVOR AND NOT FLUTTER_APP_FLAVOR STREQUAL ""), so existing projects regenerated from this template behave identically when no flavor is passed.
Runner template (windows.tmpl/runner/CMakeLists.txt + main.cpp.tmpl) exposes FLUTTER_APP_FLAVOR as a compile-time preprocessor define via target_compile_definitions and uses it to suffix the Win32 window title, giving projects a one-line entry point for flavor-aware native behavior without any additional Flutter tool surface area.
Runner resource template (windows.tmpl/runner/Runner.rc.tmpl) introduces a FLUTTER_BINARY_NAME preprocessor define — injected via the same target_compile_definitions mechanism already used for FLUTTER_VERSION_* — and uses it for the InternalName and OriginalFilename PE metadata fields, so the version resource stays in sync with the actual on-disk binary name regardless of flavor.
Dart-side continues to use the existing appFlavor getter from package:flutter/services.dart, which reads FLUTTER_APP_FLAVOR from the dart-defines that toEnvironmentConfig() already produces. No framework changes required.

Design choices

Build directory nests flavor above runner/<Config>: the runner/<Config> leaf reflects the Visual Studio multi-config generator (Debug/Profile/Release are subdirectories chosen at build time, not at CMake configure time). Inserting the flavor above this segment keeps the VS solution reusable across modes for a given flavor.
FLUTTER_BINARY_NAME in Runner.rc: PE metadata correctness matters because tools (installers, code-signing pipelines, Windows Error Reporting) read OriginalFilename and InternalName from the version resource. Passing the CMake variable as a preprocessor define costs nothing and avoids any configure_file indirection in the template.
Per-flavor assets, icons, Package.appxmanifest, and installer scripts remain the project's responsibility — this PR intentionally keeps the tool agnostic and only standardizes the plumbing.

Tests

New test/general.shard/windows/build_windows_flavor_test.dart covers:
- flutter build windows --flavor apple invokes CMake with -DFLUTTER_APP_FLAVOR=apple and a flavor-namespaced working directory, and the success log references build\windows\x64\apple\runner\Release\.
- getCmakeExecutableName returns the base binary name without a flavor, and name-flavor when a flavor is provided (empty string treated as no flavor).
- getWindowsBuildDirectory returns the legacy path without a flavor and inserts the flavor segment when one is provided.
Existing test/commands.shard/hermetic/build_windows_test.dart continues to pass with no changes, confirming the legacy no-flavor path is unaffected.

Manual verification

Generated an example project, then ran the full matrix:

flutter build windows --flavor apple   # → build\windows\x64\apple\runner\Release\example-apple.exe
flutter build windows --flavor banana  # → build\windows\x64\banana\runner\Release\example-banana.exe
flutter build windows                  # → build\windows\x64\runner\Release\example.exe (unchanged)
flutter run -d windows --flavor apple  # launches, no "unsupported flavor" warning

All three builds coexist in build\windows\x64\ without overwriting each other, the Win32 window title reflects the flavor, and the Dart UI reads appFlavor correctly at runtime in each binary. PE metadata (InternalName, OriginalFilename) matches the actual filename in all three cases.

Backward compatibility

Projects that never pass --flavor see no change: same build directory, same binary name, same generated CMake.
Existing projects do not need to regenerate windows/CMakeLists.txt to keep working; they only need to regenerate (or hand-patch the if(DEFINED FLUTTER_APP_FLAVOR) branch) to opt into flavor support.

Fixes #98994

Pre-launch Checklist

gemini-code-assist

Code Review

This pull request implements flavor support for Windows builds. The changes include updating the build directory structure to accommodate flavors, suffixing the executable name with the flavor string, and modifying the C++ runner template to display the flavor in the window title. Corresponding tests were added to verify the new functionality. A review comment identifies a potential crash in the C++ runner template due to missing error handling in the string conversion logic, which could lead to an underflow and exception.

kjxbyz · 2026-05-24T16:03:33Z

Hello! I'm really looking forward to this feature. I have a question: how should resource files be handled? For example: windows/runner/resources/app_icon.ico.

AngeloAvv · 2026-05-24T16:25:58Z

Hello! I'm really looking forward to this feature. I have a question: how should resource files be handled? For example: windows/runner/resources/app_icon.ico.

You can do it by setting custom variables in CMakeLists.txt, for example:

if(FLUTTER_APP_FLAVOR STREQUAL "apple")
  set(RUNNER_APP_ICON "apple.ico")
  set(WINDOW_TITLE "Apple")
elseif(FLUTTER_APP_FLAVOR STREQUAL "banana")
  set(RUNNER_APP_ICON "banana.ico")
  set(WINDOW_TITLE "Banana")
else()
  set(RUNNER_APP_ICON "app_icon.ico")
  set(WINDOW_TITLE "windows_flavors")
endif()

configure_file(
  "${CMAKE_CURRENT_SOURCE_DIR}/Runner.rc.in"
  "${CMAKE_CURRENT_SOURCE_DIR}/Runner.rc"
  @ONLY
)
configure_file(
  "${CMAKE_CURRENT_SOURCE_DIR}/main.cpp.in"
  "${CMAKE_CURRENT_SOURCE_DIR}/main.cpp"
  @ONLY
)

and then postprocess them using Runner.rc.in:

/////////////////////////////////////////////////////////////////////////////
//
// Icon
//

// Icon with lowest ID value placed first to ensure application icon
// remains consistent on all systems.
IDI_APP_ICON            ICON                    "resources\\@RUNNER_APP_ICON@"

Same applies for custom titles in main.cpp.in:

#include <flutter/dart_project.h>
#include <flutter/flutter_view_controller.h>
#include <windows.h>

#include "flutter_window.h"
#include "utils.h"

int APIENTRY wWinMain(_In_ HINSTANCE instance, _In_opt_ HINSTANCE prev,
                      _In_ wchar_t *command_line, _In_ int show_command) {
  // Attach to console when present (e.g., 'flutter run') or create a
  // new console when running with a debugger.
  if (!::AttachConsole(ATTACH_PARENT_PROCESS) && ::IsDebuggerPresent()) {
    CreateAndAttachConsole();
  }

  // Initialize COM, so that it is available for use in the library and/or
  // plugins.
  ::CoInitializeEx(nullptr, COINIT_APARTMENTTHREADED);

  flutter::DartProject project(L"data");

  std::vector<std::string> command_line_arguments =
      GetCommandLineArguments();

  project.set_dart_entrypoint_arguments(std::move(command_line_arguments));

  FlutterWindow window(project);
  Win32Window::Point origin(10, 10);
  Win32Window::Size size(1280, 720);
  if (!window.Create(L"@WINDOW_TITLE@", origin, size)) {
    return EXIT_FAILURE;
  }
  window.SetQuitOnClose(true);

  ::MSG msg;
  while (::GetMessage(&msg, nullptr, 0, 0)) {
    ::TranslateMessage(&msg);
    ::DispatchMessage(&msg);
  }

  ::CoUninitialize();
  return EXIT_SUCCESS;
}

kjxbyz · 2026-05-24T16:40:17Z

configure_file(
  "${CMAKE_CURRENT_SOURCE_DIR}/Runner.rc.in"
  "${CMAKE_CURRENT_SOURCE_DIR}/Runner.rc"
  @ONLY
)
configure_file(
  "${CMAKE_CURRENT_SOURCE_DIR}/main.cpp.in"
  "${CMAKE_CURRENT_SOURCE_DIR}/main.cpp"
  @ONLY
)

Should I rename Runner.rc and main.cpp to Runner.rc.in and main.cpp.in?

mattkae

Nice tests! I have a comment about the generated C++ if we can improve it

Fixed threads

mattkae

This is working well for me, thanks for the work on this! @loic-sharma do you have anything that you want to add?

loic-sharma · 2026-06-01T19:50:43Z

@AngeloAvv It looks like this PR missed flavors in a few places:

This warning should be updated:

flutter/packages/flutter_tools/lib/src/commands/run.dart

Line 747 in 3648ed5

'--flavor is only supported for Android, macOS, and iOS devices. '

The BundleWindowAssets target needs to be updated to include the right assets for the current flavor (see these docs):

flutter/packages/flutter_tools/lib/src/build_system/targets/windows.dart

Lines 148 to 159 in 3648ed5

    
           final Depfile depfile = await copyAssets( 
        
             environment, 
        
             outputDirectory, 
        
             dartHookResult: dartHookResult, 
        
             targetPlatform: targetPlatform, 
        
             buildMode: buildMode, 
        
             additionalContent: <String, DevFSContent>{ 
        
               'NativeAssetsManifest.json': DevFSFileContent( 
        
                 environment.buildDir.childFile('native_assets.json'), 
        
               ), 
        
             }, 
        
           );

The flavors integration test needs to be updated: 1, 2, 3. See these instructions on how to add a new DeviceLab test: https://github.com/flutter/flutter/blob/master/dev/devicelab/README.md

AngeloAvv · 2026-06-10T20:37:43Z

@loic-sharma let me know if the fixes make sense to you. In the meanwhile I aligned the Linux PR as well

kjxbyz · 2026-06-25T23:49:41Z

The tool still exposes the selected flavor as a FLUTTER_APP_FLAVOR CMake variable in the generated config (the default template doesn't use it). This is purely a mechanism that lets a project opt in to flavor-specific resources (e.g. app icon or window title) via configure_file, without the template imposing any policy.

Is the new change allowing users to set the application id, binary name, app icon, and title in a single line using the built-in FLUTTER_APP_FLAVOR?

loic-sharma

Re-LGTM

auto-submit · 2026-06-26T19:52:37Z

autosubmit label was removed for flutter/flutter/187034, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

kjxbyz · 2026-06-28T01:17:31Z

Please add the document.

…#12081) Manual roll Flutter from 0c80830e465b to ca9f874f5284 (119 revisions) Manual roll requested by [email protected] flutter/flutter@0c80830...ca9f874 2026-06-30 [email protected] [tool] Don't require a Flutter compile task when staging jniLibs (flutter/flutter#188805) 2026-06-30 [email protected] [Impeller] Fix potential overflow when allocating buffers at the next power of two size (flutter/flutter#188742) 2026-06-30 [email protected] [Framework/Tool] Decouple preview theme imports (flutter/flutter#188176) 2026-06-30 [email protected] Add import of `dart:_js_interop_wasm` in sdk rewriter tool (flutter/flutter#188620) 2026-06-30 [email protected] Detach LLDB and print stack trace on process stop (flutter/flutter#188576) 2026-06-30 [email protected] [Linux] Fix FlCompositorOpenGL.pixels comment (flutter/flutter#188754) 2026-06-30 [email protected] [flutter_tools] Fix crash in flutter create when pubspec.yaml is empty (flutter/flutter#188385) 2026-06-30 [email protected] Roll Packages from 656ccaa to 274ed3e (23 revisions) (flutter/flutter#188792) 2026-06-30 [email protected] In AndroidImageGenerator, check that the destination pixel buffer has sufficient capacity for the decoded data (flutter/flutter#188752) 2026-06-30 [email protected] Roll pub packages (flutter/flutter#188773) 2026-06-30 [email protected] [Impeller] Add a flat VertexAttributeFormat for vertex inputs (flutter/flutter#188684) 2026-06-30 [email protected] Roll pub packages (flutter/flutter#188764) 2026-06-30 [email protected] Roll Dart SDK from 0cb483880b6b to e1bdb9ce3327 (2 revisions) (flutter/flutter#188763) 2026-06-29 [email protected] Handle 'no permissions' adb device state (flutter/flutter#187248) 2026-06-29 [email protected] [windows]: adjusts uniform buffers to hit hlsl optimization (flutter/flutter#188538) 2026-06-29 [email protected] Roll Skia from bfb7860cb9c7 to 71947c4110b0 (9 revisions) (flutter/flutter#188747) 2026-06-29 [email protected] ci: extract wait-for-engine-build logic into a reusable composite action (flutter/flutter#188748) 2026-06-29 [email protected] Provide guided migration logs when iOS app crashes on simulator (flutter/flutter#188736) 2026-06-29 [email protected] Revert "[flutter_tools] Track asset transformer dependencies for hot reload" (flutter/flutter#188751) 2026-06-29 [email protected] Migrate ABI splits to new AGP dsl (flutter/flutter#188369) 2026-06-29 [email protected] Add Impeller+OpenGLES startup benchmark for mokey (flutter/flutter#188495) 2026-06-29 [email protected] Increase macOS minimum supported version from 10.15 to 12 to support Xcode 27 (flutter/flutter#188520) 2026-06-29 [email protected] Moves test ownership validation to flutter/flutter (flutter/flutter#188655) 2026-06-29 [email protected] Add --flavor support for Windows desktop builds (flutter/flutter#187034) 2026-06-29 [email protected] Android_hardware_smoke_test: Enable pixel exact local file comparator to read goldens from flutter asset URI (flutter/flutter#188587) 2026-06-29 [email protected] [flutter_tools] Use DeviceHub.app for iOS simulator path on Xcode 27+ (flutter/flutter#187910) 2026-06-29 [email protected] Roll Skia from 111e7582d081 to bfb7860cb9c7 (2 revisions) (flutter/flutter#188731) 2026-06-29 [email protected] Use `revert` label instead of `revert_wf` (flutter/flutter#188639) 2026-06-29 [email protected] Properly await Dart Development Service shutdown with timeout (flutter/flutter#188387) 2026-06-29 [email protected] [flutter_tools] Track asset transformer dependencies for hot reload (flutter/flutter#187947) 2026-06-29 [email protected] [Tool] Tolerate malformed UTF-8 in process streaming decoders (flutter/flutter#188453) 2026-06-29 [email protected] [flutter_tools] Use new ddc modules in test (flutter/flutter#188240) 2026-06-29 [email protected] Roll Packages from c1f7d92 to 656ccaa (12 revisions) (flutter/flutter#188728) 2026-06-29 [email protected] Remove unused fields (flutter/flutter#188705) 2026-06-29 [email protected] Clear text input handler widget on view dispose (flutter/flutter#188701) 2026-06-29 [email protected] Free compositor in view renderer finalize to avoid use-after-free (flutter/flutter#188702) 2026-06-29 [email protected] [linux] Use GWeakRef in mock signal handler test helper (flutter/flutter#188700) 2026-06-29 [email protected] Fixing few related editing issues with LTR/RTL text (flutter/flutter#188503) 2026-06-29 [email protected] [Flutter GPU] Add Texture.fromImage to wrap a ui.Image texture (flutter/flutter#188605) 2026-06-29 [email protected] [Flutter GPU] Honor the enable argument in RenderPass.setDepthWriteEnable (flutter/flutter#188715) 2026-06-29 [email protected] Roll Skia from ba1942d8c3e1 to 111e7582d081 (1 revision) (flutter/flutter#188721) 2026-06-29 [email protected] Roll Skia from 587d8befe1ee to ba1942d8c3e1 (6 revisions) (flutter/flutter#188717) 2026-06-29 [email protected] Remove some refs to package:intl (flutter/flutter#188504) 2026-06-29 [email protected] [VPAT] Update a11y assessment app FAB example to announce value change when it's updated. (flutter/flutter#188466) ...

…flutter#12081) Manual roll Flutter from 0c80830e465b to ca9f874f5284 (119 revisions) Manual roll requested by [email protected] flutter/flutter@0c80830...ca9f874 2026-06-30 [email protected] [tool] Don't require a Flutter compile task when staging jniLibs (flutter/flutter#188805) 2026-06-30 [email protected] [Impeller] Fix potential overflow when allocating buffers at the next power of two size (flutter/flutter#188742) 2026-06-30 [email protected] [Framework/Tool] Decouple preview theme imports (flutter/flutter#188176) 2026-06-30 [email protected] Add import of `dart:_js_interop_wasm` in sdk rewriter tool (flutter/flutter#188620) 2026-06-30 [email protected] Detach LLDB and print stack trace on process stop (flutter/flutter#188576) 2026-06-30 [email protected] [Linux] Fix FlCompositorOpenGL.pixels comment (flutter/flutter#188754) 2026-06-30 [email protected] [flutter_tools] Fix crash in flutter create when pubspec.yaml is empty (flutter/flutter#188385) 2026-06-30 [email protected] Roll Packages from 656ccaa to 274ed3e (23 revisions) (flutter/flutter#188792) 2026-06-30 [email protected] In AndroidImageGenerator, check that the destination pixel buffer has sufficient capacity for the decoded data (flutter/flutter#188752) 2026-06-30 [email protected] Roll pub packages (flutter/flutter#188773) 2026-06-30 [email protected] [Impeller] Add a flat VertexAttributeFormat for vertex inputs (flutter/flutter#188684) 2026-06-30 [email protected] Roll pub packages (flutter/flutter#188764) 2026-06-30 [email protected] Roll Dart SDK from 0cb483880b6b to e1bdb9ce3327 (2 revisions) (flutter/flutter#188763) 2026-06-29 [email protected] Handle 'no permissions' adb device state (flutter/flutter#187248) 2026-06-29 [email protected] [windows]: adjusts uniform buffers to hit hlsl optimization (flutter/flutter#188538) 2026-06-29 [email protected] Roll Skia from bfb7860cb9c7 to 71947c4110b0 (9 revisions) (flutter/flutter#188747) 2026-06-29 [email protected] ci: extract wait-for-engine-build logic into a reusable composite action (flutter/flutter#188748) 2026-06-29 [email protected] Provide guided migration logs when iOS app crashes on simulator (flutter/flutter#188736) 2026-06-29 [email protected] Revert "[flutter_tools] Track asset transformer dependencies for hot reload" (flutter/flutter#188751) 2026-06-29 [email protected] Migrate ABI splits to new AGP dsl (flutter/flutter#188369) 2026-06-29 [email protected] Add Impeller+OpenGLES startup benchmark for mokey (flutter/flutter#188495) 2026-06-29 [email protected] Increase macOS minimum supported version from 10.15 to 12 to support Xcode 27 (flutter/flutter#188520) 2026-06-29 [email protected] Moves test ownership validation to flutter/flutter (flutter/flutter#188655) 2026-06-29 [email protected] Add --flavor support for Windows desktop builds (flutter/flutter#187034) 2026-06-29 [email protected] Android_hardware_smoke_test: Enable pixel exact local file comparator to read goldens from flutter asset URI (flutter/flutter#188587) 2026-06-29 [email protected] [flutter_tools] Use DeviceHub.app for iOS simulator path on Xcode 27+ (flutter/flutter#187910) 2026-06-29 [email protected] Roll Skia from 111e7582d081 to bfb7860cb9c7 (2 revisions) (flutter/flutter#188731) 2026-06-29 [email protected] Use `revert` label instead of `revert_wf` (flutter/flutter#188639) 2026-06-29 [email protected] Properly await Dart Development Service shutdown with timeout (flutter/flutter#188387) 2026-06-29 [email protected] [flutter_tools] Track asset transformer dependencies for hot reload (flutter/flutter#187947) 2026-06-29 [email protected] [Tool] Tolerate malformed UTF-8 in process streaming decoders (flutter/flutter#188453) 2026-06-29 [email protected] [flutter_tools] Use new ddc modules in test (flutter/flutter#188240) 2026-06-29 [email protected] Roll Packages from c1f7d92 to 656ccaa (12 revisions) (flutter/flutter#188728) 2026-06-29 [email protected] Remove unused fields (flutter/flutter#188705) 2026-06-29 [email protected] Clear text input handler widget on view dispose (flutter/flutter#188701) 2026-06-29 [email protected] Free compositor in view renderer finalize to avoid use-after-free (flutter/flutter#188702) 2026-06-29 [email protected] [linux] Use GWeakRef in mock signal handler test helper (flutter/flutter#188700) 2026-06-29 [email protected] Fixing few related editing issues with LTR/RTL text (flutter/flutter#188503) 2026-06-29 [email protected] [Flutter GPU] Add Texture.fromImage to wrap a ui.Image texture (flutter/flutter#188605) 2026-06-29 [email protected] [Flutter GPU] Honor the enable argument in RenderPass.setDepthWriteEnable (flutter/flutter#188715) 2026-06-29 [email protected] Roll Skia from ba1942d8c3e1 to 111e7582d081 (1 revision) (flutter/flutter#188721) 2026-06-29 [email protected] Roll Skia from 587d8befe1ee to ba1942d8c3e1 (6 revisions) (flutter/flutter#188717) 2026-06-29 [email protected] Remove some refs to package:intl (flutter/flutter#188504) 2026-06-29 [email protected] [VPAT] Update a11y assessment app FAB example to announce value change when it's updated. (flutter/flutter#188466) ...

AngeloAvv requested a review from a team as a code owner May 24, 2026 12:21

github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. platform-windows Building on or for Windows specifically a: desktop Running on desktop team-windows Owned by the Windows platform team labels May 24, 2026

gemini-code-assist Bot reviewed May 24, 2026

View reviewed changes

Comment thread packages/flutter_tools/templates/app/windows.tmpl/runner/main.cpp.tmpl Outdated

AngeloAvv mentioned this pull request May 24, 2026

Support Windows and Linux AngeloAvv/flutter_flavorizr#182

Closed

mattkae reviewed May 27, 2026

View reviewed changes

Comment thread packages/flutter_tools/templates/app/windows.tmpl/runner/main.cpp.tmpl Outdated

Comment thread packages/flutter_tools/templates/app/windows.tmpl/runner/main.cpp.tmpl Outdated

mattkae requested a review from loic-sharma May 27, 2026 17:58

AngeloAvv added 3 commits May 27, 2026 21:29

Add --flavor support for Windows desktop builds

2992c1d

Update main.cpp.tmpl

8027ea6

Fixed threads

Fixed threads

32b01b2

AngeloAvv force-pushed the add-windows-flavors-support branch from d8ac7c3 to 32b01b2 Compare May 27, 2026 19:33

AngeloAvv requested a review from mattkae May 27, 2026 19:35

mattkae previously approved these changes May 28, 2026

View reviewed changes

loic-sharma reviewed Jun 1, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/windows/build_windows.dart Outdated

loic-sharma reviewed Jun 1, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/windows/build_windows.dart Outdated

loic-sharma mentioned this pull request Jun 4, 2026

Add --flavor support for Linux desktop builds #187029

Merged

10 tasks

Added integration tests and moved flavor logic to cmake

a19b12e

AngeloAvv dismissed mattkae’s stale review via a19b12e June 6, 2026 14:55

Merge branch 'flutter:master' into add-windows-flavors-support

09106ac

AngeloAvv requested a review from loic-sharma June 6, 2026 15:02

AngeloAvv added 2 commits June 22, 2026 19:33

Merge branch 'flutter:master' into add-windows-flavors-support

08bb10a

Merge branch 'flutter:master' into add-windows-flavors-support

7dea728

loic-sharma reviewed Jun 24, 2026

View reviewed changes

Comment thread dev/devicelab/bin/tasks/flavors_test_windows.dart Outdated

loic-sharma added the CICD Run CI/CD label Jun 25, 2026

AngeloAvv added a commit to AngeloAvv/flutter that referenced this pull request Jun 25, 2026

Fixed threads following Windows PR (flutter#187034)

ee6d2a4

loic-sharma approved these changes Jun 26, 2026

View reviewed changes

AngeloAvv requested a review from mattkae June 26, 2026 17:37

loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2026

kjxbyz mentioned this pull request Jun 27, 2026

[Stable]: Cherry-pick Request for #187034 and #187029 #188673

Closed

mattkae approved these changes Jun 29, 2026

View reviewed changes

loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2026

auto-submit Bot added this pull request to the merge queue Jun 29, 2026

Merged via the queue into flutter:master with commit 0145a67 Jun 29, 2026
184 of 185 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2026

Piinks mentioned this pull request Jul 10, 2026

Flutter Notable Commits - 2026 #181433

Open

Uh oh!

Conversation

AngeloAvv commented May 24, 2026

What changes

Design choices

Tests

Manual verification

Backward compatibility

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

kjxbyz commented May 24, 2026

Uh oh!

AngeloAvv commented May 24, 2026

Uh oh!

kjxbyz commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattkae left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mattkae left a comment

Choose a reason for hiding this comment

Uh oh!

loic-sharma commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AngeloAvv commented Jun 10, 2026

Uh oh!

Uh oh!

kjxbyz commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Jun 26, 2026

Uh oh!

kjxbyz commented Jun 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kjxbyz commented May 24, 2026 •

edited

Loading

loic-sharma commented Jun 1, 2026 •

edited

Loading

kjxbyz commented Jun 25, 2026 •

edited

Loading