Skip to content

[web] Fix WebParagraph locales test#186813

Merged
auto-submit[bot] merged 5 commits into
flutter:masterfrom
mdebbar:webparagraph_locale_test
May 28, 2026
Merged

[web] Fix WebParagraph locales test#186813
auto-submit[bot] merged 5 commits into
flutter:masterfrom
mdebbar:webparagraph_locale_test

Conversation

@mdebbar

@mdebbar mdebbar commented May 20, 2026

Copy link
Copy Markdown
Contributor

Part of #172561

@mdebbar mdebbar requested a review from Rusino May 20, 2026 15:48
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 20, 2026
@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels May 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the paragraph_test.dart file to change the fontFamily from 'Noto Sans' to 'Roboto' within a WebParagraphStyle instance. I have no feedback to provide.

Rusino
Rusino previously approved these changes May 20, 2026

@Rusino Rusino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2026
@auto-submit

auto-submit Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/186813, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mdebbar mdebbar added CICD Run CI/CD and removed CICD Run CI/CD labels May 21, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label May 21, 2026
@mdebbar mdebbar added the CICD Run CI/CD label May 21, 2026
@flutter-dashboard

Copy link
Copy Markdown

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #186813 at sha 3e0007f

@flutter-dashboard flutter-dashboard Bot added the will affect goldens Changes to golden files label May 21, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label May 26, 2026
@mdebbar mdebbar added the CICD Run CI/CD label May 26, 2026
@mdebbar mdebbar requested a review from Rusino May 27, 2026 19:05
@github-actions github-actions Bot removed the CICD Run CI/CD label May 27, 2026
@mdebbar mdebbar added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels May 27, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 27, 2026
@auto-submit

auto-submit Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/186813, because - The status or check suite Mac gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue May 28, 2026
Merged via the queue into flutter:master with commit ed53474 May 28, 2026
210 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 28, 2026
@mdebbar mdebbar deleted the webparagraph_locale_test branch May 28, 2026 17:38
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 29, 2026
flutter/flutter@e70534d...b05a9d7

2026-05-29 [email protected] Roll Skia from 47155534833e to d9d6b440c4e7 (1 revision) (flutter/flutter#187301)
2026-05-29 [email protected] Roll Skia from f93ed13d77fb to 47155534833e (4 revisions) (flutter/flutter#187291)
2026-05-29 [email protected] [web_ui] Optimize skwasm text layout and path decoding to eliminate dynamic boxing churn under Wasm (flutter/flutter#186978)
2026-05-29 [email protected] Roll Fuchsia Linux SDK from SBpmmPxqx3lAvGojE... to jMR_VXQi07kAk8vbR... (flutter/flutter#187279)
2026-05-29 [email protected] Remove Material import from sliver tree rendering test (flutter/flutter#187000)
2026-05-29 [email protected] [Impeller] Remove the y_coord_scale Y-flip plumbing (flutter/flutter#187224)
2026-05-29 [email protected] Add/remove overlay child RenderObject from the tree in `attach`/`detach` (flutter/flutter#186564)
2026-05-29 [email protected] Roll Skia from fcfe5975c945 to f93ed13d77fb (4 revisions) (flutter/flutter#187273)
2026-05-28 [email protected] Handle complex RSE rendering in the uber SDF pipeline (flutter/flutter#186434)
2026-05-28 [email protected] Roll Dart SDK from 082191101fcc to 683322426411 (2 revisions) (flutter/flutter#187270)
2026-05-28 [email protected] Clarify route transition animations (flutter/flutter#186552)
2026-05-28 [email protected] document that the default Key is null and explain proper usage in list diffing (flutter/flutter#185197)
2026-05-28 [email protected] [flutter_tools] Use super parameters in missed spots (flutter/flutter#186197)
2026-05-28 [email protected] docs: Document MediaQueryData.alwaysUse24HourFormat on macOS, Windows, Linux, web (#160664) (flutter/flutter#186642)
2026-05-28 [email protected] Roll Skia from 5493e4c144cd to fcfe5975c945 (3 revisions) (flutter/flutter#187256)
2026-05-28 [email protected] Shares opengles golden context (flutter/flutter#187243)
2026-05-28 [email protected] Update the Curl CIPD package in .ci.yaml to version 8.20.0 (flutter/flutter#187133)
2026-05-28 [email protected] Improve SizedBox's docs (flutter/flutter#187208)
2026-05-28 [email protected] [Impeller] Support instanced rendering across all backends (flutter/flutter#186653)
2026-05-28 [email protected] [Android] Reset system UI visibility flags when setting edge-to-edge mode (flutter/flutter#187207)
2026-05-28 [email protected] Roll Skia from a38708fb7926 to 5493e4c144cd (7 revisions) (flutter/flutter#187241)
2026-05-28 [email protected] Turned on impeller by default on macos (flutter/flutter#186546)
2026-05-28 [email protected] Clarify lazy scroll extent docs (flutter/flutter#186864)
2026-05-28 [email protected] [web] Fix WebParagraph locales test (flutter/flutter#186813)
2026-05-28 [email protected] Roll Packages from 4b424d7 to 10cbdc5 (3 revisions) (flutter/flutter#187238)
2026-05-28 [email protected] Roll Dart SDK from f3db7b7d9801 to 082191101fcc (8 revisions) (flutter/flutter#187235)
2026-05-28 [email protected] Roll Skia from 32acea791248 to a38708fb7926 (1 revision) (flutter/flutter#187221)
2026-05-28 [email protected] [Flutter GPU] Add r32Float and remove Apple-only XR pixel formats (flutter/flutter#187069)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-web Web applications specifically will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants