Manual Dart roll from 66873d2da857 to 84220a34788e#186812
Conversation
Includes updates for the renaming of some snapshot symbols (see https://dart.googlesource.com/sdk.git/+/d36adbacafee01d9852cf8e960cf2d8654d91e7e)
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the requiredSymbols list in AppleTestUtils by adding _kDartSnapshotData and _kDartSnapshotText. Feedback indicates that the old symbols _kDartIsolateSnapshotData and _kDartIsolateSnapshotInstructions should be removed to reflect renaming in the Dart SDK, and that _kDartSnapshotText is likely a typo for _kDartSnapshotInstructions.
jason-simmons
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/186812, because - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
jason-simmons
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
Includes updates for the renaming of some snapshot symbols (see https://dart.googlesource.com/sdk.git/+/d36adbacafee01d9852cf8e960cf2d8654d91e7e)
3 participants
Includes updates for the renaming of some snapshot symbols (see https://dart.googlesource.com/sdk.git/+/d36adbacafee01d9852cf8e960cf2d8654d91e7e)