Update the list of binaries in the code signing verification test to include new Dart snapshots#186754
Merged
jtmcdole merged 4 commits intoMay 19, 2026
Conversation
…include new Dart snapshots A recent Dart roll (flutter#186690) changed the format of Dart AOT snapshots so that they are now recognized as binaries by run_verify_binaries_codesigned_tests. The list of expected binaries needs to be updated accordingly.
gaaclarke
previously approved these changes
May 19, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds several Dart SDK and engine snapshots to the list of binaries requiring entitlements for code signing verification in run_verify_binaries_codesigned_tests.dart. Feedback suggests sorting the newly added snapshot paths alphabetically to maintain consistency and improve maintainability, as per the style guide.
jtmcdole
previously approved these changes
May 19, 2026
jason-simmons
added
autosubmit
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
jason-simmons
removed
autosubmit
gaaclarke
approved these changes
May 19, 2026
rmacnak-google
approved these changes
May 19, 2026
jason-simmons
added
autosubmit
jtmcdole
approved these changes
May 19, 2026
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
|
fyi, those golden diffs are flakes, there is an issue for that that is currently being worked on by the android team. |
Member
|
CiSuccessful check on AutoSubmit failed for some reason. Investigating |
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced May 20, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 20, 2026
flutter/flutter@259aeae...e03b91f 2026-05-20 [email protected] Roll Packages from ade10ca to 1dfbada (6 revisions) (flutter/flutter#186811) 2026-05-20 [email protected] Fix AnimatedList.separated assert when removing last item mid-removal… (flutter/flutter#186389) 2026-05-20 [email protected] Roll Skia from d45969a5752e to 5f4f454b9662 (2 revisions) (flutter/flutter#186809) 2026-05-20 [email protected] Roll Fuchsia Linux SDK from -F9Ci3Opxt06MixDl... to iKCvaD58jKStYGla0... (flutter/flutter#186796) 2026-05-20 [email protected] Roll Skia from 19ad9707e5c6 to d45969a5752e (2 revisions) (flutter/flutter#186792) 2026-05-20 [email protected] Roll Skia from 3471ebf5af0c to 19ad9707e5c6 (9 revisions) (flutter/flutter#186772) 2026-05-20 [email protected] [web] Refactor webparagraph painters to separate CK properly (flutter/flutter#186684) 2026-05-19 [email protected] Enable Swift testing in the iOS embedder (flutter/flutter#185712) 2026-05-19 [email protected] [web] Rename WebParagraph goldens (flutter/flutter#186680) 2026-05-19 [email protected] Roll Skia from f1b406860c5e to 3471ebf5af0c (5 revisions) (flutter/flutter#186745) 2026-05-19 [email protected] Revert "Ship gen_snapshot for linux-arm64 hosts targeting Android" (flutter/flutter#186693) 2026-05-19 [email protected] [ Tool ] Remove legacy analytics code (flutter/flutter#184994) 2026-05-19 [email protected] Update Vulkan enum values (flutter/flutter#186694) 2026-05-19 [email protected] fix(web): Fixes CSS override detection when the browser has a default font size (flutter/flutter#186474) 2026-05-19 [email protected] adds linux impeller hello world integration test (flutter/flutter#186715) 2026-05-19 [email protected] Update the list of binaries in the code signing verification test to include new Dart snapshots (flutter/flutter#186754) 2026-05-19 [email protected] Make EdgeDraggingAutoScroller respect ScrollPhysics (flutter/flutter#186541) 2026-05-19 [email protected] [ Widget Preview ] Fix inspector split resize focus loss over WebViews (flutter/flutter#186432) 2026-05-19 [email protected] Roll Packages from b9bdd37 to ade10ca (1 revision) (flutter/flutter#186746) 2026-05-19 [email protected] Manual Dart roll from 8e30b88e4d5a to 66873d2da857 (flutter/flutter#186690) 2026-05-19 [email protected] [ Widget Preview ] Improve zoom behavior and add zoom slider (flutter/flutter#186422) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
matthewhendrix
pushed a commit
to matthewhendrix/flutter
that referenced
this pull request
May 23, 2026
…include new Dart snapshots (flutter#186754) A recent Dart roll (flutter#186690) changed the format of Dart AOT snapshots so that they are now recognized as binaries by run_verify_binaries_codesigned_tests. The list of expected binaries needs to be updated accordingly.
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11747) flutter/flutter@259aeae...e03b91f 2026-05-20 [email protected] Roll Packages from ade10ca to 1dfbada (6 revisions) (flutter/flutter#186811) 2026-05-20 [email protected] Fix AnimatedList.separated assert when removing last item mid-removal… (flutter/flutter#186389) 2026-05-20 [email protected] Roll Skia from d45969a5752e to 5f4f454b9662 (2 revisions) (flutter/flutter#186809) 2026-05-20 [email protected] Roll Fuchsia Linux SDK from -F9Ci3Opxt06MixDl... to iKCvaD58jKStYGla0... (flutter/flutter#186796) 2026-05-20 [email protected] Roll Skia from 19ad9707e5c6 to d45969a5752e (2 revisions) (flutter/flutter#186792) 2026-05-20 [email protected] Roll Skia from 3471ebf5af0c to 19ad9707e5c6 (9 revisions) (flutter/flutter#186772) 2026-05-20 [email protected] [web] Refactor webparagraph painters to separate CK properly (flutter/flutter#186684) 2026-05-19 [email protected] Enable Swift testing in the iOS embedder (flutter/flutter#185712) 2026-05-19 [email protected] [web] Rename WebParagraph goldens (flutter/flutter#186680) 2026-05-19 [email protected] Roll Skia from f1b406860c5e to 3471ebf5af0c (5 revisions) (flutter/flutter#186745) 2026-05-19 [email protected] Revert "Ship gen_snapshot for linux-arm64 hosts targeting Android" (flutter/flutter#186693) 2026-05-19 [email protected] [ Tool ] Remove legacy analytics code (flutter/flutter#184994) 2026-05-19 [email protected] Update Vulkan enum values (flutter/flutter#186694) 2026-05-19 [email protected] fix(web): Fixes CSS override detection when the browser has a default font size (flutter/flutter#186474) 2026-05-19 [email protected] adds linux impeller hello world integration test (flutter/flutter#186715) 2026-05-19 [email protected] Update the list of binaries in the code signing verification test to include new Dart snapshots (flutter/flutter#186754) 2026-05-19 [email protected] Make EdgeDraggingAutoScroller respect ScrollPhysics (flutter/flutter#186541) 2026-05-19 [email protected] [ Widget Preview ] Fix inspector split resize focus loss over WebViews (flutter/flutter#186432) 2026-05-19 [email protected] Roll Packages from b9bdd37 to ade10ca (1 revision) (flutter/flutter#186746) 2026-05-19 [email protected] Manual Dart roll from 8e30b88e4d5a to 66873d2da857 (flutter/flutter#186690) 2026-05-19 [email protected] [ Widget Preview ] Improve zoom behavior and add zoom slider (flutter/flutter#186422) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
camsim99
added
the
cp: beta
auto-submit Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
… test to include new Dart snapshots (#188050) to unblock the beta candidate tree. This CP combines #186754 and #187378. Also added an empty line to a `.mm` file to trigger engine rebuild. This change won't be merged back to master so the empty line should be fine. This commit, if merged, won't have an entry in the changelog since it is not user-facing / does not affect app / plugin devs. Re: the list of binaries, [the most recent 2 commits on master](https://github.com/flutter/flutter/commits/master/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart) that edited `run_verify_binaries_codesigned_tests.dart` have both been cherry-picked into the beta branch. I have verified that `git diff upstream/master -- dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart` is clean. `SHARD=verify_binaries_pre_codesigned bin/cache/dart-sdk/bin/dart dev/bots/test.dart` fails but that's likely because the engine revision was still on 0a9f488c13. The current dart revision is [aad8be4ce3077a809f0b4f3325c6d8a6908aad54](https://dart.googlesource.com/sdk/+show/aad8be4ce3077a809f0b4f3325c6d8a6908aad54) > Version 3.13.0-167.1.beta > > Merge 3.13.0-167.0.dev into beta The dart revision associated with #186754 was [66873d2da857](https://dart.googlesource.com/sdk/+show/66873d2da857), > Version 3.13.0-108.0.dev > > Merge 0aa709e8cce030d45dd6173f70e6963752f0130e into dev The dart revision associated with #187378 was [3cdc25e8ffe98c61b36af485573639dc833b75cb](https://dart.googlesource.com/sdk/+show/3cdc25e8ffe98c61b36af485573639dc833b75cb) > Version 3.13.0-149.0.dev > > Merge f710c4338a82b73e780519893cba959b38db1778 into dev
13 tasks
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
…include new Dart snapshots (flutter#186754) A recent Dart roll (flutter#186690) changed the format of Dart AOT snapshots so that they are now recognized as binaries by run_verify_binaries_codesigned_tests. The list of expected binaries needs to be updated accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent Dart roll (#186690) changed the format of Dart AOT snapshots so that they are now recognized as binaries by run_verify_binaries_codesigned_tests.
The list of expected binaries needs to be updated accordingly.