Remove Material import from selectable region context menu tests#186672
Remove Material import from selectable region context menu tests#186672MarlonJD wants to merge 7 commits into
Conversation
github-actions
Bot
added
the
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the selectable_region_context_menu_test.dart file to remove dependencies on the Material library. It replaces MaterialApp with TestWidgetsApp, updates imports to use package:flutter/widgets.dart, and switches from materialTextSelectionControls to emptyTextSelectionControls. I have no feedback to provide as there were no review comments.
|
Local verification passed for this PR: |
victorsanni
left a comment
victorsanni
left a comment
There was a problem hiding this comment.
Can we remove this file from dev/bots/check_tests_cross_imports.dart?
victorsanni
added
CICD
|
Windows tool_integration_tests_8_10 looks unrelated to this intentionally scoped selectable-region cleanup (Build 8681247460964752065). I tried to rerun the check from GitHub, but the check rerun API is not available from my side. Could a Flutter team member rerun that check? I am treating it as infra unless it reproduces. |
|
Closing this in favor of #186611, which already owns the selectable_region_context_menu_test.dart cleanup. Sorry for the duplicate queue entry. |
github-project-automation
Bot
moved this from In Progress
to Done
in Test cross-imports Review Queue
3 participants
Part of #177412
Refs #177028
This removes the Material dependency from widgets/selectable_region_context_menu_test.dart by replacing MaterialApp with TestWidgetsApp and using widgets text selection controls in the right-click selection test.
Validation: