Use local semantics tester in Material selection tests#186670
Closed
MarlonJD wants to merge 8 commits into
Closed
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the import path for semantics_tester.dart from '../widgets/semantics_tester.dart' to 'semantics_tester.dart' across several Material test files, including checkbox_test.dart, radio_test.dart, range_slider_test.dart, slider_test.dart, and toggle_buttons_test.dart. I have no feedback to provide.
Contributor
Author
|
Local verification passed for this PR: |
victorsanni
previously approved these changes
May 18, 2026
…n-semantics-imports
…ts' into material-selection-semantics-imports
victorsanni
added
CICD
Contributor
Author
|
Formatter-only follow-up; no logic changes. |
Contributor
Author
|
@victorsanni The latest push was formatter-only and has no logic changes. Could you please re-approve when you have a moment? |
Contributor
Author
|
Gentle follow-up: the latest push was formatter-only, and there are no failed checks besides the global tree-status. Could you please re-approve and add CICD when you get a chance? |
victorsanni
approved these changes
May 29, 2026
Piinks
added
Decoupling: Port to flutter/packages
Contributor
|
This PR is ready to be ported over to flutter/packages in the new material_ui package! This PR is also necessary for pre-release of the material_ui package. If you are unable to work on this right now, no worries! We’ll go ahead and port it over to get it landed. Your contribution is greatly appreciated. 💙 |
Contributor
Author
|
Ported this change to flutter/packages in flutter/packages#11983, following the porting instructions in #188444. Closing this flutter/flutter PR now that the material_ui port PR is ready for review. |
github-project-automation
Bot
moved this from In Progress
to Done
in Test cross-imports Review Queue
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 29, 2026
…r in Material selection tests" (#11983) This PR ports flutter/flutter#186670 by @MarlonJD from flutter/flutter to flutter/packages. It moves the affected Material selection tests from material_ui's `temporarily_disabled_tests` directory into the main `test` directory now that their gross `../widgets/semantics_tester.dart` import has been fixed to use material_ui's local `semantics_tester.dart`. This follows the porting instructions in flutter/flutter#188444: - merge commits from the original PR are not included - the affected `temporarily_disabled_tests` files are moved into the main test directory after fixing the gross import Validation: - `dart format --set-exit-if-changed packages/material_ui/test/checkbox_test.dart packages/material_ui/test/radio_test.dart packages/material_ui/test/range_slider_test.dart packages/material_ui/test/slider_test.dart packages/material_ui/test/toggle_buttons_test.dart` - `git diff --check` - `flutter test test/checkbox_test.dart test/radio_test.dart test/range_slider_test.dart test/slider_test.dart test/toggle_buttons_test.dart` The targeted test command passed with 304 tests.
pull Bot
pushed a commit
to safarmer/flutter
that referenced
this pull request
Jun 30, 2026
…er#188792) flutter/packages@656ccaa...274ed3e 2026-06-30 [email protected] [video_player_android] Add video track selection support (flutter/packages#11475) 2026-06-30 [email protected] Manual roll Flutter from b081f33 to 0c80830 (1 revision) (flutter/packages#12058) 2026-06-30 [email protected] [material_ui] Remove `widgets` import from `material_test.dart` (flutter/packages#12056) 2026-06-29 [email protected] [material_ui] Remove `widgets` imports from `card_test.dart`, `checkbox_list_tile_test.dart` (flutter/packages#12054) 2026-06-29 [email protected] [material_ui] Remove `widgets/clipboard_utils.dart`, `widgets/text_selection_toolbar_utils.dart` imports from `adaptive_text_selection_toolbar_test.dart` (flutter/packages#12053) 2026-06-29 [email protected] Manual roll Flutter from 11e339e to b081f33 (1 revision) (flutter/packages#12050) 2026-06-29 [email protected] [material_ui] Remove `widgets/clipboard_utils.dart` imports from `date_picker_test.dart`, `input_date_picker_form_field_test.dart`, `search_test.dart`, `selectable_text_test.dart`, `text_form_field_test.dart`, `text_selection_test.dart` (flutter/packages#12030) 2026-06-29 [email protected] Manual roll Flutter from 87224e0 to 11e339e (4 revisions) (flutter/packages#12041) 2026-06-29 [email protected] [material_ui] Enable `text_field_test` (flutter/packages#12022) 2026-06-29 [email protected] [material_ui] Port PR (flutter#184807) from flutter/flutter to material_ui (flutter/packages#11972) 2026-06-29 [email protected] [cupertino_ui] Migrate `button_test.dart` to `SemanticsHandle` (flutter/packages#11992) 2026-06-29 [email protected] [cupertino_ui] Migrate `radio_test.dart` to `SemanticsHandle` (flutter/packages#11981) 2026-06-29 [email protected] [cupertino_ui] Migrate `picker_test.dart` to `SemanticsHandle` (flutter/packages#12008) 2026-06-29 [email protected] [cupertino_ui] Create util files. Remove widgets import in `adaptive_text_selection_toolbar_test.dart` and `text_selection_test.dart` (flutter/packages#12023) 2026-06-29 [email protected] [material_ui] Enable `floating_action_button_test` (flutter/packages#12014) 2026-06-29 [email protected] [material_ui] Enable `dropdown_test` (flutter/packages#12011) 2026-06-29 [email protected] [material_ui] Enable `chip_test` (flutter/packages#12009) 2026-06-29 [email protected] [material_ui] Remove widgets import in `data_table_test.dart`, `switch_test.dart` and `tooltip_theme_test.dart` (flutter/packages#12031) 2026-06-29 [email protected] [material_ui] Port flutter/flutter flutter#186670 "Use local semantics tester in Material selection tests" (flutter/packages#11983) 2026-06-29 [email protected] [material_ui] Enable `switch_list_tile_test` (flutter/packages#12020) 2026-06-29 [email protected] [material_ui] Enable `popup_menu_test` (flutter/packages#12018) 2026-06-29 [email protected] [material_ui] Enable `date_range_picker_test` (flutter/packages#12010) 2026-06-29 [email protected] [google_sign_in] Simplify Android user ID extraction (flutter/packages#12025) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #182636.
Switches the Material selection control test files that already have a local
semantics_tester.dartcopy from importing../widgets/semantics_tester.dartto importing the local Material test utility. This removes another small set of cross-library test utility imports ahead of the Material/Cupertino package split.Validation: