Remove Material import from scrollable semantics test#186623
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors scrollable_semantics_test.dart by replacing SliverAppBar with a custom SliverPersistentHeader and removing Localizations widgets from the test setup. Review feedback suggests adjusting the minExtent of the new header delegate to maintain consistency with the original test behavior and adding documentation comments to the _PinnedHeaderDelegate class as per the style guide.
|
Addressed the review feedback on this PR and re-verified locally: |
|
looks like there is another pr opened already #186611. I am going to close this one. Thank you for contribution |
3 participants
Part of #177412
Summary
Removes the unnecessary
package:flutter/material.dartimport fromscrollable_semantics_test.dart.The two pinned app bar
showOnScreenscenarios now use a genericSliverPersistentHeaderinstead ofSliverAppBar/FlexibleSpaceBar, so thetest can depend on
package:flutter/widgets.dartrather than Material.Tests
./bin/flutter test packages/flutter/test/widgets/scrollable_semantics_test.dart./bin/flutter analyze --no-pub packages/flutter/test/widgets/scrollable_semantics_test.dart