Remove routes_transition_test from widgets by Wreos · Pull Request #186620 · flutter/flutter

Wreos · 2026-05-16T11:03:01Z

Removes routes_transition_test.dart from flutter/flutter. The test will be added to material_ui in flutter/packages in this pr

Part of #177414.
Related to #188444.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

google-cla · 2026-05-16T11:03:17Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gemini-code-assist

Code Review

This pull request modifies the test file packages/flutter/test/material/routes_transition_test.dart. No review comments were provided, and I have no feedback to provide.

Piinks · 2026-06-24T21:49:38Z

I've marked this PR as not ready to port to flutter/packages yet.
We'll provide instructions to move this change over to material_ui/cupertino_ui once ready to receive PRs. Thank you!

The changes not in the material or cupertino libraries will remain here, so this will in the future require splitting into 2 PRs. One that removes the tests from widgets, and another that add the tests in material_ui in flutter/packages.

Wreos · 2026-06-27T10:58:08Z

I've marked this PR as not ready to port to flutter/packages yet. We'll provide instructions to move this change over to material_ui/cupertino_ui once ready to receive PRs. Thank you!

The changes not in the material or cupertino libraries will remain here, so this will in the future require splitting into 2 PRs. One that removes the tests from widgets, and another that add the tests in material_ui in flutter/packages.

Hello, @Piinks :) Big thanks for the feedback.

elliette

Thank you, LGTM! As mentioned above, this PR will need to be ported over to the new packages repo. We will provide more details when that repo is ready to accept contributions.

QuncCccccc

LGTM! Thanks for your contribution:)

github-actions · 2026-08-26T09:28:05Z

This pull request contains changes to Material or Cupertino, which are currently frozen in this repository.

Changes should be made in material_ui and/or cupertino_ui in the flutter/packages repository.

Please refer to #188444 for instructions.

Ports routes_transition_test.dart from flutter/flutter to material_ui. The original test is removed separately in flutter/flutter#186620 and added here to preserve its Material navigation transition coverage. Part of [flutter/flutter#177414.](flutter/flutter#188444) Related to [flutter/flutter#188444.](flutter/flutter#186620) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

gemini-code-assist

Code Review

This pull request deletes a test file containing the 'navigating with transitions of different lengths' widget test and its helper class _TestTransitionRoute. I have no feedback to provide.

Wreos · 2026-11-03T20:42:10Z

Hello, @Piinks :)

This PR removes routes_transition_test.dart from flutter/flutter, since I’ve already migrated it to material_ui in [flutter/packages#12634], which has been merged.

I’ve updated this PR to the latest master and removed the stale cross-import exception. Could you take another look? Thanks! :)

elliette

LGTM, thanks for splitting up the PR! I think this PR will need to be rebased to get it to pass CI.

QuncCccccc

LGTM

The test now lives in material_ui (flutter/packages#12634). Remove its obsolete cross-import exception as well. Part of flutter#177414

auto-submit · 2026-11-12T01:29:24Z

auto label is removed for flutter/flutter/186620, Failed to enqueue flutter/flutter/186620 with HTTP 400: Pull request Required status check "Check Code Freeze" is expected..

auto-submit · 2026-11-13T20:25:08Z

auto label is removed for flutter/flutter/186620, Failed to enqueue flutter/flutter/186620 with HTTP 400: Pull request Required status check "Check Code Freeze" is expected..

Wreos mentioned this pull request May 16, 2026

Move routes_transition_test to material #186619

Closed

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages f: routes Navigator, Router, and related APIs. labels May 16, 2026

Wreos marked this pull request as ready for review May 16, 2026 11:06

gemini-code-assist Bot reviewed May 16, 2026

View reviewed changes

dkwingsmt added this to Test cross-imports Review Queue May 20, 2026

github-project-automation Bot moved this to Todo in Test cross-imports Review Queue May 20, 2026

Piinks added Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. Decoupling: Split PR The PR will need to be split to separate Material & Cupertino changes labels Jun 24, 2026

Piinks requested review from QuncCccccc and elliette July 15, 2026 21:13

elliette previously approved these changes Jul 17, 2026

View reviewed changes

QuncCccccc added the CICD Run CI/CD label Jul 17, 2026

QuncCccccc previously approved these changes Jul 17, 2026

View reviewed changes

QuncCccccc force-pushed the move-routes-transition-test branch from 89a7c2d to a8b56aa Compare July 17, 2026 22:05

flutter-dashboard Bot removed the CICD Run CI/CD label Jul 17, 2026

QuncCccccc added the CICD Run CI/CD label Jul 17, 2026

dkwingsmt marked this pull request as draft July 22, 2026 18:16

dkwingsmt added the waiting for code freeze This PR is waiting for a code freeze to resolve. label Jul 22, 2026

flutter-dashboard Bot removed the CICD Run CI/CD label Aug 26, 2026

Wreos dismissed stale reviews from elliette and QuncCccccc via 1886b4d August 26, 2026 09:33

github-actions Bot removed the p: material_ui material_ui package in flutter/packages label Aug 26, 2026

Wreos changed the title ~~Move routes_transition_test to material~~ Remove routes_transition_test from widgets Aug 26, 2026

Wreos mentioned this pull request Aug 26, 2026

[material_ui] Port routes_transition_test to material_ui flutter/packages#12634

Merged

11 tasks done

Wreos marked this pull request as ready for review November 3, 2026 20:37

gemini-code-assist Bot reviewed Nov 3, 2026

View reviewed changes

gmackall mentioned this pull request Nov 4, 2026

[Infra] Allow community members to rebase a PR without removing CICD #195944

Open

1 of 4 tasks

elliette added CICD Run CI/CD and removed CICD Run CI/CD labels Nov 6, 2026

elliette approved these changes Nov 6, 2026

View reviewed changes

Wreos force-pushed the move-routes-transition-test branch from e1dbf3f to d43bf0e Compare November 6, 2026 21:01

flutter-dashboard Bot removed the CICD Run CI/CD label Nov 6, 2026

QuncCccccc approved these changes Nov 12, 2026

View reviewed changes

QuncCccccc added the CICD Run CI/CD label Nov 12, 2026

Remove migrated routes transition test from widgets

c519676

The test now lives in material_ui (flutter/packages#12634). Remove its obsolete cross-import exception as well. Part of flutter#177414

QuncCccccc force-pushed the move-routes-transition-test branch from d43bf0e to c519676 Compare November 12, 2026 00:55

flutter-dashboard Bot removed the CICD Run CI/CD label Nov 12, 2026

QuncCccccc added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Nov 12, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2026

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2026

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2026

auto-submit Bot added this pull request to the merge queue Nov 13, 2026

Merged via the queue into flutter:master with commit f2263b9 Nov 13, 2026
35 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2026

github-project-automation Bot moved this from Todo to Done in Test cross-imports Review Queue Nov 13, 2026

Conversation

Wreos commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

google-cla Bot commented May 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Piinks commented Jun 24, 2026

Uh oh!

Wreos commented Jun 27, 2026

Uh oh!

elliette left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 26, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Wreos commented Nov 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elliette left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Nov 12, 2026

Uh oh!

auto-submit Bot commented Nov 13, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Wreos commented May 16, 2026 •

edited

Loading

Wreos commented Nov 3, 2026 •

edited

Loading