Fix broken link in impeller golden_tests readme#186470
Merged
Merged
Conversation
github-actions
Bot
added
engine
andywolff
marked this pull request as ready for review
May 13, 2026 19:31
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects the markdown link syntax in the Impeller golden tests README by removing unnecessary quotes from the URL. A review comment identifies a typo in the documentation text where "vial" should be "via" to improve readability.
gaaclarke
approved these changes
May 14, 2026
Contributor
Author
|
@chingjun This PR keeps getting stuck on the check |
Contributor
I think it's because you need to add a But honestly, since this is just a doc change, feel free to override that internally if this is blocking. We know this is not going to break any tests. |
Github does not handle the link correctly when it is wrapped in quotes, so remove the quotes
Contributor
Author
|
Oh okay, thanks. I'll do that from now on. |
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 19, 2026
flutter/flutter@3598686...259aeae 2026-05-19 [email protected] Roll Skia from 967ddb1aa561 to f1b406860c5e (2 revisions) (flutter/flutter#186731) 2026-05-19 [email protected] Roll Fuchsia Linux SDK from 5Ki-dBY4SpWdQMF_3... to -F9Ci3Opxt06MixDl... (flutter/flutter#186727) 2026-05-19 [email protected] Remove unused field in `ResourceExtractor` (flutter/flutter#186629) 2026-05-19 [email protected] Update Fuchsia tests to use realm_builder_server as a subpackage (flutter/flutter#186409) 2026-05-19 [email protected] Roll Skia from cebf49d034b8 to 967ddb1aa561 (4 revisions) (flutter/flutter#186720) 2026-05-19 [email protected] Roll pub packages (flutter/flutter#186721) 2026-05-19 [email protected] [macOS][gn] support both x64/arm64 macOS host clang toolchains for ASAN (flutter/flutter#186669) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in generate_coverage.py on arm64 Macs (flutter/flutter#186662) 2026-05-19 [email protected] Fix broken link in impeller golden_tests readme (flutter/flutter#186470) 2026-05-19 [email protected] Roll Skia from 27f7bba22600 to cebf49d034b8 (37 revisions) (flutter/flutter#186699) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in verify_exported.dart on arm64 Macs (flutter/flutter#186664) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in sanitizer_suppressions.sh on arm64 Macs (flutter/flutter#186663) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in copy_info_plist.py on arm64 Macs (flutter/flutter#186661) 2026-05-19 [email protected] Complete completer only once in hot restart tests (flutter/flutter#186702) 2026-05-18 [email protected] Testing autosubmit bot -- updating testowners (flutter/flutter#185226) 2026-05-18 [email protected] [ios] Correct handling for CADisplayLink paused-to-unpaused transitions (flutter/flutter#186457) 2026-05-18 [email protected] [Android][macOS][gn] support both x64/arm64 macOS host clang toolchains (flutter/flutter#186660) 2026-05-18 [email protected] Roll Packages from 32c84d6 to b9bdd37 (2 revisions) (flutter/flutter#186683) 2026-05-18 [email protected] [AGP 9] Upgrade Flutter Test Apps to AGP 9 (flutter/flutter#186200) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11737) flutter/flutter@3598686...259aeae 2026-05-19 [email protected] Roll Skia from 967ddb1aa561 to f1b406860c5e (2 revisions) (flutter/flutter#186731) 2026-05-19 [email protected] Roll Fuchsia Linux SDK from 5Ki-dBY4SpWdQMF_3... to -F9Ci3Opxt06MixDl... (flutter/flutter#186727) 2026-05-19 [email protected] Remove unused field in `ResourceExtractor` (flutter/flutter#186629) 2026-05-19 [email protected] Update Fuchsia tests to use realm_builder_server as a subpackage (flutter/flutter#186409) 2026-05-19 [email protected] Roll Skia from cebf49d034b8 to 967ddb1aa561 (4 revisions) (flutter/flutter#186720) 2026-05-19 [email protected] Roll pub packages (flutter/flutter#186721) 2026-05-19 [email protected] [macOS][gn] support both x64/arm64 macOS host clang toolchains for ASAN (flutter/flutter#186669) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in generate_coverage.py on arm64 Macs (flutter/flutter#186662) 2026-05-19 [email protected] Fix broken link in impeller golden_tests readme (flutter/flutter#186470) 2026-05-19 [email protected] Roll Skia from 27f7bba22600 to cebf49d034b8 (37 revisions) (flutter/flutter#186699) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in verify_exported.dart on arm64 Macs (flutter/flutter#186664) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in sanitizer_suppressions.sh on arm64 Macs (flutter/flutter#186663) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in copy_info_plist.py on arm64 Macs (flutter/flutter#186661) 2026-05-19 [email protected] Complete completer only once in hot restart tests (flutter/flutter#186702) 2026-05-18 [email protected] Testing autosubmit bot -- updating testowners (flutter/flutter#185226) 2026-05-18 [email protected] [ios] Correct handling for CADisplayLink paused-to-unpaused transitions (flutter/flutter#186457) 2026-05-18 [email protected] [Android][macOS][gn] support both x64/arm64 macOS host clang toolchains (flutter/flutter#186660) 2026-05-18 [email protected] Roll Packages from 32c84d6 to b9bdd37 (2 revisions) (flutter/flutter#186683) 2026-05-18 [email protected] [AGP 9] Upgrade Flutter Test Apps to AGP 9 (flutter/flutter#186200) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github does not handle the link correctly when it is wrapped in quotes, so remove the quotes.
Before, clicking on this resolves incorrectly to engine/src/flutter/impeller/golden_tests/tools/golden_tests_harvester"
After, resolves correctly to engine/src/flutter/tools/golden_tests_harvester
Pre-launch Checklist
///).