Dispose TextEditingController in IndexedStack example#186375
Merged
auto-submit[bot] merged 1 commit intoMay 16, 2026
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a dispose method to the _IndexedStackExampleState class in examples/api/lib/widgets/basic/indexed_stack.0.dart. This implementation ensures that the TextEditingController is properly disposed of when the widget is removed from the tree, preventing potential memory leaks. I have no feedback to provide.
The _IndexedStackExampleState class created a TextEditingController but never disposed it, causing a resource leak. Added dispose() to properly clean up the controller when the widget is removed from the tree. Fixes flutter#186324
BilalRehman08
force-pushed
the
fix/indexed-stack-dispose-controller
branch
from
May 11, 2026 22:07
90202a9 to
34e70f7
Compare
Renzo-Olivares
approved these changes
May 12, 2026
victorsanni
approved these changes
May 12, 2026
AbdeMohlbi
added
the
autosubmit
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 15, 2026
flutter-dashboard
Bot
removed
the
autosubmit
Renzo-Olivares
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced May 16, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 18, 2026
flutter/flutter@1ceffd1...3598686 2026-05-17 [email protected] Roll Fuchsia Linux SDK from G9xv1qcMhvXOy-9pk... to 5Ki-dBY4SpWdQMF_3... (flutter/flutter#186636) 2026-05-17 [email protected] [Impeller] Canonicalize uniform block instance names for the GL backends (flutter/flutter#186394) 2026-05-16 [email protected] [widgets] Use super parameters in missed spots (flutter/flutter#186198) 2026-05-16 [email protected] refactor: Remove material imports from Widget tests (flutter/flutter#185078) 2026-05-16 [email protected] Roll pub packages (flutter/flutter#186602) 2026-05-16 [email protected] [gn] Fix typo in comment (flutter/flutter#186549) 2026-05-16 [email protected] Roll Fuchsia Linux SDK from y6uQHA5xUN83IF395... to G9xv1qcMhvXOy-9pk... (flutter/flutter#186599) 2026-05-15 [email protected] Removes bringup from passing macos/sdf tests (flutter/flutter#186527) 2026-05-15 [email protected] [web] Fix several WebParagraph bugs (flutter/flutter#186403) 2026-05-15 [email protected] Display the team ID and name when selecting a signing certificate (flutter/flutter#184665) 2026-05-15 [email protected] [iOS] Improve documentation on FlutterVSyncClient and FlutterDisplayLink (flutter/flutter#186456) 2026-05-15 [email protected] Increase the run time of text field integration tests to 10 seconds (flutter/flutter#186475) 2026-05-15 [email protected] Fix web-server hot restart/reload not applying changes for entrypoints outside lib (flutter/flutter#183838) 2026-05-15 [email protected] Update dart_skills_lint dependency to e449787 and optimize skills validation test (flutter/flutter#186528) 2026-05-15 [email protected] Roll Packages from 2ec2236 to 32c84d6 (3 revisions) (flutter/flutter#186583) 2026-05-15 [email protected] Dispose TextEditingController in IndexedStack example (flutter/flutter#186375) 2026-05-15 [email protected] refactor: update filename for sliver semantic widget (flutter/flutter#185917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11724) flutter/flutter@1ceffd1...3598686 2026-05-17 [email protected] Roll Fuchsia Linux SDK from G9xv1qcMhvXOy-9pk... to 5Ki-dBY4SpWdQMF_3... (flutter/flutter#186636) 2026-05-17 [email protected] [Impeller] Canonicalize uniform block instance names for the GL backends (flutter/flutter#186394) 2026-05-16 [email protected] [widgets] Use super parameters in missed spots (flutter/flutter#186198) 2026-05-16 [email protected] refactor: Remove material imports from Widget tests (flutter/flutter#185078) 2026-05-16 [email protected] Roll pub packages (flutter/flutter#186602) 2026-05-16 [email protected] [gn] Fix typo in comment (flutter/flutter#186549) 2026-05-16 [email protected] Roll Fuchsia Linux SDK from y6uQHA5xUN83IF395... to G9xv1qcMhvXOy-9pk... (flutter/flutter#186599) 2026-05-15 [email protected] Removes bringup from passing macos/sdf tests (flutter/flutter#186527) 2026-05-15 [email protected] [web] Fix several WebParagraph bugs (flutter/flutter#186403) 2026-05-15 [email protected] Display the team ID and name when selecting a signing certificate (flutter/flutter#184665) 2026-05-15 [email protected] [iOS] Improve documentation on FlutterVSyncClient and FlutterDisplayLink (flutter/flutter#186456) 2026-05-15 [email protected] Increase the run time of text field integration tests to 10 seconds (flutter/flutter#186475) 2026-05-15 [email protected] Fix web-server hot restart/reload not applying changes for entrypoints outside lib (flutter/flutter#183838) 2026-05-15 [email protected] Update dart_skills_lint dependency to e449787 and optimize skills validation test (flutter/flutter#186528) 2026-05-15 [email protected] Roll Packages from 2ec2236 to 32c84d6 (3 revisions) (flutter/flutter#186583) 2026-05-15 [email protected] Dispose TextEditingController in IndexedStack example (flutter/flutter#186375) 2026-05-15 [email protected] refactor: update filename for sliver semantic widget (flutter/flutter#185917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
_IndexedStackExampleStateclass in theIndexedStackAPI example creates aTextEditingControllerbut never disposes it, causing a resource leak.Added a
dispose()override that callsfieldText.dispose()beforesuper.dispose().Fixes #186324
Tests
Existing tests in
examples/api/test/widgets/basic/indexed_stack.0_test.dartcover the example. No new tests needed for a dispose fix.