Skip to content

[ci] update no-response workflow to also look for old label name in e…#186373

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
chunhtai:add-old-name
May 12, 2026
Merged

[ci] update no-response workflow to also look for old label name in e…#186373
auto-submit[bot] merged 3 commits into
flutter:masterfrom
chunhtai:add-old-name

Conversation

@chunhtai

@chunhtai chunhtai commented May 11, 2026

Copy link
Copy Markdown
Contributor

…vents

fixes #186223

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 11, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label May 11, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 11, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/scripts/no-response.js script to support a transition between label names by allowing the script to recognize both the new 'waiting for response' label and the legacy 'waiting for customer response' label. Feedback was provided to ensure the label removal logic is also updated to handle the old label name to avoid potential API errors, and a suggestion was made to use the spread operator when reversing the events array to prevent side effects from array mutation.

Comment thread .github/scripts/no-response.js
@chunhtai
chunhtai requested a review from jtmcdole May 11, 2026 21:10
@chunhtai chunhtai added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels May 11, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue May 11, 2026
Merged via the queue into flutter:master with commit a77a280 May 12, 2026
19 of 20 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2026
This was referenced May 12, 2026
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 14, 2026
@engine-flutter-autoroll
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) (#11700)
0ffbde8 
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions)

flutter/flutter@707dbc0...23f6f58

2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158)
2026-05-12 [email protected] Roll Packages from 19ec8b8 to 93cbed6 (3 revisions) (flutter/flutter#186401)
2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265)
2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321)
2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378)
2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390)
2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396)
2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979)
2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391)
2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310)
2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262)
2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384)
2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302)
2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298)
2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373)
2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341)
2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320)
2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368)
2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984)
2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089)
2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273)
2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907)
2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349)
2026-05-11 [email protected] Roll Packages from 92552b1 to 19ec8b8 (4 revisions) (flutter/flutter#186350)
2026-05-11 [email protected] Check for absolute paths in skills.  (flutter/flutter#185632)
2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347)
2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335)
2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328)
2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315)
2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886)
2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259)
2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990)
2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289)
2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283)
2026-05-09 [email protected] Improve non rect platform view rendering  (flutter/flutter#182662)
2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278)
2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214)
2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266)
2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264)
2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203)
2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263)
2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210)
2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257)
2026-05-08 [email protected] Roll Packages from 0411f1d to 92552b1 (1 revision) (flutter/flutter#186256)
2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107)
2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242)
...
stuartmorgan-g pushed a commit to flutter/core-packages that referenced this pull request Jun 9, 2026
@engine-flutter-autoroll
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) (#11700)
7abdf27 
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions)

flutter/flutter@707dbc0...23f6f58

2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158)
2026-05-12 [email protected] Roll Packages from 19ec8b861676 to 93cbed65f336 (3 revisions) (flutter/flutter#186401)
2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265)
2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321)
2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378)
2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390)
2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396)
2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979)
2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391)
2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310)
2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262)
2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384)
2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302)
2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298)
2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373)
2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341)
2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320)
2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368)
2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984)
2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089)
2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273)
2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907)
2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349)
2026-05-11 [email protected] Roll Packages from 92552b16bcc1 to 19ec8b861676 (4 revisions) (flutter/flutter#186350)
2026-05-11 [email protected] Check for absolute paths in skills.  (flutter/flutter#185632)
2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347)
2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335)
2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328)
2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315)
2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886)
2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259)
2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990)
2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289)
2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283)
2026-05-09 [email protected] Improve non rect platform view rendering  (flutter/flutter#182662)
2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278)
2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214)
2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266)
2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264)
2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203)
2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263)
2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210)
2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257)
2026-05-08 [email protected] Roll Packages from cfdd1d3 to 92552b16bcc1 (1 revision) (flutter/flutter#186256)
2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107)
2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242)
...
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) (flutt…
cc38704 
…er#11700)

Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions)

flutter/flutter@707dbc0...23f6f58

2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158)
2026-05-12 [email protected] Roll Packages from 19ec8b8 to 93cbed6 (3 revisions) (flutter/flutter#186401)
2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265)
2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321)
2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378)
2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390)
2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396)
2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979)
2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391)
2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310)
2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262)
2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384)
2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302)
2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298)
2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373)
2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341)
2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320)
2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368)
2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984)
2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089)
2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273)
2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907)
2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349)
2026-05-11 [email protected] Roll Packages from 92552b1 to 19ec8b8 (4 revisions) (flutter/flutter#186350)
2026-05-11 [email protected] Check for absolute paths in skills.  (flutter/flutter#185632)
2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347)
2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335)
2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328)
2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315)
2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886)
2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259)
2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990)
2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289)
2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283)
2026-05-09 [email protected] Improve non rect platform view rendering  (flutter/flutter#182662)
2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278)
2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214)
2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266)
2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264)
2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203)
2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263)
2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210)
2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257)
2026-05-08 [email protected] Roll Packages from 0411f1d to 92552b1 (1 revision) (flutter/flutter#186256)
2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107)
2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes
@jtmcdole jtmcdole Awaiting requested review from jtmcdole
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Github label "waiting for response" isn't working

2 participants

@chunhtai @Piinks