Skip to content

docs: fix typos in flutter_tools comments#186321

Merged
robert-ancell merged 1 commit into
flutter:masterfrom
Nicoreia:docs/fix-typos-flutter-tools-comments
May 12, 2026
Merged

docs: fix typos in flutter_tools comments#186321
robert-ancell merged 1 commit into
flutter:masterfrom
Nicoreia:docs/fix-typos-flutter-tools-comments

Conversation

@Nicoreia

Copy link
Copy Markdown
Contributor

Summary

Fixes a handful of single-word typos found in /// dartdoc and // inline comments inside flutter_tools. Comment-only — no public API, no behavior, no test logic touched.

Changes

  • packages/flutter_tools/lib/src/android/gradle_utils.dart
    • space sytax -> space syntax
    • This vesion is NOT -> This version is NOT
    • dynamiclly added -> dynamically added
    • gradle can run successfuly -> gradle can run successfully
    • Documenation is non continuous -> Documentation is non continuous (2 occurrences)
    • KGP version handling is prefered -> KGP version handling is preferred (2 occurrences)
  • packages/flutter_tools/lib/src/features.dart
    • dartdoc: Wether riscv64 support is enabled -> Whether riscv64 support is enabled
    • inline: This member is overriden in google3 -> This member is overridden in google3
  • packages/flutter_tools/lib/src/linux/linux_doctor.dart
    • dartdoc: Requires tha [binary] -> Requires that [binary]

Tests

No tests added or modified. The change does not touch any executable line. Verified locally by re-grepping the modified files for residual instances of each typo — none remain.

Notes for maintainers

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene page and followed its process for submitting this PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.

(sytax, vesion, dynamiclly, successfuly, Documenation, prefered, Wether,
overriden, tha). Comment-only; no semantic or behavior changes.

Affected files:
- packages/flutter_tools/lib/src/android/gradle_utils.dart (8 fixes)
- packages/flutter_tools/lib/src/features.dart (2 fixes)
- packages/flutter_tools/lib/src/linux/linux_doctor.dart (1 fix)
@Nicoreia
Nicoreia requested review from a team as code owners May 10, 2026 18:37
@Nicoreia
Nicoreia requested review from jesswrd and removed request for a team May 10, 2026 18:37
@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop team-android Owned by Android platform team team-linux Owned by the Linux platform team labels May 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes several typos in the documentation comments within the Flutter tools package. The review feedback identifies further opportunities to improve comment readability and grammar, such as capitalizing proper nouns like 'Flutter' and 'KGP', hyphenating compound adjectives, and using semicolons to correct comma splices.

Comment on lines +424 to +425
// Instead the kgpVersion task is a custom flutter task dynamically added that can
// print the kgp version if gradle can run successfully.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding a comma after the introductory word "Instead" improves readability. Additionally, "Flutter" and "KGP" should be capitalized as they are proper nouns, consistent with their usage elsewhere in the codebase.

Suggested change
// Instead the kgpVersion task is a custom flutter task dynamically added that can
// print the kgp version if gradle can run successfully.
// Instead, the kgpVersion task is a custom Flutter task dynamically added that can
// print the KGP version if gradle can run successfully.
References
  1. Optimize for readability: Code is read more often than it is written. (link)


// https://kotlinlang.org/docs/gradle-configure-project.html#apply-the-plugin
// Documenation is non continuous, past versions are known to the
// Documentation is non continuous, past versions are known to the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The compound adjective "non-continuous" should be hyphenated. Also, replacing the comma with a semicolon fixes a comma splice, improving grammatical correctness and readability.

Suggested change
// Documentation is non continuous, past versions are known to the
// Documentation is non-continuous; past versions are known to the
References
  1. Optimize for readability: Code is read more often than it is written. (link)


// https://kotlinlang.org/docs/gradle-configure-project.html#apply-the-plugin
// Documenation is non continuous, past versions are known to the
// Documentation is non continuous, past versions are known to the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The compound adjective "non-continuous" should be hyphenated. Also, replacing the comma with a semicolon fixes a comma splice, improving grammatical correctness and readability.

Suggested change
// Documentation is non continuous, past versions are known to the
// Documentation is non-continuous; past versions are known to the
References
  1. Optimize for readability: Code is read more often than it is written. (link)

@robert-ancell robert-ancell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robert-ancell
robert-ancell enabled auto-merge May 10, 2026 19:21
@robert-ancell

Copy link
Copy Markdown
Contributor

The Gemini suggestions do also seem good, but they can be in a follow up PR if someone is interested in making it.

@victorsanni victorsanni added the CICD Run CI/CD label May 11, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 14, 2026
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions)

flutter/flutter@707dbc0...23f6f58

2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158)
2026-05-12 [email protected] Roll Packages from 19ec8b8 to 93cbed6 (3 revisions) (flutter/flutter#186401)
2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265)
2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321)
2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378)
2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390)
2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396)
2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979)
2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391)
2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310)
2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262)
2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384)
2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302)
2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298)
2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373)
2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341)
2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320)
2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368)
2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984)
2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089)
2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273)
2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907)
2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349)
2026-05-11 [email protected] Roll Packages from 92552b1 to 19ec8b8 (4 revisions) (flutter/flutter#186350)
2026-05-11 [email protected] Check for absolute paths in skills.  (flutter/flutter#185632)
2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347)
2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335)
2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328)
2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315)
2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886)
2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259)
2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990)
2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289)
2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283)
2026-05-09 [email protected] Improve non rect platform view rendering  (flutter/flutter#182662)
2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278)
2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214)
2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266)
2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264)
2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203)
2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263)
2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210)
2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257)
2026-05-08 [email protected] Roll Packages from 0411f1d to 92552b1 (1 revision) (flutter/flutter#186256)
2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107)
2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242)
...
stuartmorgan-g pushed a commit to flutter/core-packages that referenced this pull request Jun 9, 2026
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions)

flutter/flutter@707dbc0...23f6f58

2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158)
2026-05-12 [email protected] Roll Packages from 19ec8b861676 to 93cbed65f336 (3 revisions) (flutter/flutter#186401)
2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265)
2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321)
2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378)
2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390)
2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396)
2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979)
2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391)
2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310)
2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262)
2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384)
2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302)
2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298)
2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373)
2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341)
2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320)
2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368)
2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984)
2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089)
2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273)
2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907)
2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349)
2026-05-11 [email protected] Roll Packages from 92552b16bcc1 to 19ec8b861676 (4 revisions) (flutter/flutter#186350)
2026-05-11 [email protected] Check for absolute paths in skills.  (flutter/flutter#185632)
2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347)
2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335)
2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328)
2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315)
2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886)
2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259)
2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990)
2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289)
2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283)
2026-05-09 [email protected] Improve non rect platform view rendering  (flutter/flutter#182662)
2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278)
2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214)
2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266)
2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264)
2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203)
2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263)
2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210)
2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257)
2026-05-08 [email protected] Roll Packages from cfdd1d3 to 92552b16bcc1 (1 revision) (flutter/flutter#186256)
2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107)
2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242)
...
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…er#11700)

Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions)

flutter/flutter@707dbc0...23f6f58

2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158)
2026-05-12 [email protected] Roll Packages from 19ec8b8 to 93cbed6 (3 revisions) (flutter/flutter#186401)
2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265)
2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321)
2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378)
2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390)
2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396)
2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979)
2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391)
2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310)
2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262)
2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384)
2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302)
2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298)
2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373)
2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341)
2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320)
2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368)
2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984)
2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089)
2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273)
2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907)
2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349)
2026-05-11 [email protected] Roll Packages from 92552b1 to 19ec8b8 (4 revisions) (flutter/flutter#186350)
2026-05-11 [email protected] Check for absolute paths in skills.  (flutter/flutter#185632)
2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347)
2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335)
2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328)
2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315)
2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886)
2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259)
2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990)
2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289)
2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283)
2026-05-09 [email protected] Improve non rect platform view rendering  (flutter/flutter#182662)
2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278)
2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214)
2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266)
2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264)
2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203)
2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263)
2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210)
2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257)
2026-05-08 [email protected] Roll Packages from 0411f1d to 92552b1 (1 revision) (flutter/flutter#186256)
2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107)
2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop CICD Run CI/CD platform-linux Building on or for Linux specifically team-android Owned by Android platform team team-linux Owned by the Linux platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants