Time picker error in locales that do not use Latin digits by lamnhan066 · Pull Request #186311 · flutter/flutter

lamnhan066 · 2026-05-10T10:45:53Z

The time picker currently uses int.parse and int.tryParse to parse the entered number. However, in some locales, numbers are not represented using Latin digits, which causes the parsing to fail. In this implementation, I use MaterialLocalizations to parse the number directly, ensuring that it works correctly for all locales.

Fixes #85527

A test has been added to ensure that the new implementation works as expected and does not cause any breaking changes.

Pre-launch Checklist

gemini-code-assist

Code Review

This pull request introduces localized number parsing for the time picker's text input fields. It adds logic to cache localized digit mappings, clear them on locale changes, and strip localized leading zeros. A new test suite verifies these changes across multiple locales. Feedback was provided to ensure the leading zero removal logic correctly handles multi-unit characters.

lamnhan066 · 2026-05-18T00:56:00Z

Hi @QuncCccccc

I understand that the Material and Cupertino libraries are currently code-frozen, but I would like to know what steps I should take next for this PR. Thank you.

QuncCccccc · 2026-05-18T17:08:18Z

Thanks a lot for the contribution! I'll take a look soon and once we get enough approvals for this PR, we'll mark this PR draft. When material_ui package starts to accept contribution, we can create a new PR to move the change over there:)!

QuncCccccc

Overall looks good to me! Just left a few comments. Thanks for the fix!

QuncCccccc · 2026-05-27T01:59:13Z

+  @override
+  void didChangeDependencies() {
+    super.didChangeDependencies();
+    final Locale locale = Localizations.localeOf(context);


The cache is built by MaterialLocalizations. Should we check MaterialLocalizations instead?

I prefer keeping Localizations.localeOf since MaterialLocalizations lacks an equivalent method. We should also avoid using MaterialLocalizations type for caching comparisons because its equality isn't as reliable as Locale's (which can handles deprecated locales).

I see! Thanks for the explanation! Overall it looks good! I'll take another look tomorrow!

QuncCccccc

LGTM! Thanks a lot for the fix and the test coverage. There seems some more discussion in the original issue about 24-hour input case. But I think that's a separate issue and the latin digits parsing issue described in the description has been fixed.

QuncCccccc · 2026-06-17T17:27:06Z

To fix linux analyze, we might need to run dart format to reformat time_picker.dart and time_picker_test.dart.

lamnhan066 · 2026-06-18T02:05:36Z

I see that the unformatted part isn’t related to the PR. Should I rebase and run dart format to fix it too?

elliette · 2026-06-18T16:55:45Z

I see that the unformatted part isn’t related to the PR. Should I rebase and run dart format to fix it too?

Yes, it's possible these files haven't been touched since the last formatter update. Rebasing and running dart format should fix it.

…e localization handling

…mproved localization handling

…ng for improved localization handling" This reverts commit 8eb04b2.

… numbers

…s multiple locales

…ge as 0 - 59

… localization coverage

elliette · 2026-06-24T18:30:09Z

Looks like Linux web_skwasm_tests_1 timed out, just triggered a re-run.

Piinks · 2026-06-24T18:56:45Z

I've marked this PR as not ready to port to flutter/packages yet.
We'll provide instructions to move this change over to material_ui once it is ready to receive PRs. Thank you!

QuncCccccc

re-LGTM!

dkwingsmt · 2026-09-24T17:36:27Z

If you would like to return to this, material_ui and cupertino_ui are now accepting contributions. :)
Guidance and instructions for easily porting over can be found in #188444. Thank you for the contribution and for waiting!

lamnhan066 · 2026-09-27T16:28:35Z

Closing in favor of flutter/packages#13035 - ported to material_ui in flutter/packages per #188444 (Material/Cupertino freeze).

…flutter#186311)

…tin digits (#13035) Port of flutter/flutter#186311, fixes flutter/flutter#85527 The time picker currently uses `int.parse` and `int.tryParse` to parse the entered number. However, in some locales, numbers are not represented using Latin digits, which causes the parsing to fail. In this implementation, I use `MaterialLocalizations` to parse the number directly, ensuring that it works correctly for all locales. A test has been added to ensure that the new implementation works as expected and does not cause any breaking changes. ## Pre-Review Checklist

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels May 10, 2026

lamnhan066 force-pushed the time-picker-error-in-some-locales branch 2 times, most recently from 9791330 to 742608f Compare May 10, 2026 13:29

lamnhan066 marked this pull request as ready for review May 10, 2026 13:31

gemini-code-assist Bot reviewed May 10, 2026

View reviewed changes

Comment thread packages/flutter/lib/src/material/time_picker.dart Resolved

lamnhan066 changed the title ~~Time picker error in some locales~~ Time picker error in locales that do not use Latin digits May 10, 2026

lamnhan066 force-pushed the time-picker-error-in-some-locales branch 2 times, most recently from e9ee0f9 to 4e88fb9 Compare May 13, 2026 02:59

dkwingsmt requested review from QuncCccccc and dkwingsmt and removed request for dkwingsmt May 13, 2026 18:15

QuncCccccc added the CICD Run CI/CD label May 14, 2026

QuncCccccc force-pushed the time-picker-error-in-some-locales branch from 4e88fb9 to 717b2aa Compare May 14, 2026 17:42

github-actions Bot removed the CICD Run CI/CD label May 14, 2026

QuncCccccc added the CICD Run CI/CD label May 14, 2026

lamnhan066 force-pushed the time-picker-error-in-some-locales branch from 717b2aa to 47c8ad3 Compare May 17, 2026 13:11

github-actions Bot removed the CICD Run CI/CD label May 17, 2026

QuncCccccc reviewed May 27, 2026

View reviewed changes

lamnhan066 force-pushed the time-picker-error-in-some-locales branch from 47c8ad3 to f716746 Compare May 27, 2026 02:50

dkwingsmt requested a review from QuncCccccc June 3, 2026 18:24

QuncCccccc previously approved these changes Jun 17, 2026

View reviewed changes

QuncCccccc added the CICD Run CI/CD label Jun 17, 2026

dkwingsmt requested a review from elliette June 17, 2026 18:22

elliette previously approved these changes Jun 18, 2026

View reviewed changes

lamnhan066 added 8 commits June 19, 2026 08:08

Refactor time picker to use private cachedNumbers variable and improv…

3e21a6c

…e localization handling

Refactor time picker to separate cached hour and minute parsing for i…

fd3ba4d

…mproved localization handling

Revert "Refactor time picker to separate cached hour and minute parsi…

ae3204a

…ng for improved localization handling" This reverts commit 8eb04b2.

Improve time picker localization by removing leading zeros from input…

3fc33de

… numbers

Enhance time picker tests to verify parsing of localized digits acros…

61f9884

…s multiple locales

Fix leading zero removal logic in time picker localization

db4d029

Clarify comment in _generateLocalizedNumbers to specify supported ran…

05b2545

…ge as 0 - 59

Add additional locales (fr, de, pt) to time picker tests for improved…

8727263

… localization coverage

lamnhan066 force-pushed the time-picker-error-in-some-locales branch from ebb31ee to 8727263 Compare June 19, 2026 01:08

github-actions Bot removed the CICD Run CI/CD label Jun 19, 2026

Run dart format on time_picker.dart and time_picker_test.dart.

0594e16

lamnhan066 dismissed stale reviews from elliette and QuncCccccc via 0594e16 June 19, 2026 01:18

lamnhan066 requested a review from elliette June 19, 2026 01:19

elliette added the CICD Run CI/CD label Jun 23, 2026

Piinks added the Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. label Jun 24, 2026

elliette approved these changes Jul 1, 2026

View reviewed changes

QuncCccccc approved these changes Jul 8, 2026

View reviewed changes

dkwingsmt marked this pull request as draft July 22, 2026 18:11

dkwingsmt added the waiting for code freeze This PR is waiting for a code freeze to resolve. label Jul 22, 2026

dkwingsmt added Decoupling: Port to flutter/packages This PR is ready to be ported to flutter/packages. We will provide instructions to do so. and removed Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. labels Sep 24, 2026

lamnhan066 mentioned this pull request Sep 27, 2026

[material_ui] Fix for time picker error in locales that do not use Latin digits flutter/packages#13035

Merged

11 tasks done

lamnhan066 closed this Sep 27, 2026

lamnhan066 added a commit to lamnhan066/packages that referenced this pull request Sep 29, 2026

[material_ui] Fix time picker localized number parsing (port flutter/…

b6cad91

…flutter#186311)

Conversation

lamnhan066 commented May 10, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

lamnhan066 commented May 18, 2026

Uh oh!

QuncCccccc commented May 18, 2026

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QuncCccccc May 27, 2026

Choose a reason for hiding this comment

Uh oh!

lamnhan066 May 27, 2026

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc commented Jun 17, 2026

Uh oh!

lamnhan066 commented Jun 18, 2026

Uh oh!

elliette commented Jun 18, 2026

Uh oh!

elliette commented Jun 24, 2026

Uh oh!

Piinks commented Jun 24, 2026

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt commented Sep 24, 2026

Uh oh!

lamnhan066 commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lamnhan066 commented Sep 27, 2026 •

edited

Loading