Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage by b-luk · Pull Request #186262 · flutter/flutter

b-luk · 2026-05-08T17:07:30Z

Fix EmbedderTest.CanRenderTextWithImpellerMetal test breakage.

This broke due to #186074. That PR modified how light text is rendered on macOS, but did not update this test's golden image.

This updates the image.

It also changes the test to explicitly render dark text on a light background and light text on a dark background. Previously it rendered white text on a transparent background.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request updates the render_impeller_text_test fixture to render two paragraphs with inverted color schemes. Feedback suggests refactoring the duplicated paragraph construction into a helper function, ensuring ParagraphBuilder.pushStyle calls are balanced with pop(), and using absolute offsets instead of canvas translations for better clarity.

gemini-code-assist · 2026-05-08T17:08:58Z

+    final paragraphBuilder1 = ParagraphBuilder(ParagraphStyle(fontFamily: 'sans-serif'))
+      ..pushStyle(TextStyle(color: darkColor, background: Paint()..color = lightColor))
+      ..addText('Flutter is the best!');
+    final Paragraph paragraph1 = paragraphBuilder1.build()
+      ..layout(const ParagraphConstraints(width: 400));
+    canvas.drawParagraph(paragraph1, const Offset(20, 20));
+
+    canvas.translate(0, 40);
+
+    final paragraphBuilder2 = ParagraphBuilder(ParagraphStyle(fontFamily: 'sans-serif'))
+      ..pushStyle(TextStyle(color: lightColor, background: Paint()..color = darkColor))
      ..addText('Flutter is the best!');
-    final Paragraph paragraph = paragraphBuilder.build()
+    final Paragraph paragraph2 = paragraphBuilder2.build()
      ..layout(const ParagraphConstraints(width: 400));
-    canvas.drawParagraph(paragraph, const Offset(20, 20));
+    canvas.drawParagraph(paragraph2, const Offset(20, 20));


The paragraph building logic is duplicated for the dark and light text cases. Refactoring this into a helper function improves maintainability and readability. Additionally, ParagraphBuilder.pushStyle should be balanced with a pop() call as per the dart:ui API contract. Finally, using absolute offsets instead of mixing canvas.translate with relative offsets makes the positioning logic clearer.

void drawParagraph(Color textColor, Color bgColor, double y) { final builder = ParagraphBuilder(ParagraphStyle(fontFamily: 'sans-serif')) ..pushStyle(TextStyle(color: textColor, background: Paint()..color = bgColor)) ..addText('Flutter is the best!') ..pop(); final paragraph = builder.build() ..layout(const ParagraphConstraints(width: 400)); canvas.drawParagraph(paragraph, Offset(20, y)); } drawParagraph(darkColor, lightColor, 20); drawParagraph(lightColor, darkColor, 60);

References

Suggest simplification and refactoring to enhance readability and maintainability. ^(link)

Avoid duplicating state and logic; keep only one source of truth. ^(link)

jason-simmons · 2026-05-08T23:32:43Z

EmbedderTest.CanRenderTextWithImpellerMetal fails in my local environment with the latest impeller_text_test.png image (from 457b217)

It passes locally with the image from 276ad48

The Metal embedder tests may need to do some kind of approximate image matching in order to work in both local and CI environments.

b-luk · 2026-05-09T00:37:09Z

EmbedderTest.CanRenderTextWithImpellerMetal fails in my local environment with the latest impeller_text_test.png image (from 457b217)

It passes locally with the image from 276ad48

The Metal embedder tests may need to do some kind of approximate image matching in order to work in both local and CI environments.

I think our Skia/Flutter gold testing has an allowable pixel different rate of 0.01. (Default defined here. I don't think it's overridden anywhere so I think we always use the default.) Maybe we can use the same threshold for these tests.

b-luk · 2026-05-09T01:12:14Z

https://github.com/flutter/flutter/pull/186262/checks?check_run_id=75113080600

mac_unopt failed again, but due to timing out because of a slow "mounting git" step for host_debug_unopt_arm64: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/2319766/overview (Related slow "mounting git" step issue: #185767). I'd rerun the test, but I think it's not giving me a re-run button because it's a suppressed test.

The host_debug_arm64_tests, host_profile_arm64_tests, and host_release_arm64_tests tests which were previously failing for the golden test have passed. So I think this is good enough to submit.

…le number of pixel differences

jason-simmons · 2026-05-11T14:29:42Z

I'd like to ensure that these tests can pass both locally and on CI.

I tried creating a patch that lets the tests specify an allowable number of pixel differences. This works on my local setup with the golden images from this PR that pass on CI:
https://github.com/jason-simmons/flutter/tree/pr_186262_approx_match

Can you cherry pick the patch into this PR?

b-luk · 2026-05-12T02:35:44Z

This fixes the original mac_unopt failures. However, a different test in mac_unopt is failing.

https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/2322886/overview

@jason-simmons is working on another PR to fix the Scenario App tests. mac_unopt is expected to pass again after his PR.

Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) flutter/flutter@707dbc0...23f6f58 2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158) 2026-05-12 [email protected] Roll Packages from 19ec8b8 to 93cbed6 (3 revisions) (flutter/flutter#186401) 2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265) 2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321) 2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378) 2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390) 2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396) 2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979) 2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391) 2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310) 2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262) 2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384) 2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302) 2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298) 2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373) 2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341) 2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320) 2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368) 2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984) 2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089) 2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273) 2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907) 2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349) 2026-05-11 [email protected] Roll Packages from 92552b1 to 19ec8b8 (4 revisions) (flutter/flutter#186350) 2026-05-11 [email protected] Check for absolute paths in skills. (flutter/flutter#185632) 2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347) 2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335) 2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328) 2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315) 2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886) 2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259) 2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990) 2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289) 2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283) 2026-05-09 [email protected] Improve non rect platform view rendering (flutter/flutter#182662) 2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278) 2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214) 2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266) 2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264) 2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203) 2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263) 2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210) 2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257) 2026-05-08 [email protected] Roll Packages from 0411f1d to 92552b1 (1 revision) (flutter/flutter#186256) 2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107) 2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242) ...

#186828) This cherry-picks #186262 which will unblock CI for the 3.45 beta candidate branch. At the time of the branch cut, this failure was in the master branch, but `mac_unopt` was suppressed. Including this fix should unblock CI on the beta candidate branch.

Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) flutter/flutter@707dbc0...23f6f58 2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158) 2026-05-12 [email protected] Roll Packages from 19ec8b861676 to 93cbed65f336 (3 revisions) (flutter/flutter#186401) 2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265) 2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321) 2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378) 2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390) 2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396) 2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979) 2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391) 2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310) 2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262) 2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384) 2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302) 2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298) 2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373) 2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341) 2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320) 2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368) 2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984) 2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089) 2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273) 2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907) 2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349) 2026-05-11 [email protected] Roll Packages from 92552b16bcc1 to 19ec8b861676 (4 revisions) (flutter/flutter#186350) 2026-05-11 [email protected] Check for absolute paths in skills. (flutter/flutter#185632) 2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347) 2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335) 2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328) 2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315) 2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886) 2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259) 2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990) 2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289) 2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283) 2026-05-09 [email protected] Improve non rect platform view rendering (flutter/flutter#182662) 2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278) 2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214) 2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266) 2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264) 2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203) 2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263) 2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210) 2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257) 2026-05-08 [email protected] Roll Packages from cfdd1d3 to 92552b16bcc1 (1 revision) (flutter/flutter#186256) 2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107) 2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242) ...

…er#11700) Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) flutter/flutter@707dbc0...23f6f58 2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158) 2026-05-12 [email protected] Roll Packages from 19ec8b8 to 93cbed6 (3 revisions) (flutter/flutter#186401) 2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265) 2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321) 2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378) 2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390) 2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396) 2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979) 2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391) 2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310) 2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262) 2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384) 2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302) 2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298) 2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373) 2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341) 2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320) 2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368) 2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984) 2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089) 2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273) 2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907) 2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349) 2026-05-11 [email protected] Roll Packages from 92552b1 to 19ec8b8 (4 revisions) (flutter/flutter#186350) 2026-05-11 [email protected] Check for absolute paths in skills. (flutter/flutter#185632) 2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347) 2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335) 2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328) 2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315) 2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886) 2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259) 2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990) 2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289) 2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283) 2026-05-09 [email protected] Improve non rect platform view rendering (flutter/flutter#182662) 2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278) 2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214) 2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266) 2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264) 2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203) 2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263) 2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210) 2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257) 2026-05-08 [email protected] Roll Packages from 0411f1d to 92552b1 (1 revision) (flutter/flutter#186256) 2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107) 2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242) ...

commit

d898b03

flutter-dashboard Bot added the CICD Run CI/CD label May 8, 2026

github-actions Bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. labels May 8, 2026

gemini-code-assist Bot reviewed May 8, 2026

View reviewed changes

b-luk requested a review from jason-simmons May 8, 2026 17:08

jason-simmons previously approved these changes May 8, 2026

View reviewed changes

Update image with one generated with default AppleFontSmoothing setting

276ad48

b-luk dismissed jason-simmons’s stale review via 276ad48 May 8, 2026 18:50

github-actions Bot removed the CICD Run CI/CD label May 8, 2026

b-luk requested a review from jason-simmons May 8, 2026 18:50

jason-simmons previously approved these changes May 8, 2026

View reviewed changes

b-luk added the CICD Run CI/CD label May 8, 2026

base64 output

8de3b05

b-luk dismissed jason-simmons’s stale review via 8de3b05 May 8, 2026 21:09

github-actions Bot removed the CICD Run CI/CD label May 8, 2026

b-luk added the CICD Run CI/CD label May 8, 2026

absl for base64 debug output

f7e9f56

github-actions Bot removed the CICD Run CI/CD label May 8, 2026

b-luk added the CICD Run CI/CD label May 8, 2026

revert debug changes, update golden image

457b217

github-actions Bot removed the CICD Run CI/CD label May 8, 2026

b-luk added the CICD Run CI/CD label May 8, 2026

b-luk requested a review from jason-simmons May 8, 2026 23:09

Add a way for Metal embedder golden image tests to specify an allowab…

a7f182b

…le number of pixel differences

github-actions Bot removed the CICD Run CI/CD label May 11, 2026

b-luk added the CICD Run CI/CD label May 11, 2026

Merge branch 'master' into render_impeller_text_test

d80b7fe

github-actions Bot removed the CICD Run CI/CD label May 12, 2026

b-luk added the CICD Run CI/CD label May 12, 2026

b-luk added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2026

auto-submit Bot added this pull request to the merge queue May 12, 2026

Merged via the queue into flutter:master with commit 095d8cf May 12, 2026
202 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2026

This was referenced May 12, 2026

Roll Flutter from 707dbc0420a3 to 2b7ca0c64d6f (144 revisions) flutter/packages#11695

Closed

Roll Flutter from 707dbc0420a3 to 9ca95e5f15a5 (145 revisions) flutter/packages#11696

Closed

b-luk deleted the render_impeller_text_test branch May 12, 2026 16:27

eyebrowsoffire mentioned this pull request May 20, 2026

[beta] Fix EmbedderTest.CanRenderTextWithImpellerMetal test breakage #186828

Merged

LongCatIsLooong mentioned this pull request Jun 18, 2026

[beta] [initial] Flutter Release Version 3.46.0-0.1.pre #188127

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage#186262

Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage#186262
auto-submit[bot] merged 8 commits into
flutter:masterfrom
b-luk:render_impeller_text_test

b-luk commented May 8, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot May 8, 2026

Uh oh!

jason-simmons commented May 8, 2026

Uh oh!

b-luk commented May 9, 2026

Uh oh!

b-luk commented May 9, 2026

Uh oh!

jason-simmons commented May 11, 2026

Uh oh!

b-luk commented May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

b-luk commented May 8, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

jason-simmons commented May 8, 2026

Uh oh!

b-luk commented May 9, 2026

Uh oh!

b-luk commented May 9, 2026

Uh oh!

jason-simmons commented May 11, 2026

Uh oh!

b-luk commented May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants