[flutter_tools] Add doctor validator warning for multiple adb installations#186031
Merged
auto-submit[bot] merged 4 commits intoJun 12, 2026
Merged
Conversation
…ations Detects if multiple unique adb binaries are installed on the user's PATH or Android SDK platform-tools. Having multiple adb versions can lead to conflicting server instances and device detection failures during development. This change adds an `OperatingSystemUtils` dependency injection to `AndroidValidator`, resolves canonical paths using `resolveSymbolicLinksSync` to avoid duplicate symlink warnings, and outputs a hint in `flutter doctor` if multiple unique binaries are found. Fixes flutter#9709
github-actions
Bot
added
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AndroidValidator to detect and warn users when multiple adb binaries are found, which can lead to device detection conflicts. The changes include adding an OperatingSystemUtils dependency to AndroidValidator, updating the context runner, and adding unit tests for the new validation logic. Feedback suggests refactoring the duplicated symbolic link resolution logic into a helper function and refining the warning message phrasing for better accuracy and consistency with other tool hints.
…efine warning phrasing
reidbaker
approved these changes
Jun 8, 2026
camsim99
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/186031, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
mboetger
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/186031, Failed to enqueue flutter/flutter/186031 with HTTP 400: Pull request Required status check "Merge Queue Guard" is expected.. |
mboetger
added
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Jun 13, 2026
This was referenced Jun 13, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 15, 2026
Roll Flutter from b7cb925419e6 to 5827d5fd2b8d (35 revisions) flutter/flutter@b7cb925...5827d5f 2026-06-15 [email protected] Roll Skia from 7128af60575a to c8d9f80f13e4 (1 revision) (flutter/flutter#188015) 2026-06-15 [email protected] In the APNG decoder, validate the chunk data length before calling GetChunkSize to avoid potential overflow in the chunk size calculation (flutter/flutter#187949) 2026-06-15 [email protected] Roll Skia from 6b4ac3bfb39d to 7128af60575a (1 revision) (flutter/flutter#188011) 2026-06-15 [email protected] Roll Skia from 0a3b8549cbf0 to 6b4ac3bfb39d (7 revisions) (flutter/flutter#188007) 2026-06-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[a11y] Map some framework semantics roles to android classes. (#185217)" (flutter/flutter#188008) 2026-06-15 [email protected] [ios] Filter UIScene events to those relating to Flutter VC scene (flutter/flutter#187987) 2026-06-15 [email protected] [a11y] Map some framework semantics roles to android classes. (flutter/flutter#185217) 2026-06-15 [email protected] Roll Skia from f46928e7f50c to 0a3b8549cbf0 (1 revision) (flutter/flutter#188004) 2026-06-14 [email protected] Rework docs for flutter/packages changelogs (flutter/flutter#187666) 2026-06-14 [email protected] Roll Fuchsia Linux SDK from nvzMQAmuRSzo7-wAP... to TbB86Po_HDe1dvXvT... (flutter/flutter#187997) 2026-06-14 [email protected] Roll Skia from 4e2c9b5e4dad to f46928e7f50c (1 revision) (flutter/flutter#187996) 2026-06-14 [email protected] Roll Skia from c52667607242 to 4e2c9b5e4dad (1 revision) (flutter/flutter#187990) 2026-06-14 [email protected] Improve RenderTargetCache docs (flutter/flutter#187893) 2026-06-13 [email protected] [Test cross_imports] Check cross imports in flutter_test/** (flutter/flutter#187587) 2026-06-13 [email protected] Fixing corrupted window size OnEmptyFrameGenerated due to transpsed width/height (flutter/flutter#187954) 2026-06-13 [email protected] Roll Skia from 42355271a335 to c52667607242 (2 revisions) (flutter/flutter#187979) 2026-06-13 [email protected] Roll Fuchsia Linux SDK from A3eaUn9mQ_EkSNxVI... to nvzMQAmuRSzo7-wAP... (flutter/flutter#187975) 2026-06-13 [email protected] Roll Skia from 9ef46390c2d1 to 42355271a335 (1 revision) (flutter/flutter#187974) 2026-06-13 [email protected] [Flutter GPU] Make ShaderLibrary.fromAsset asynchronous (flutter/flutter#187716) 2026-06-13 [email protected] Roll Skia from 8c89bf2b0ee3 to 9ef46390c2d1 (6 revisions) (flutter/flutter#187968) 2026-06-12 [email protected] [Flutter GPU] Add surface API for framework presentation (flutter/flutter#187358) 2026-06-12 [email protected] [gen_l10n] Exclude inherited keys from untranslated-messages-file (flutter/flutter#187950) 2026-06-12 [email protected] Update `MediaQueryData` docs for devicePixelRatio overriding (flutter/flutter#187542) 2026-06-12 [email protected] [Impeller] Fix dirty-range race in DeviceBufferGLES uploads (flutter/flutter#187932) 2026-06-12 [email protected] Compare isModifiedAfter against the given time (flutter/flutter#187727) 2026-06-12 [email protected] Enable unit tests for compilation of compute shaders on non-metal backends (flutter/flutter#179683) 2026-06-12 [email protected] [flutter_tools] Add doctor validator warning for multiple adb installations (flutter/flutter#186031) 2026-06-12 [email protected] Optimize SHA hash calculation of generated APK (flutter/flutter#187184) 2026-06-12 [email protected] Scope widget inspector overlay to the selected widget's modal route (flutter/flutter#186784) 2026-06-12 [email protected] Switches Windows to OpenGLESSDF (flutter/flutter#187877) 2026-06-12 [email protected] [integration_test] Update README to support modern Kotlin-based setups by default (flutter/flutter#186080) 2026-06-12 [email protected] Convert the PNG signature constant in APNGImageGenerator to a std::array and use it in the APNG tests (flutter/flutter#187930) 2026-06-12 [email protected] Correct backoff retry time cap unit and add regression tests (flutter/flutter#187250) 2026-06-12 [email protected] Fix std::vector out-of-bounds access in Flutter Android JNI and Delegate (flutter/flutter#187218) 2026-06-12 [email protected] [Android] Adding 30-second timeouts to adb stopApp and uninstallApp (flutter/flutter#187876) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
…ations (flutter#186031) Detects if multiple unique adb binaries are installed on the user's PATH or Android SDK platform-tools. Having multiple adb versions can lead to conflicting server instances and device detection failures during development. This change adds an `OperatingSystemUtils` dependency injection to `AndroidValidator`, resolves canonical paths using `resolveSymbolicLinksSync` to avoid duplicate symlink warnings, and outputs a hint in `flutter doctor` if multiple unique binaries are found. Fixes flutter#9709 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detects if multiple unique adb binaries are installed on the user's PATH or Android SDK platform-tools. Having multiple adb versions can lead to conflicting server instances and device detection failures during development.
This change adds an
OperatingSystemUtilsdependency injection toAndroidValidator, resolves canonical paths usingresolveSymbolicLinksSyncto avoid duplicate symlink warnings, and outputs a hint influtter doctorif multiple unique binaries are found.Fixes #9709
Pre-launch Checklist
///).