refactor: update filename for sliver semantic widget#185917
Merged
Merged
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request relocates the main function and removes the group wrapper in sliver_semantics_widget_test.dart. Feedback suggests moving the main function back to the top of the file to follow standard conventions, restoring the group wrapper for improved test reporting, and renaming the file for consistency with other sliver tests.
navaronbracke
previously approved these changes
May 2, 2026
rkishan516
force-pushed
the
sliver-semantics
branch
from
May 4, 2026 01:20
151758c to
7c3a5d3
Compare
rkishan516
force-pushed
the
sliver-semantics
branch
from
May 4, 2026 02:06
7c3a5d3 to
25965b2
Compare
Renzo-Olivares
approved these changes
May 12, 2026
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for the contribution!
navaronbracke
approved these changes
May 13, 2026
Renzo-Olivares
added
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/185917, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
auto-submit
Bot
removed
the
autosubmit
Renzo-Olivares
added
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/185917, because - The status or check suite Mac_x64 tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Renzo-Olivares
added
the
autosubmit
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 15, 2026
flutter-dashboard
Bot
removed
the
autosubmit
Renzo-Olivares
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced May 16, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 18, 2026
flutter/flutter@1ceffd1...3598686 2026-05-17 [email protected] Roll Fuchsia Linux SDK from G9xv1qcMhvXOy-9pk... to 5Ki-dBY4SpWdQMF_3... (flutter/flutter#186636) 2026-05-17 [email protected] [Impeller] Canonicalize uniform block instance names for the GL backends (flutter/flutter#186394) 2026-05-16 [email protected] [widgets] Use super parameters in missed spots (flutter/flutter#186198) 2026-05-16 [email protected] refactor: Remove material imports from Widget tests (flutter/flutter#185078) 2026-05-16 [email protected] Roll pub packages (flutter/flutter#186602) 2026-05-16 [email protected] [gn] Fix typo in comment (flutter/flutter#186549) 2026-05-16 [email protected] Roll Fuchsia Linux SDK from y6uQHA5xUN83IF395... to G9xv1qcMhvXOy-9pk... (flutter/flutter#186599) 2026-05-15 [email protected] Removes bringup from passing macos/sdf tests (flutter/flutter#186527) 2026-05-15 [email protected] [web] Fix several WebParagraph bugs (flutter/flutter#186403) 2026-05-15 [email protected] Display the team ID and name when selecting a signing certificate (flutter/flutter#184665) 2026-05-15 [email protected] [iOS] Improve documentation on FlutterVSyncClient and FlutterDisplayLink (flutter/flutter#186456) 2026-05-15 [email protected] Increase the run time of text field integration tests to 10 seconds (flutter/flutter#186475) 2026-05-15 [email protected] Fix web-server hot restart/reload not applying changes for entrypoints outside lib (flutter/flutter#183838) 2026-05-15 [email protected] Update dart_skills_lint dependency to e449787 and optimize skills validation test (flutter/flutter#186528) 2026-05-15 [email protected] Roll Packages from 2ec2236 to 32c84d6 (3 revisions) (flutter/flutter#186583) 2026-05-15 [email protected] Dispose TextEditingController in IndexedStack example (flutter/flutter#186375) 2026-05-15 [email protected] refactor: update filename for sliver semantic widget (flutter/flutter#185917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11724) flutter/flutter@1ceffd1...3598686 2026-05-17 [email protected] Roll Fuchsia Linux SDK from G9xv1qcMhvXOy-9pk... to 5Ki-dBY4SpWdQMF_3... (flutter/flutter#186636) 2026-05-17 [email protected] [Impeller] Canonicalize uniform block instance names for the GL backends (flutter/flutter#186394) 2026-05-16 [email protected] [widgets] Use super parameters in missed spots (flutter/flutter#186198) 2026-05-16 [email protected] refactor: Remove material imports from Widget tests (flutter/flutter#185078) 2026-05-16 [email protected] Roll pub packages (flutter/flutter#186602) 2026-05-16 [email protected] [gn] Fix typo in comment (flutter/flutter#186549) 2026-05-16 [email protected] Roll Fuchsia Linux SDK from y6uQHA5xUN83IF395... to G9xv1qcMhvXOy-9pk... (flutter/flutter#186599) 2026-05-15 [email protected] Removes bringup from passing macos/sdf tests (flutter/flutter#186527) 2026-05-15 [email protected] [web] Fix several WebParagraph bugs (flutter/flutter#186403) 2026-05-15 [email protected] Display the team ID and name when selecting a signing certificate (flutter/flutter#184665) 2026-05-15 [email protected] [iOS] Improve documentation on FlutterVSyncClient and FlutterDisplayLink (flutter/flutter#186456) 2026-05-15 [email protected] Increase the run time of text field integration tests to 10 seconds (flutter/flutter#186475) 2026-05-15 [email protected] Fix web-server hot restart/reload not applying changes for entrypoints outside lib (flutter/flutter#183838) 2026-05-15 [email protected] Update dart_skills_lint dependency to e449787 and optimize skills validation test (flutter/flutter#186528) 2026-05-15 [email protected] Roll Packages from 2ec2236 to 32c84d6 (3 revisions) (flutter/flutter#186583) 2026-05-15 [email protected] Dispose TextEditingController in IndexedStack example (flutter/flutter#186375) 2026-05-15 [email protected] refactor: update filename for sliver semantic widget (flutter/flutter#185917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is follow up to #185567 (comment) conversation where we want to properly name and split test files.
part of: #177415
Current Status
sliversemantics_test.darttosliver_semantics_widget_test.dartPre-launch Checklist
///).