Make DeepLinkJsonFromManifestTask Gradle task build cacheable#185903
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
platform-android
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
gmackall
previously approved these changes
May 1, 2026
gmackall
left a comment
gmackall
left a comment
Member
There was a problem hiding this comment.
lgtm, though I would nit the description by specifically saying that we don't use the Gradle "build cache".
Gradle still does "cache" stuff in the typical meaning of the word through the incremental build system, and I think people who come across this PR might get an incorrect understanding (though that is really mostly Gradle's fault for naming their long-lived cache the Gradle "build cache", as I think a short lived cache is still in fact a cache).
jmagman
changed the title
Member
Author
Done! |
github-actions
Bot
added
team-android
Member
Author
Added a test |
gmackall
previously approved these changes
May 7, 2026
jmagman
added
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/185903, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
Member
Author
|
Sorry @gmackall another review please. This is taking forever.... |
jmagman
added
the
autosubmit
gmackall
approved these changes
May 12, 2026
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced May 13, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 15, 2026
…11713) Manual roll requested by [email protected] flutter/flutter@23f6f58...0541913 2026-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Windows] Propagate the enabled accessibility state (#184501)" (flutter/flutter#186492) 2026-05-13 [email protected] [dev] Use super parameters in missed spots (flutter/flutter#186193) 2026-05-13 [email protected] [Windows] Propagate the enabled accessibility state (flutter/flutter#184501) 2026-05-13 [email protected] [flutter_tool] filter out MotionEvent-JNI warning spam from logcat (#174783) (flutter/flutter#186079) 2026-05-13 [email protected] Roll Packages from 93cbed6 to 2ec2236 (1 revision) (flutter/flutter#186464) 2026-05-13 [email protected] [web] Fix untriaged issues link label (flutter/flutter#186465) 2026-05-13 [email protected] [Impeller] Namespace user-supplied shaders to prevent entrypoint collisions (flutter/flutter#186332) 2026-05-13 [email protected] [flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task (flutter/flutter#184731) 2026-05-13 [email protected] Update the Flutter Gallery web app template files to support running with Wasm (flutter/flutter#186268) 2026-05-13 [email protected] [web] Use heap allocation for buffers that would consume too much space on the Wasm stack (flutter/flutter#186228) 2026-05-13 [email protected] Roll Skia from 56ca5896c0d9 to 27f7bba22600 (3 revisions) (flutter/flutter#186444) 2026-05-13 [email protected] Roll Fuchsia Linux SDK from z7ICmPtn4hspu02zk... to y6uQHA5xUN83IF395... (flutter/flutter#186442) 2026-05-13 [email protected] Roll Skia from 6385958d2feb to 56ca5896c0d9 (1 revision) (flutter/flutter#186441) 2026-05-13 [email protected] Roll Dart SDK from 9576691c37d8 to 8e30b88e4d5a (1 revision) (flutter/flutter#186429) 2026-05-13 [email protected] Roll Skia from 77a21bc723dc to 6385958d2feb (9 revisions) (flutter/flutter#186428) 2026-05-13 [email protected] Docs/improving docs for semantics UI lib (flutter/flutter#186125) 2026-05-12 [email protected] [Tool] Support glob patterns when parsing workspaces in FlutterProject (flutter/flutter#185715) 2026-05-12 [email protected] docs: fix overriden -> overridden in MediaQueryData dartdoc (flutter/flutter#186323) 2026-05-12 [email protected] [Test cross imports] No material in `test/foundation`, `test/gestures`, `test/semantics`, `test/services` (flutter/flutter#186144) 2026-05-12 [email protected] docs: fix "tha" -> "that" typo in widget_inspector_test comment (flutter/flutter#186322) 2026-05-12 [email protected] docs: Fix doubled-word typos in framework dartdoc (flutter/flutter#186319) 2026-05-12 [email protected] Roll pub packages (flutter/flutter#186418) 2026-05-12 [email protected] Bumped required mediatek vender sdk version. (flutter/flutter#186405) 2026-05-12 [email protected] Make DeepLinkJsonFromManifestTask Gradle task build cacheable (flutter/flutter#185903) 2026-05-12 [email protected] Harden dev tooling scripts against command injection and log leaks (flutter/flutter#186076) 2026-05-12 [email protected] Roll pub packages (flutter/flutter#186274) 2026-05-12 [email protected] [Flutter GPU] Allow allocating multi-mip textures and overwriting specific (mip, slice) levels (flutter/flutter#185890) 2026-05-12 [email protected] [web] Fix MenuAnchor dismiss when semantics enabled (flutter/flutter#183093) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…lutter#11713) Manual roll requested by [email protected] flutter/flutter@23f6f58...0541913 2026-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Windows] Propagate the enabled accessibility state (#184501)" (flutter/flutter#186492) 2026-05-13 [email protected] [dev] Use super parameters in missed spots (flutter/flutter#186193) 2026-05-13 [email protected] [Windows] Propagate the enabled accessibility state (flutter/flutter#184501) 2026-05-13 [email protected] [flutter_tool] filter out MotionEvent-JNI warning spam from logcat (#174783) (flutter/flutter#186079) 2026-05-13 [email protected] Roll Packages from 93cbed6 to 2ec2236 (1 revision) (flutter/flutter#186464) 2026-05-13 [email protected] [web] Fix untriaged issues link label (flutter/flutter#186465) 2026-05-13 [email protected] [Impeller] Namespace user-supplied shaders to prevent entrypoint collisions (flutter/flutter#186332) 2026-05-13 [email protected] [flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task (flutter/flutter#184731) 2026-05-13 [email protected] Update the Flutter Gallery web app template files to support running with Wasm (flutter/flutter#186268) 2026-05-13 [email protected] [web] Use heap allocation for buffers that would consume too much space on the Wasm stack (flutter/flutter#186228) 2026-05-13 [email protected] Roll Skia from 56ca5896c0d9 to 27f7bba22600 (3 revisions) (flutter/flutter#186444) 2026-05-13 [email protected] Roll Fuchsia Linux SDK from z7ICmPtn4hspu02zk... to y6uQHA5xUN83IF395... (flutter/flutter#186442) 2026-05-13 [email protected] Roll Skia from 6385958d2feb to 56ca5896c0d9 (1 revision) (flutter/flutter#186441) 2026-05-13 [email protected] Roll Dart SDK from 9576691c37d8 to 8e30b88e4d5a (1 revision) (flutter/flutter#186429) 2026-05-13 [email protected] Roll Skia from 77a21bc723dc to 6385958d2feb (9 revisions) (flutter/flutter#186428) 2026-05-13 [email protected] Docs/improving docs for semantics UI lib (flutter/flutter#186125) 2026-05-12 [email protected] [Tool] Support glob patterns when parsing workspaces in FlutterProject (flutter/flutter#185715) 2026-05-12 [email protected] docs: fix overriden -> overridden in MediaQueryData dartdoc (flutter/flutter#186323) 2026-05-12 [email protected] [Test cross imports] No material in `test/foundation`, `test/gestures`, `test/semantics`, `test/services` (flutter/flutter#186144) 2026-05-12 [email protected] docs: fix "tha" -> "that" typo in widget_inspector_test comment (flutter/flutter#186322) 2026-05-12 [email protected] docs: Fix doubled-word typos in framework dartdoc (flutter/flutter#186319) 2026-05-12 [email protected] Roll pub packages (flutter/flutter#186418) 2026-05-12 [email protected] Bumped required mediatek vender sdk version. (flutter/flutter#186405) 2026-05-12 [email protected] Make DeepLinkJsonFromManifestTask Gradle task build cacheable (flutter/flutter#185903) 2026-05-12 [email protected] Harden dev tooling scripts against command injection and log leaks (flutter/flutter#186076) 2026-05-12 [email protected] Roll pub packages (flutter/flutter#186274) 2026-05-12 [email protected] [Flutter GPU] Allow allocating multi-mip textures and overwriting specific (mip, slice) levels (flutter/flutter#185890) 2026-05-12 [email protected] [web] Fix MenuAnchor dismiss when semantics enabled (flutter/flutter#183093) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle build caching isn't on by default, but a developer can easily set it themselves via
org.gradle.caching=true. This change annotatesDeepLinkJsonFromManifestTaskgradle task with@CacheableTaskso it can be cached if build caching is turned on (note, this is a separate caching concept from the one used to decide what's dirty for incremental builds). The task is only generating a json file based on the AndroidManifest and manifest, and it already has clear inputs and outputs.Also add
@PathSensitive(PathSensitivity.RELATIVE)to the manifestFile input so the cache is relocatable across directories.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.