Skip to content

[Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range#185886

Merged
bdero merged 2 commits into
flutter:masterfrom
bdero:bdero/vulkan-viewport-offset
May 10, 2026
Merged

[Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range#185886
bdero merged 2 commits into
flutter:masterfrom
bdero:bdero/vulkan-viewport-offset

Conversation

@bdero

@bdero bdero commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #185885

RenderPassVK::SetViewport builds a vk::Viewport via chained setters that never invoke .setX(...). Because vk::Viewport() default-initializes x to 0.0f, the user's X is silently dropped. Y is also effectively dropped (the existing code calls setY(rect.GetHeight()) to perform the negative-height Y-flip, never reading rect.GetY()), and minDepth / maxDepth are hardcoded to 0/1, ignoring the user's DepthRange.

The bug has been present since e7be989feb1c ("Reland: Encode directly to command buffer.", 2024-01-19).

Goldens

Once this lands, the existing Vulkan golden for flutter_gpu_test_viewport.png will need to be re-uploaded on Skia Gold to match the corrected output. The flutter_gpu_test_viewport test in gpu_test.dart is currently disabled on GLES (re-enabled in #185879); both backends will produce the same correct render after this PR plus #185879 land.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 1, 2026
@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 1, 2026
@bdero
bdero marked this pull request as ready for review May 1, 2026 09:28
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 1, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in the Vulkan backend where SetViewport ignored X/Y offsets and depth ranges by implementing a ToVkViewport helper function. It also adds regression tests for GLES and Vulkan and updates the Vulkan mock to track recorded viewports. Review feedback suggests using triple-slash documentation comments to follow the style guide and simplifying the unit tests by removing a redundant variable.

Comment thread engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_vk.cc Outdated
Comment thread engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_vk_unittests.cc Outdated
@bdero
bdero force-pushed the bdero/vulkan-viewport-offset branch from 7e67ca2 to 2186641 Compare May 1, 2026 09:34
@github-actions github-actions Bot removed the CICD Run CI/CD label May 1, 2026
@bdero
bdero requested a review from gaaclarke May 1, 2026 09:38
@gaaclarke

gaaclarke commented May 1, 2026

Copy link
Copy Markdown
Member

Once this lands, the existing Vulkan golden for flutter_gpu_test_viewport.png will need to be re-uploaded on Skia Gold to match the corrected output. The flutter_gpu_test_viewport test in gpu_test.dart is currently disabled on GLES (re-enabled in #185879); both backends will produce the same correct render after this PR plus #185879 land.

I think you just dismiss the approval on the old goldens.

gaaclarke
gaaclarke reviewed May 1, 2026
View reviewed changes

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one note

Comment thread engine/src/flutter/impeller/renderer/backend/vulkan/test/mock_vulkan.h Outdated

/// @brief Returns the viewports passed to `vkCmdSetViewport` calls on the
/// given command buffer, in call order.
std::vector<VkViewport>& GetRecordedViewports(VkCommandBuffer buffer);

@gaaclarke gaaclarke May 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::vector<VkViewport>& GetRecordedViewports(VkCommandBuffer buffer);
const std::vector<VkViewport>& GetRecordedViewports(VkCommandBuffer buffer) const;

I didn't see a reason why this has to be a non-const function.

@bdero bdero May 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 👍

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 1, 2026
@gaaclarke

gaaclarke commented May 1, 2026

Copy link
Copy Markdown
Member

(friendly ping: I think you addressed my feedback but didn't hit the "re-request review" button)

@flutter-dashboard

flutter-dashboard Bot commented May 1, 2026

Copy link
Copy Markdown

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #185886 at sha 807634d

@flutter-dashboard flutter-dashboard Bot added the will affect goldens Changes to golden files label May 1, 2026
@bdero
bdero requested a review from gaaclarke May 1, 2026 21:20
gaaclarke
gaaclarke approved these changes May 1, 2026
View reviewed changes

@gaaclarke gaaclarke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bdero
bdero enabled auto-merge May 1, 2026 21:21
@github-actions github-actions Bot removed the CICD Run CI/CD label May 1, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 2, 2026
@bdero

bdero commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Closing/reopening to retrigger CI. Current failures look like upstream pub.dev advisories format issue, not this PR.

@bdero bdero closed this May 9, 2026
auto-merge was automatically disabled May 9, 2026 02:06

Pull request was closed

@bdero bdero reopened this May 9, 2026
@fluttergithubbot

fluttergithubbot commented May 9, 2026

Copy link
Copy Markdown
Contributor

An existing Git SHA, 1fef7361d53dd0196cbabf32b7de90f5a7012444, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

bdero added 2 commits May 10, 2026 01:10
@bdero
[Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth …
13dbd4e 
…range

`RenderPassVK::SetViewport` builds a `vk::Viewport` via chained setters
that never invoke `.setX(...)`. Because `vk::Viewport()` default-
initializes `x` to `0.0f`, the user's X is silently dropped. Y is also
effectively dropped (the existing code calls `setY(rect.GetHeight())`
to perform the negative-height Y-flip, never reading `rect.GetY()`),
and `minDepth` / `maxDepth` are hardcoded to 0/1, ignoring the user's
`DepthRange`.

The bug has been present since `e7be989feb1c` ("Reland: Encode
directly to command buffer.", 2024-01-19) and stayed hidden because:

- No Vulkan unit test exercised non-zero `x`, `y`, or a non-default
  depth range in `SetViewport`.
- The `Can render portion of the triangle using viewport` test in
  `gpu_test.dart` was running on Vulkan and producing a buggy golden
  once, then comparing against itself forever.
- The same test was disabled on the GLES backend via
  flutter#183530 due to an upstream
  `float_type` regression, so the GLES rendering (which honors X
  correctly) never ran to expose the discrepancy.

The `float_type` fix in
flutter#185879 re-enables the GLES
test, which produces a (correct) centered render that does not match
the (buggy) Vulkan reference.

This fix:

- Adds `.setX(viewport.rect.GetX())`.
- Replaces `.setY(viewport.rect.GetHeight())` with
  `.setY(viewport.rect.GetY() + viewport.rect.GetHeight())` so a
  non-zero Y offset propagates through the negative-height flip.
- Replaces hardcoded `setMinDepth(0.0f)` / `setMaxDepth(1.0f)` with
  the user's `viewport.depth_range.z_near` / `z_far`.
- Extracts the conversion into a `ToVkViewport` static helper so the
  initial-viewport setup at construction and `SetViewport` share a
  single formula.

Tests:

- `RenderPassVK.SetViewportPropagatesAllUserSuppliedFields` is a new
  regression guard. It uses an extension to the Vulkan mock
  (`recorded_viewports_` on `MockCommandBuffer`, exposed via
  `GetRecordedViewports`) that records the actual `VkViewport`
  parameters passed to `vkCmdSetViewport`. The test asserts that all
  six fields (`x`, `y`, `width`, `height`, `minDepth`, `maxDepth`)
  reach the GPU with the correct values for a viewport with non-zero
  X, Y, and a non-default depth range.
- `RenderPassGLESViewportTest.ViewportWithNonZeroXOffsetReachesGL`
  is a sibling regression guard for the GLES backend (which has
  always been correct, but was previously not asserted with a
  non-zero X) so a future change can't silently regress it.

Once this lands, the existing Vulkan golden for
`flutter_gpu_test_viewport.png` will need to be re-uploaded on Skia
Gold to match the corrected output.

Fixes flutter#185885
@bdero
Return GetRecordedViewports as a const reference
b2138a0 
Callers only read from the returned vector, so a const reference is the
right type. Update the unittest's local alias to match.
@bdero
bdero force-pushed the bdero/vulkan-viewport-offset branch from 1fef736 to b2138a0 Compare May 10, 2026 08:11
@github-actions github-actions Bot removed the CICD Run CI/CD label May 10, 2026
@bdero
bdero enabled auto-merge May 10, 2026 08:11
@bdero bdero added the CICD Run CI/CD label May 10, 2026
@bdero
bdero added this pull request to the merge queue May 10, 2026
Merged via the queue into flutter:master with commit 3621426 May 10, 2026
197 checks passed
@bdero
bdero deleted the bdero/vulkan-viewport-offset branch May 10, 2026 10:36
This was referenced May 10, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request May 14, 2026
@engine-flutter-autoroll
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) (#11700)
0ffbde8 
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions)

flutter/flutter@707dbc0...23f6f58

2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158)
2026-05-12 [email protected] Roll Packages from 19ec8b8 to 93cbed6 (3 revisions) (flutter/flutter#186401)
2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265)
2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321)
2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378)
2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390)
2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396)
2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979)
2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391)
2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310)
2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262)
2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384)
2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302)
2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298)
2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373)
2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341)
2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320)
2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368)
2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984)
2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089)
2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273)
2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907)
2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349)
2026-05-11 [email protected] Roll Packages from 92552b1 to 19ec8b8 (4 revisions) (flutter/flutter#186350)
2026-05-11 [email protected] Check for absolute paths in skills.  (flutter/flutter#185632)
2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347)
2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335)
2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328)
2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315)
2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886)
2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259)
2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990)
2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289)
2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283)
2026-05-09 [email protected] Improve non rect platform view rendering  (flutter/flutter#182662)
2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278)
2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214)
2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266)
2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264)
2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203)
2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263)
2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210)
2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257)
2026-05-08 [email protected] Roll Packages from 0411f1d to 92552b1 (1 revision) (flutter/flutter#186256)
2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107)
2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242)
...
stuartmorgan-g pushed a commit to flutter/core-packages that referenced this pull request Jun 9, 2026
@engine-flutter-autoroll
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) (#11700)
7abdf27 
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions)

flutter/flutter@707dbc0...23f6f58

2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158)
2026-05-12 [email protected] Roll Packages from 19ec8b861676 to 93cbed65f336 (3 revisions) (flutter/flutter#186401)
2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265)
2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321)
2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378)
2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390)
2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396)
2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979)
2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391)
2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310)
2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262)
2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384)
2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302)
2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298)
2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373)
2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341)
2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320)
2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368)
2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984)
2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089)
2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273)
2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907)
2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349)
2026-05-11 [email protected] Roll Packages from 92552b16bcc1 to 19ec8b861676 (4 revisions) (flutter/flutter#186350)
2026-05-11 [email protected] Check for absolute paths in skills.  (flutter/flutter#185632)
2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347)
2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335)
2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328)
2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315)
2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886)
2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259)
2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990)
2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289)
2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283)
2026-05-09 [email protected] Improve non rect platform view rendering  (flutter/flutter#182662)
2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278)
2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214)
2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266)
2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264)
2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203)
2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263)
2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210)
2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257)
2026-05-08 [email protected] Roll Packages from cfdd1d3 to 92552b16bcc1 (1 revision) (flutter/flutter#186256)
2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107)
2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242)
...
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) (flutt…
cc38704 
…er#11700)

Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions)

flutter/flutter@707dbc0...23f6f58

2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158)
2026-05-12 [email protected] Roll Packages from 19ec8b8 to 93cbed6 (3 revisions) (flutter/flutter#186401)
2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265)
2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321)
2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378)
2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390)
2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396)
2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979)
2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391)
2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310)
2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262)
2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384)
2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302)
2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298)
2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373)
2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341)
2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320)
2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368)
2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984)
2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089)
2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273)
2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907)
2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349)
2026-05-11 [email protected] Roll Packages from 92552b1 to 19ec8b8 (4 revisions) (flutter/flutter#186350)
2026-05-11 [email protected] Check for absolute paths in skills.  (flutter/flutter#185632)
2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347)
2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335)
2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328)
2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315)
2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886)
2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259)
2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990)
2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289)
2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283)
2026-05-09 [email protected] Improve non rect platform view rendering  (flutter/flutter#182662)
2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278)
2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214)
2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266)
2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264)
2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203)
2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263)
2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210)
2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257)
2026-05-08 [email protected] Roll Packages from 0411f1d to 92552b1 (1 revision) (flutter/flutter#186256)
2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107)
2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Flutter GPU] Vulkan backend: setViewport drops X and Y offsets

3 participants

@bdero @gaaclarke @fluttergithubbot