Repository navigation
Conversation
Contributor
|
Greetings from stale PR triage! 👋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the multi-view sizing regression (#185034) by optimizing how the shared OffscreenCanvas is managed. Instead of resizing the canvas for every view, we allow it to grow to the maximum required size and use createImageBitmap cropping to extract the correct region for each view.
Design
OffscreenCanvasRasterizerto maintain a single surface that uses a newsetMinimumSizemethod. This prevents unnecessary shrinking and re-initialization of the WebGL context.OffscreenSurface.rasterizeToImageBitmapsnow accepts an optional size.createImageBitmapbounds parameters.createImageBitmapwrapper indom.dartto use named parameters, improving readability and avoiding record allocations on every frame.Pros:
views).
between views of different sizes.
Cons:
rendering across views.
Testing
engine/src/flutter/lib/web_ui/test/ui/multi_view_sizing_test.dart.