Move try/catch to processFileLines_#185646
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
Bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors project migration logic by moving error handling from specific migration subclasses to the ProjectMigrator base class. The review feedback points out that this move results in a regression, as the try/catch block now only covers file write operations, leaving file reads unprotected.
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
I think the gemini comment here is good. We should be treating both reads and writes as unsafe (and processFileLines does both)
Done. This was a test using gemini to tackle backlog issues and I wish the local gemini caught this :( |
Co-authored-by: Gray Mackall <[email protected]>
mboetger
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/185646, because - The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
Bot
removed
the
autosubmit
|
I think the test failures may have been real by the way (at least, in the sense that mocking updates are needed and they won't go away w/ retry). |
github-actions
Bot
added
team-android
mboetger
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/185646, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
mboetger
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
2 participants
Move try/catch to base implementation of processFileLines_
Fixes: #184595
Pre-launch Checklist
///).