Check for absolute paths in skills. #185632
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new lint rule, CheckBackticksRelativePathsRule, which identifies repository-relative paths within backticks in skill documentation and suggests converting them to relative Markdown links. The changes include the implementation of this rule, updates to the find-release skill documentation, and enhancements to the validation tests. Review feedback focuses on refining the path matching logic to prevent false positives, removing redundant checks, and ensuring cross-platform compatibility by normalizing path separators to forward slashes in the suggested fixes.
camsim99
left a comment
There was a problem hiding this comment.
RSLGTM to unblock. Overall LGTM but I do agree with one of the gemini comments, left a comment below.
| final String normalizedText = textInBackticks.replaceAll(r'\', '/'); | ||
|
|
||
| for (final String validPath in valid2SegmentPaths) { | ||
| if (normalizedText.startsWith('$validPath/')) { |
There was a problem hiding this comment.
I agree with gemini that this could be problematic if validPath and normalizedText have the same amount of levels because it assumes the /. Or is this not a concern?
There was a problem hiding this comment.
I think it is ok. Here is my logic.
engine/src/ and engine/src/filepath.md would match but engine/src would not and neither would engine/somefile.txt. This means that files that are linked are likely to have the the slash of the second directory but if you are referencing the directory you get skipped.
The goal is to catch accidental deep backtick indicated file paths. Even the decision to require 2 folder matches was mostly because I wanted to avoid false positives and I believe that agents tend to read the documents that are at the root and the deeper you go the less likely they are to have read the linked file.
There was a problem hiding this comment.
That makes sense to me, thanks for explaining!
|
autosubmit label was removed for flutter/flutter/185632, because - The status or check suite Linux framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
|
autosubmit label was removed for flutter/flutter/185632, because - The status or check suite Mac_arm64 framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Failed to upload gs://flutter_infra_release/releases/manifest.json with generation match 12345: PreparePackageException: Running "python3 /depot_tools/gsutil.py -- -h x-goog-if-generation-match:12345 cp /.tmp_rand0/test_temp.rand0/upload.json gs://flutter_infra_release/releases/manifest.json" in /b/s/w/ir/x/w/flutter/dev/bots failed: That does not seem related to my pr. |
…arty/dart/tools/find_release.dart
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) flutter/flutter@707dbc0...23f6f58 2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158) 2026-05-12 [email protected] Roll Packages from 19ec8b8 to 93cbed6 (3 revisions) (flutter/flutter#186401) 2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265) 2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321) 2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378) 2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390) 2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396) 2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979) 2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391) 2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310) 2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262) 2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384) 2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302) 2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298) 2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373) 2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341) 2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320) 2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368) 2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984) 2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089) 2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273) 2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907) 2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349) 2026-05-11 [email protected] Roll Packages from 92552b1 to 19ec8b8 (4 revisions) (flutter/flutter#186350) 2026-05-11 [email protected] Check for absolute paths in skills. (flutter/flutter#185632) 2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347) 2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335) 2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328) 2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315) 2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886) 2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259) 2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990) 2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289) 2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283) 2026-05-09 [email protected] Improve non rect platform view rendering (flutter/flutter#182662) 2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278) 2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214) 2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266) 2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264) 2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203) 2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263) 2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210) 2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257) 2026-05-08 [email protected] Roll Packages from 0411f1d to 92552b1 (1 revision) (flutter/flutter#186256) 2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107) 2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242) ...
Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) flutter/flutter@707dbc0...23f6f58 2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158) 2026-05-12 [email protected] Roll Packages from 19ec8b861676 to 93cbed65f336 (3 revisions) (flutter/flutter#186401) 2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265) 2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321) 2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378) 2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390) 2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396) 2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979) 2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391) 2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310) 2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262) 2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384) 2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302) 2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298) 2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373) 2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341) 2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320) 2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368) 2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984) 2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089) 2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273) 2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907) 2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349) 2026-05-11 [email protected] Roll Packages from 92552b16bcc1 to 19ec8b861676 (4 revisions) (flutter/flutter#186350) 2026-05-11 [email protected] Check for absolute paths in skills. (flutter/flutter#185632) 2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347) 2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335) 2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328) 2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315) 2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886) 2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259) 2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990) 2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289) 2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283) 2026-05-09 [email protected] Improve non rect platform view rendering (flutter/flutter#182662) 2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278) 2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214) 2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266) 2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264) 2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203) 2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263) 2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210) 2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257) 2026-05-08 [email protected] Roll Packages from cfdd1d3 to 92552b16bcc1 (1 revision) (flutter/flutter#186256) 2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107) 2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242) ...
…er#11700) Roll Flutter from 707dbc0420a3 to 23f6f5853f50 (149 revisions) flutter/flutter@707dbc0...23f6f58 2026-05-12 [email protected] Add 'cp: review' label to the manual cherrypick process (flutter/flutter#186158) 2026-05-12 [email protected] Roll Packages from 19ec8b8 to 93cbed6 (3 revisions) (flutter/flutter#186401) 2026-05-12 [email protected] Removes SDF option for macOS (always enabled) (flutter/flutter#186265) 2026-05-12 [email protected] docs: fix typos in flutter_tools comments (flutter/flutter#186321) 2026-05-12 [email protected] Pass XcodeBasedProject instead of String to functions in XcodeProjectInterpreter (flutter/flutter#186378) 2026-05-12 [email protected] Update iOS scenario app test goldens to match changes from flutter/flutter#182662 (flutter/flutter#186390) 2026-05-12 [email protected] Roll Skia from ad0aff15b9fa to 77a21bc723dc (2 revisions) (flutter/flutter#186396) 2026-05-12 [email protected] Migrate focus_node.unfocus.0.dart to use `RadioGroup` (flutter/flutter#183979) 2026-05-12 [email protected] Roll Skia from 91d3c1e730af to ad0aff15b9fa (7 revisions) (flutter/flutter#186391) 2026-05-12 [email protected] [Flutter GPU] Allow customizing the vertex layout on a RenderPipeline (flutter/flutter#186310) 2026-05-12 [email protected] Fix `EmbedderTest.CanRenderTextWithImpellerMetal` test breakage (flutter/flutter#186262) 2026-05-12 [email protected] Roll Fuchsia Linux SDK from rFhU-YPqdCRCtCz7b... to z7ICmPtn4hspu02zk... (flutter/flutter#186384) 2026-05-12 [email protected] [Impeller] GLES: lazily allocate texture mip levels on first per-level write (flutter/flutter#186302) 2026-05-12 [email protected] [Android] Propagate --enable-flutter-gpu Intent extra to engine args (flutter/flutter#186298) 2026-05-11 [email protected] [ci] update no-response workflow to also look for old label name in e… (flutter/flutter#186373) 2026-05-11 [email protected] [ImpellerC] Write a depfile when --shader-bundle is in use (flutter/flutter#186341) 2026-05-11 [email protected] docs: fix doubled-word typos in comments (flutter/flutter#186320) 2026-05-11 [email protected] Roll Skia from 32281401997e to 91d3c1e730af (4 revisions) (flutter/flutter#186368) 2026-05-11 [email protected] Show SwiftPM warnings right before iOS/macOS build (flutter/flutter#185984) 2026-05-11 [email protected] Convert rebuilding-flutter-tool script to dart (flutter/flutter#185089) 2026-05-11 [email protected] Use Xcode's LLDB (flutter/flutter#186273) 2026-05-11 [email protected] Remove `currentMainUri` from `generateMainDartWithPluginRegistrant` (flutter/flutter#185907) 2026-05-11 [email protected] Roll Skia from 2514f6b5f92b to 32281401997e (1 revision) (flutter/flutter#186349) 2026-05-11 [email protected] Roll Packages from 92552b1 to 19ec8b8 (4 revisions) (flutter/flutter#186350) 2026-05-11 [email protected] Check for absolute paths in skills. (flutter/flutter#185632) 2026-05-11 [email protected] Roll Skia from 9fb7d2814642 to 2514f6b5f92b (1 revision) (flutter/flutter#186347) 2026-05-11 [email protected] Roll Skia from 8cafb209e836 to 9fb7d2814642 (4 revisions) (flutter/flutter#186335) 2026-05-10 [email protected] Roll Fuchsia Linux SDK from sOBiPJb0xznDBZlf5... to rFhU-YPqdCRCtCz7b... (flutter/flutter#186328) 2026-05-10 [email protected] Roll Skia from 05a03f99c74e to 8cafb209e836 (1 revision) (flutter/flutter#186315) 2026-05-10 [email protected] [Impeller] Vulkan: don't drop user-supplied viewport X, Y, and depth range (flutter/flutter#185886) 2026-05-09 [email protected] Update Fuchsia tests to subpackage their child components (flutter/flutter#186259) 2026-05-09 [email protected] Fix SelectableText crash with inline lambda contextMenuBuilder (flutter/flutter#184990) 2026-05-09 [email protected] Roll Fuchsia Linux SDK from 5_TnhTsHSqtCx37o6... to sOBiPJb0xznDBZlf5... (flutter/flutter#186289) 2026-05-09 [email protected] Roll Skia from dc78d4bd2efb to 05a03f99c74e (2 revisions) (flutter/flutter#186283) 2026-05-09 [email protected] Improve non rect platform view rendering (flutter/flutter#182662) 2026-05-08 [email protected] Roll Skia from 31521f8508c7 to dc78d4bd2efb (1 revision) (flutter/flutter#186278) 2026-05-08 [email protected] Moves wide_gamut_macos to arm64 (flutter/flutter#186214) 2026-05-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Migrate VSyncClient to a pure Obj-C implementation (#186166)" (flutter/flutter#186266) 2026-05-08 [email protected] Roll Skia from a00db8749edb to 31521f8508c7 (2 revisions) (flutter/flutter#186264) 2026-05-08 [email protected] Optimize compatible `DrawDiffRoundRect` calls to use `DrawRoundRect` (flutter/flutter#186203) 2026-05-08 [email protected] [triage] Add Flutter GPU as a triage team (flutter/flutter#186263) 2026-05-08 [email protected] doc: Unified Check-Run User manual (flutter/flutter#186210) 2026-05-08 [email protected] Roll Skia from 5f7adf4403d6 to a00db8749edb (1 revision) (flutter/flutter#186257) 2026-05-08 [email protected] Roll Packages from 0411f1d to 92552b1 (1 revision) (flutter/flutter#186256) 2026-05-08 [email protected] Add logging to figure out jvm crashes for `hot_mode_tests` (flutter/flutter#186107) 2026-05-08 [email protected] Roll Skia from 926c09741ce2 to 5f7adf4403d6 (3 revisions) (flutter/flutter#186242) ...
Almost all if not all inital skill pull requests had paths in backticks that were relative to the root of the flutter directory because that is the style we use in our documentation. That style is bad for agents who want relative paths.
This adds a custom linter to check for paths that exist in backticks and match 2 segments of the root directory then fails validation. You can avoid the check by having any other prefix other than a string that is 2 folders from the top of flutter/flutter.
Additionally fix an example in my own authored skills.
AI assisted pr: antigravity, dragonally
Prompt was too interactive to post and have meaning.
Pre-launch Checklist
///).