Win32: Add FlutterDesktopPluginRegistrarGetGraphicsAdapter#185580
Merged
Conversation
github-actions
Bot
added
engine
knopp
added
CICD
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the GetGraphicsAdapter method to the Windows plugin registrar, enabling plugins to access the DXGI adapter used for rendering. The implementation includes updates to the public C API, the C++ client wrapper, and the testing framework. Feedback recommends adding a null check for the registrar in the C API, correcting a typo in a test name, and removing redundant expectations from the unit tests.
github-actions
Bot
added
engine
loic-sharma
reviewed
Apr 25, 2026
knopp
force-pushed
the
win_registrar_get_graphics_adapter
branch
from
1e4a4d1 to
6c84880
Compare
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#184479 has added
FlutterDesktopEngineGetGraphicsAdapter, but plugins don't have access to engine, only plugin registrar so there's no straightforward way for plugins to get the adapter. This PR fixes this by addingFlutterDesktopPluginRegistrarGetGraphicsAdapter.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.