Reland "[web] Fix LateInitializationError in CkSurface and SkwasmSurface (#185116)"#185553
Merged
auto-submit[bot] merged 1 commit intoApr 24, 2026
Merged
Conversation
…ace (flutter#185116)" This PR was originally affected by a GitHub incident where the merge queue included unintentional changes when merging the original PR. The PR was reverted, and now this is a reland now that the GitHub incident has been remediated.
github-actions
Bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the late modifier from _handledContextLostEvent in the CanvasKit and Skwasm surface implementations and exposes surfaceCreateFn in SurfaceProvider to facilitate testing. Additionally, a new test case and a mock canvas provider were added to handle synchronous context loss during surface creation. Feedback focuses on adhering to the Flutter style guide by adding documentation to private members and expanding the documentation for surfaceCreateFn to explain its purpose and usage in tests.
| final Completer<void> _initialized = Completer<void>(); | ||
|
|
||
| late Completer<void>? _handledContextLostEvent; | ||
| Completer<void>? _handledContextLostEvent; |
Contributor
There was a problem hiding this comment.
According to the Flutter style guide, all members (including private ones) should have documentation using ///. Please add a description for _handledContextLostEvent explaining its role in managing context loss events.
Suggested change
| Completer<void>? _handledContextLostEvent; | |
| /// A completer that tracks whether a context lost event is currently being | |
| /// handled. | |
| Completer<void>? _handledContextLostEvent; |
References
- Use /// for public-quality documentation, even on private members. (link)
| BitmapSize _currentSize = const BitmapSize(1, 1); | ||
| Completer<void> _initializedCompleter; | ||
| late Completer<void>? _handledContextLostEvent; | ||
| Completer<void>? _handledContextLostEvent; |
Contributor
There was a problem hiding this comment.
According to the Flutter style guide, all members (including private ones) should have documentation using ///. Please add a description for _handledContextLostEvent explaining its role in managing context loss events.
Suggested change
| Completer<void>? _handledContextLostEvent; | |
| /// A completer that tracks whether a context lost event is currently being | |
| /// handled. | |
| Completer<void>? _handledContextLostEvent; |
References
- Use /// for public-quality documentation, even on private members. (link)
Comment on lines
+22
to
+24
| /// A function that creates a new surface of type [C] using a [CanvasProvider] of type [D]. | ||
| @visibleForTesting | ||
| final C Function(D) surfaceCreateFn; |
Contributor
There was a problem hiding this comment.
The documentation for surfaceCreateFn should explain the 'why' and 'how' as per the style guide. It would be helpful to explicitly mention that this field is exposed to allow tests to inject mock providers for simulating edge cases like synchronous context loss.
Suggested change
| /// A function that creates a new surface of type [C] using a [CanvasProvider] of type [D]. | |
| @visibleForTesting | |
| final C Function(D) surfaceCreateFn; | |
| /// The function used to create new surfaces of type [C] using a [CanvasProvider] of type [D]. | |
| /// | |
| /// This is visible for testing so that tests can manually invoke it with | |
| /// mock providers to simulate edge cases like synchronous context loss. | |
| @visibleForTesting | |
| final C Function(D) surfaceCreateFn; |
References
- Documentation should be useful: Explain the why and the how. (link)
eyebrowsoffire
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Apr 25, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 28, 2026
…11595) Manual roll Flutter from 31001886cbe8 to 61fca76dd523 (53 revisions) Manual roll requested by [email protected] flutter/flutter@3100188...61fca76 2026-04-27 [email protected] Adds integration test for the FLTEnableSDFs flag for iOS (flutter/flutter#185637) 2026-04-27 [email protected] Fix sdfs being enabled for MacOS regardless of FLTEnableSDFs value (flutter/flutter#185565) 2026-04-27 [email protected] Don't use UberSDF for paint with incompatible blend modes (flutter/flutter#184889) 2026-04-27 [email protected] Roll Dart SDK from de495e3de9a0 to 941ca325cfc9 (2 revisions) (flutter/flutter#185653) 2026-04-27 [email protected] [a11y] Add CONTENT_CHANGE_TYPE_EXPANDED support on android. (flutter/flutter#185305) 2026-04-27 [email protected] Roll pub packages (flutter/flutter#185641) 2026-04-27 [email protected] Modify analyze.dart to have flags to run only or exclude each verification step. (flutter/flutter#185618) 2026-04-27 [email protected] Fix debugNeedsPaint/Layout/CompositedLayerUpdate crashing in release mode (flutter/flutter#184627) 2026-04-27 [email protected] Enable `var_with_no_type_annotation` lint. (flutter/flutter#185215) 2026-04-27 [email protected] Fix SelectionArea handles overlapping context menu on Android (flutter/flutter#182663) 2026-04-27 [email protected] Adds debugging information to compiled metal shaders (flutter/flutter#185629) 2026-04-27 [email protected] Roll pub packages (flutter/flutter#185638) 2026-04-27 [email protected] Use null-aware elements in dev/devicelab/lib/framework/browser.dart (flutter/flutter#184778) 2026-04-27 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185633) 2026-04-27 [email protected] Added useOriginalColors flag which allows ImageIcon to bypass IconTheme colorization and use the original colors (flutter/flutter#180491) 2026-04-27 [email protected] Roll Packages from 8400f71 to 23280da (2 revisions) (flutter/flutter#185619) 2026-04-27 [email protected] Roll Skia from f1238e0f1022 to ce82d32b3e03 (1 revision) (flutter/flutter#185616) 2026-04-27 [email protected] [SwiftPM] Enable package resolution on xcodebuild commands (flutter/flutter#185208) 2026-04-27 [email protected] [iOS] Refactor keyboard inset logic into FlutterKeyboardInsetManager (flutter/flutter#185535) 2026-04-27 [email protected] [Win32] FlutterDesktopEngineGetGraphicsAdapter should use out parameter (flutter/flutter#185590) 2026-04-27 [email protected] Roll Skia from d77e3356d526 to f1238e0f1022 (4 revisions) (flutter/flutter#185604) 2026-04-27 [email protected] Roll Fuchsia Linux SDK from flsn8jC4LkTn6WECf... to i6d0NoDueUiXpePfX... (flutter/flutter#185601) 2026-04-26 [email protected] Roll Dart SDK from a108dfe2d227 to de495e3de9a0 (1 revision) (flutter/flutter#185599) 2026-04-26 [email protected] Roll Skia from ce9aa2231292 to d77e3356d526 (1 revision) (flutter/flutter#185596) 2026-04-26 [email protected] Roll Skia from 622fff4c24d2 to ce9aa2231292 (1 revision) (flutter/flutter#185588) 2026-04-25 [email protected] Roll Fuchsia Linux SDK from 9fPnyEo9PaNdXtasl... to flsn8jC4LkTn6WECf... (flutter/flutter#185585) 2026-04-25 [email protected] Roll Dart SDK from 605a8faf0dda to a108dfe2d227 (1 revision) (flutter/flutter#185584) 2026-04-25 [email protected] Roll Dart SDK from 6b8c39765f17 to 605a8faf0dda (1 revision) (flutter/flutter#185578) 2026-04-25 [email protected] Roll Skia from 185f6b57d64f to 622fff4c24d2 (1 revision) (flutter/flutter#185573) 2026-04-25 [email protected] Implement square-like round superellipses with circular corners in the SDF uber shader (flutter/flutter#185370) 2026-04-25 [email protected] Add @awaitNotRequired annotation to flutter sdk (flutter/flutter#181513) 2026-04-25 [email protected] Roll Dart SDK from 01228cb7af42 to 6b8c39765f17 (2 revisions) (flutter/flutter#185569) 2026-04-25 [email protected] Adapt the DisplayList benchmarks into a primitive rendering benchmark suite (flutter/flutter#185270) 2026-04-25 [email protected] Enable SPM for GoogleMobileAds (flutter/flutter#185548) 2026-04-25 [email protected] Roll Skia from 3f467a581942 to 185f6b57d64f (1 revision) (flutter/flutter#185564) 2026-04-25 [email protected] Fix Table crash when a cell child paints below the row bottom (flutter/flutter#185323) 2026-04-24 [email protected] Make sure that an Image doesn't crash in 0x0 environment (flutter/flutter#181154) 2026-04-24 [email protected] Roll Skia from 300d432048b0 to 3f467a581942 (3 revisions) (flutter/flutter#185558) 2026-04-24 [email protected] Roll Dart SDK from c26627715892 to 01228cb7af42 (4 revisions) (flutter/flutter#185559) 2026-04-24 [email protected] Reland "[web] Fix LateInitializationError in CkSurface and SkwasmSurface (#185116)" (flutter/flutter#185553) 2026-04-24 [email protected] [github]fix git ls-file glob pattern in labeler.yml instruction (flutter/flutter#185495) 2026-04-24 [email protected] [ios]update ios-reviewers tags to include more files (flutter/flutter#185490) 2026-04-24 [email protected] Add initial support for Cross-Origin Storage (flutter/flutter#184149) 2026-04-24 [email protected] tool: Skip cached engine artifacts with local engine (flutter/flutter#185546) ...
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…lutter#11595) Manual roll Flutter from 31001886cbe8 to 61fca76dd523 (53 revisions) Manual roll requested by [email protected] flutter/flutter@3100188...61fca76 2026-04-27 [email protected] Adds integration test for the FLTEnableSDFs flag for iOS (flutter/flutter#185637) 2026-04-27 [email protected] Fix sdfs being enabled for MacOS regardless of FLTEnableSDFs value (flutter/flutter#185565) 2026-04-27 [email protected] Don't use UberSDF for paint with incompatible blend modes (flutter/flutter#184889) 2026-04-27 [email protected] Roll Dart SDK from de495e3de9a0 to 941ca325cfc9 (2 revisions) (flutter/flutter#185653) 2026-04-27 [email protected] [a11y] Add CONTENT_CHANGE_TYPE_EXPANDED support on android. (flutter/flutter#185305) 2026-04-27 [email protected] Roll pub packages (flutter/flutter#185641) 2026-04-27 [email protected] Modify analyze.dart to have flags to run only or exclude each verification step. (flutter/flutter#185618) 2026-04-27 [email protected] Fix debugNeedsPaint/Layout/CompositedLayerUpdate crashing in release mode (flutter/flutter#184627) 2026-04-27 [email protected] Enable `var_with_no_type_annotation` lint. (flutter/flutter#185215) 2026-04-27 [email protected] Fix SelectionArea handles overlapping context menu on Android (flutter/flutter#182663) 2026-04-27 [email protected] Adds debugging information to compiled metal shaders (flutter/flutter#185629) 2026-04-27 [email protected] Roll pub packages (flutter/flutter#185638) 2026-04-27 [email protected] Use null-aware elements in dev/devicelab/lib/framework/browser.dart (flutter/flutter#184778) 2026-04-27 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185633) 2026-04-27 [email protected] Added useOriginalColors flag which allows ImageIcon to bypass IconTheme colorization and use the original colors (flutter/flutter#180491) 2026-04-27 [email protected] Roll Packages from 8400f71 to 23280da (2 revisions) (flutter/flutter#185619) 2026-04-27 [email protected] Roll Skia from f1238e0f1022 to ce82d32b3e03 (1 revision) (flutter/flutter#185616) 2026-04-27 [email protected] [SwiftPM] Enable package resolution on xcodebuild commands (flutter/flutter#185208) 2026-04-27 [email protected] [iOS] Refactor keyboard inset logic into FlutterKeyboardInsetManager (flutter/flutter#185535) 2026-04-27 [email protected] [Win32] FlutterDesktopEngineGetGraphicsAdapter should use out parameter (flutter/flutter#185590) 2026-04-27 [email protected] Roll Skia from d77e3356d526 to f1238e0f1022 (4 revisions) (flutter/flutter#185604) 2026-04-27 [email protected] Roll Fuchsia Linux SDK from flsn8jC4LkTn6WECf... to i6d0NoDueUiXpePfX... (flutter/flutter#185601) 2026-04-26 [email protected] Roll Dart SDK from a108dfe2d227 to de495e3de9a0 (1 revision) (flutter/flutter#185599) 2026-04-26 [email protected] Roll Skia from ce9aa2231292 to d77e3356d526 (1 revision) (flutter/flutter#185596) 2026-04-26 [email protected] Roll Skia from 622fff4c24d2 to ce9aa2231292 (1 revision) (flutter/flutter#185588) 2026-04-25 [email protected] Roll Fuchsia Linux SDK from 9fPnyEo9PaNdXtasl... to flsn8jC4LkTn6WECf... (flutter/flutter#185585) 2026-04-25 [email protected] Roll Dart SDK from 605a8faf0dda to a108dfe2d227 (1 revision) (flutter/flutter#185584) 2026-04-25 [email protected] Roll Dart SDK from 6b8c39765f17 to 605a8faf0dda (1 revision) (flutter/flutter#185578) 2026-04-25 [email protected] Roll Skia from 185f6b57d64f to 622fff4c24d2 (1 revision) (flutter/flutter#185573) 2026-04-25 [email protected] Implement square-like round superellipses with circular corners in the SDF uber shader (flutter/flutter#185370) 2026-04-25 [email protected] Add @awaitNotRequired annotation to flutter sdk (flutter/flutter#181513) 2026-04-25 [email protected] Roll Dart SDK from 01228cb7af42 to 6b8c39765f17 (2 revisions) (flutter/flutter#185569) 2026-04-25 [email protected] Adapt the DisplayList benchmarks into a primitive rendering benchmark suite (flutter/flutter#185270) 2026-04-25 [email protected] Enable SPM for GoogleMobileAds (flutter/flutter#185548) 2026-04-25 [email protected] Roll Skia from 3f467a581942 to 185f6b57d64f (1 revision) (flutter/flutter#185564) 2026-04-25 [email protected] Fix Table crash when a cell child paints below the row bottom (flutter/flutter#185323) 2026-04-24 [email protected] Make sure that an Image doesn't crash in 0x0 environment (flutter/flutter#181154) 2026-04-24 [email protected] Roll Skia from 300d432048b0 to 3f467a581942 (3 revisions) (flutter/flutter#185558) 2026-04-24 [email protected] Roll Dart SDK from c26627715892 to 01228cb7af42 (4 revisions) (flutter/flutter#185559) 2026-04-24 [email protected] Reland "[web] Fix LateInitializationError in CkSurface and SkwasmSurface (#185116)" (flutter/flutter#185553) 2026-04-24 [email protected] [github]fix git ls-file glob pattern in labeler.yml instruction (flutter/flutter#185495) 2026-04-24 [email protected] [ios]update ios-reviewers tags to include more files (flutter/flutter#185490) 2026-04-24 [email protected] Add initial support for Cross-Origin Storage (flutter/flutter#184149) 2026-04-24 [email protected] tool: Skip cached engine artifacts with local engine (flutter/flutter#185546) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was originally affected by a GitHub incident where the merge queue included unintentional changes when merging the original PR. The PR was reverted, and now this is a reland now that the GitHub incident has been remediated.