[web, tool] Support recompiling shaders and unify asset processing by kevmoo · Pull Request #185534 · flutter/flutter

kevmoo · 2026-04-24T14:17:12Z

User-visible fixes:

Hot RESTART: should reload for all assets.
Hot RELOAD: should reload all assets EXCEPT shaders. Will need to do that in a follow-up.

Addresses SOME of #137265 (Images, JSON, Text, Data Files)

Extracted core asset sync logic (incremental checks, transformers, and
shader recompilation) into a shared static method DevFS.updateBundle.
This aligns the web asset path with other platforms and correctly
enables support for asset transformers during web hot reload/restart.

Previously, WebDevFS used a custom asset loop that bypassed the
transformer step and silently ignored shader compilation failures.

Changes:

Refactored DevFS.update to use the new DevFS.updateBundle helper.
Updated WebDevFS to leverage DevFS.updateBundle and LocalDevFSWriter.
Fixed a path resolution bug in WebDevFS where assets were resolving
to incorrect nested paths.
Added comprehensive tests in devfs_web_test.dart for shader
recompilation, asset transformers, and failure handling.
Ensured that shader compilation failures correctly report an update
failure in the FS report.

gemini-code-assist

Code Review

This pull request implements shader recompilation and eviction tracking within the web DevFS by updating the update method to process modified shader assets and configuring the shader compiler in ResidentWebRunner. Feedback suggests clearing the _shaderPathsToEvict set during updates to prevent accumulation, ensuring the logic handles initial bundle uploads, and extending the asset loop to process non-shader modified assets. Additionally, a suggestion was made to use asynchronous file writing to improve performance.

Extracted core asset sync logic (incremental checks, transformers, and shader recompilation) into a shared static method `DevFS.updateBundle`. This aligns the web asset path with other platforms and correctly enables support for asset transformers during web hot reload/restart. Previously, `WebDevFS` used a custom asset loop that bypassed the transformer step and silently ignored shader compilation failures. Changes: - Refactored `DevFS.update` to use the new `DevFS.updateBundle` helper. - Updated `WebDevFS` to leverage `DevFS.updateBundle` and `LocalDevFSWriter`. - Fixed a path resolution bug in `WebDevFS` where assets were resolving to incorrect nested paths. - Added comprehensive tests in `devfs_web_test.dart` for shader recompilation, asset transformers, and failure handling. - Ensured that shader compilation failures correctly report an update failure in the FS report. Fixed flutter#137265

kevmoo · 2026-04-25T01:28:57Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors asset bundle synchronization by extracting the logic into a static DevFS.updateBundle method, which is now utilized by both DevFS and WebDevFS. The changes enable shader recompilation and asset transformation for web platforms and include comprehensive tests for these scenarios. Review feedback identifies a race condition in the asynchronous processing of assets within updateBundle, where side effects in .then callbacks may not complete before the method returns.

Side effects like populating dirtyEntries and updating eviction sets are now performed directly within the awaited asynchronous closures to ensure they are complete before updateBundle returns.

kevmoo · 2026-04-25T02:50:41Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors asset synchronization by extracting the updateBundle logic into a static method in DevFS, allowing WebDevFS to share the implementation. It introduces DevelopmentAssetTransformer to the web runner, implements shader eviction for web, and adds regression tests for asset updates and race conditions. Feedback highlights a potential performance regression in asset skipping logic, an unused logger parameter, duplicated path normalization code, and non-idiomatic asynchronous closure patterns.

harryterkelsen

I also agree with all of the review comments from Gemini. This changes the logic for which assets to recompile on first hot reload. If it is really required to reprocess and bundle every asset on the first hot reload for web to work, we should change the tooling so web doesn't require that and have it work like the other platforms. We shouldn't change the logic for updateBundle

kevmoo · 2026-05-07T02:47:48Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors asset and shader processing by extracting logic into a shared static updateBundle method, enabling incremental asset updates for web platforms. Feedback identifies a high-severity null safety issue where entry.kind is treated as non-nullable, which could lead to runtime failures, and notes that the corresponding switch statement is no longer exhaustive.

kevmoo · 2026-05-07T03:00:07Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors asset and shader processing into a shared static method, DevFS.updateBundle, and integrates it into WebDevFS to support incremental updates. A regression was identified in the new updateBundle implementation where the switch statement on entry.kind misses the null case, which previously handled assets as regular assets.

kevmoo · 2026-05-07T03:04:38Z

@harryterkelsen – PTAL

harryterkelsen

This mostly LGTM but I have some nits

harryterkelsen

LGTM!

auto-submit · 2026-05-20T23:05:03Z

A reason for requesting a revert of flutter/flutter/185534 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

chunhtai · 2026-05-20T23:05:34Z

Reason for revert: cause test flakes

…essing (flutter#185534)" (flutter#186837)  Reverts: flutter#185534   Initiated by: chunhtai   Reason for reverting: cause test flakes   Original PR Author: kevmoo   Reviewed By: {harryterkelsen}   This change reverts the following previous change: User-visible fixes: - Hot RESTART: should reload for all assets. - Hot RELOAD: should reload all assets EXCEPT shaders. Will need to do that in a follow-up. Addresses SOME of flutter#137265 (Images, JSON, Text, Data Files) Extracted core asset sync logic (incremental checks, transformers, and shader recompilation) into a shared static method `DevFS.updateBundle`. This aligns the web asset path with other platforms and correctly enables support for asset transformers during web hot reload/restart. Previously, `WebDevFS` used a custom asset loop that bypassed the transformer step and silently ignored shader compilation failures. Changes: - Refactored `DevFS.update` to use the new `DevFS.updateBundle` helper. - Updated `WebDevFS` to leverage `DevFS.updateBundle` and `LocalDevFSWriter`. - Fixed a path resolution bug in `WebDevFS` where assets were resolving to incorrect nested paths. - Added comprehensive tests in `devfs_web_test.dart` for shader recompilation, asset transformers, and failure handling. - Ensured that shader compilation failures correctly report an update failure in the FS report.  Co-authored-by: auto-submit[bot] <[email protected]>

…lutter#185534) User-visible fixes: - Hot RESTART: should reload for all assets. - Hot RELOAD: should reload all assets EXCEPT shaders. Will need to do that in a follow-up. Addresses SOME of flutter#137265 (Images, JSON, Text, Data Files) Extracted core asset sync logic (incremental checks, transformers, and shader recompilation) into a shared static method `DevFS.updateBundle`. This aligns the web asset path with other platforms and correctly enables support for asset transformers during web hot reload/restart. Previously, `WebDevFS` used a custom asset loop that bypassed the transformer step and silently ignored shader compilation failures. Changes: - Refactored `DevFS.update` to use the new `DevFS.updateBundle` helper. - Updated `WebDevFS` to leverage `DevFS.updateBundle` and `LocalDevFSWriter`. - Fixed a path resolution bug in `WebDevFS` where assets were resolving to incorrect nested paths. - Added comprehensive tests in `devfs_web_test.dart` for shader recompilation, asset transformers, and failure handling. - Ensured that shader compilation failures correctly report an update failure in the FS report.

…essing (flutter#185534)" (flutter#186837)  Reverts: flutter#185534   Initiated by: chunhtai   Reason for reverting: cause test flakes   Original PR Author: kevmoo   Reviewed By: {harryterkelsen}   This change reverts the following previous change: User-visible fixes: - Hot RESTART: should reload for all assets. - Hot RELOAD: should reload all assets EXCEPT shaders. Will need to do that in a follow-up. Addresses SOME of flutter#137265 (Images, JSON, Text, Data Files) Extracted core asset sync logic (incremental checks, transformers, and shader recompilation) into a shared static method `DevFS.updateBundle`. This aligns the web asset path with other platforms and correctly enables support for asset transformers during web hot reload/restart. Previously, `WebDevFS` used a custom asset loop that bypassed the transformer step and silently ignored shader compilation failures. Changes: - Refactored `DevFS.update` to use the new `DevFS.updateBundle` helper. - Updated `WebDevFS` to leverage `DevFS.updateBundle` and `LocalDevFSWriter`. - Fixed a path resolution bug in `WebDevFS` where assets were resolving to incorrect nested paths. - Added comprehensive tests in `devfs_web_test.dart` for shader recompilation, asset transformers, and failure handling. - Ensured that shader compilation failures correctly report an update failure in the FS report.  Co-authored-by: auto-submit[bot] <[email protected]>

…nd try) (flutter#186902) This reverts commit 7ed7e21 Which reverted flutter@f15c3a3 Effectively re-lands flutter#185534 This brings back the shader compilation support and unified web asset syncing path which was previously reverted due to devicelab test flakes on Chrome. The flakes have been resolved by defensively handling DWDS unregistered service extension errors in the previous commit. Towards flutter#137265

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 24, 2026

gemini-code-assist Bot reviewed Apr 24, 2026

View reviewed changes

kevmoo force-pushed the web_shader_reload branch from a92263a to cbeae8d Compare April 24, 2026 16:51

kevmoo changed the title ~~[web, tool] Support recompiling shaders~~ [web, tool] Support reloading assets (including shaders) Apr 24, 2026

kevmoo force-pushed the web_shader_reload branch from cbeae8d to c4073d5 Compare April 25, 2026 01:28

kevmoo changed the title ~~[web, tool] Support reloading assets (including shaders)~~ [web, tool] Support recompiling shaders and unify asset processing Apr 25, 2026

gemini-code-assist Bot reviewed Apr 25, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/devfs.dart Outdated

Comment thread packages/flutter_tools/lib/src/devfs.dart Outdated

Fix race condition in updateBundle and add regression test

7a8ebf8

Side effects like populating dirtyEntries and updating eviction sets are now performed directly within the awaited asynchronous closures to ensure they are complete before updateBundle returns.

gemini-code-assist Bot reviewed Apr 25, 2026

View reviewed changes

harryterkelsen requested changes Apr 27, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/isolated/devfs_web.dart Outdated

Merge remote-tracking branch 'origin/HEAD' into web_shader_reload

078b92a

flutter-dashboard Bot added the CICD Run CI/CD label May 7, 2026

kevmoo added 2 commits May 6, 2026 19:32

fix things

2cc5fbb

review nits

f3ad12d

github-actions Bot removed the CICD Run CI/CD label May 7, 2026

Merge remote-tracking branch 'origin/HEAD' into web_shader_reload

f116f96

flutter-dashboard Bot added the CICD Run CI/CD label May 7, 2026

gemini-code-assist Bot reviewed May 7, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/devfs.dart Outdated

Comment thread packages/flutter_tools/lib/src/devfs.dart Outdated

nits

b091df5

github-actions Bot removed the CICD Run CI/CD label May 7, 2026

gemini-code-assist Bot reviewed May 7, 2026

View reviewed changes

Comment thread packages/flutter_tools/lib/src/devfs.dart

kevmoo requested a review from harryterkelsen May 7, 2026 16:10

harryterkelsen requested changes May 7, 2026

View reviewed changes

review nits

7ff6886

harryterkelsen added the CICD Run CI/CD label May 20, 2026

harryterkelsen self-requested a review May 20, 2026 17:45

harryterkelsen approved these changes May 20, 2026

View reviewed changes

auto-submit Bot added this pull request to the merge queue May 20, 2026

Merged via the queue into flutter:master with commit f15c3a3 May 20, 2026
161 of 162 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2026

kevmoo deleted the web_shader_reload branch May 20, 2026 21:49

chunhtai added the revert Autorevert PR (with "Reason for revert:" comment) label May 20, 2026

auto-submit Bot removed the revert Autorevert PR (with "Reason for revert:" comment) label May 20, 2026

chunhtai added the revert Autorevert PR (with "Reason for revert:" comment) label May 20, 2026

auto-submit Bot mentioned this pull request May 20, 2026

Reverts "[web, tool] Support recompiling shaders and unify asset processing (#185534)" #186837

Merged

auto-submit Bot removed the revert Autorevert PR (with "Reason for revert:" comment) label May 20, 2026

kevmoo mentioned this pull request May 21, 2026

[web, tool] Support recompiling shaders and unify asset processing (2nd try) #186902

Merged

Conversation

kevmoo commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevmoo commented Apr 25, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

kevmoo commented Apr 25, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harryterkelsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kevmoo commented May 7, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

kevmoo commented May 7, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

kevmoo commented May 7, 2026

Uh oh!

harryterkelsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

harryterkelsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit Bot commented May 20, 2026

Uh oh!

chunhtai commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kevmoo commented Apr 24, 2026 •

edited

Loading