Testing autosubmit bot -- updating testowners by gaaclarke · Pull Request #185226 · flutter/flutter

gaaclarke · 2026-04-17T23:25:57Z

Testing for #185224

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gaaclarke · 2026-04-17T23:26:26Z

@b-luk can you do a "request changes" review please?

gemini-code-assist

Code Review

This pull request updates the TESTOWNERS file to reassign the animated_complex_opacity_perf_macos__e2e_summary.dart test from @cbracken to @b-luk. I have no feedback to provide.

b-luk

Changes, please!

b-luk · 2026-04-17T23:33:51Z

I approve this next, and then you push another commit afterwards. Right?

gaaclarke · 2026-04-17T23:45:10Z

I approve this next, and then you push another commit afterwards. Right?

yea, please approve @b-luk

gaaclarke · 2026-04-17T23:47:00Z

I approve this next, and then you push another commit afterwards. Right?

Next steps are:

@b-luk approves
@gaaclarke pushes a new commit
@codefu approves
autosubmit label is added

b-luk

LGTM

b-luk · 2026-04-17T23:55:49Z

Here's gh pr view https://github.com/flutter/flutter/pull/185226 --json reviews after my approval:

{
  "reviews": [
    {
      "id": "PRR_kwDOAeUeuM72VMco",
      "author": {
        "login": "gemini-code-assist"
      },
      "authorAssociation": "CONTRIBUTOR",
      "body": "## Code Review\n\nThis pull request updates the TESTOWNERS file to reassign the animated_complex_opacity_perf_macos__e2e_summary.dart test from @cbracken to @b-luk. I have no feedback to provide.",
      "submittedAt": "2026-04-17T23:26:48Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "COMMENTED",
      "commit": {
        "oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
      }
    },
    {
      "id": "PRR_kwDOAeUeuM72VRWb",
      "author": {
        "login": "b-luk"
      },
      "authorAssociation": "MEMBER",
      "body": "Changes, please!",
      "submittedAt": "2026-04-17T23:30:43Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "CHANGES_REQUESTED",
      "commit": {
        "oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
      }
    },
    {
      "id": "PRR_kwDOAeUeuM72Vnke",
      "author": {
        "login": "b-luk"
      },
      "authorAssociation": "MEMBER",
      "body": "LGTM",
      "submittedAt": "2026-04-17T23:48:59Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "APPROVED",
      "commit": {
        "oid": "1a6b1c8e2084fb9727231a97c7e157eb86faa165"
      }
    }
  ]
}

And after the new commit:

{
  "reviews": [
    {
      "id": "PRR_kwDOAeUeuM72VMco",
      "author": {
        "login": "gemini-code-assist"
      },
      "authorAssociation": "CONTRIBUTOR",
      "body": "## Code Review\n\nThis pull request updates the TESTOWNERS file to reassign the animated_complex_opacity_perf_macos__e2e_summary.dart test from @cbracken to @b-luk. I have no feedback to provide.",
      "submittedAt": "2026-04-17T23:26:48Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "COMMENTED",
      "commit": {
        "oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
      }
    },
    {
      "id": "PRR_kwDOAeUeuM72VRWb",
      "author": {
        "login": "b-luk"
      },
      "authorAssociation": "MEMBER",
      "body": "Changes, please!",
      "submittedAt": "2026-04-17T23:30:43Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "CHANGES_REQUESTED",
      "commit": {
        "oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
      }
    },
    {
      "id": "PRR_kwDOAeUeuM72Vnke",
      "author": {
        "login": "b-luk"
      },
      "authorAssociation": "MEMBER",
      "body": "LGTM",
      "submittedAt": "2026-04-17T23:48:59Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "DISMISSED",
      "commit": {
        "oid": "1a6b1c8e2084fb9727231a97c7e157eb86faa165"
      }
    }
  ]
}

So there's a "CHANGES_REQUESTED" entry remaining from me, and the approved review went from "APPROVED" to "DISMISSED".

The reviewer list in the Github UI does not show "changes requested" for me:

b-luk · 2026-04-18T00:00:41Z

State after jtmcdole's approval:

{
  "reviews": [
    {
      "id": "PRR_kwDOAeUeuM72VMco",
      "author": {
        "login": "gemini-code-assist"
      },
      "authorAssociation": "CONTRIBUTOR",
      "body": "## Code Review\n\nThis pull request updates the TESTOWNERS file to reassign the animated_complex_opacity_perf_macos__e2e_summary.dart test from @cbracken to @b-luk. I have no feedback to provide.",
      "submittedAt": "2026-04-17T23:26:48Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "COMMENTED",
      "commit": {
        "oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
      }
    },
    {
      "id": "PRR_kwDOAeUeuM72VRWb",
      "author": {
        "login": "b-luk"
      },
      "authorAssociation": "MEMBER",
      "body": "Changes, please!",
      "submittedAt": "2026-04-17T23:30:43Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "CHANGES_REQUESTED",
      "commit": {
        "oid": "ec6bd85a2a031805ee2493d9c835e5ef282dce9a"
      }
    },
    {
      "id": "PRR_kwDOAeUeuM72Vnke",
      "author": {
        "login": "b-luk"
      },
      "authorAssociation": "MEMBER",
      "body": "LGTM",
      "submittedAt": "2026-04-17T23:48:59Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "DISMISSED",
      "commit": {
        "oid": "1a6b1c8e2084fb9727231a97c7e157eb86faa165"
      }
    },
    {
      "id": "PRR_kwDOAeUeuM72Vxya",
      "author": {
        "login": "jtmcdole"
      },
      "authorAssociation": "MEMBER",
      "body": "",
      "submittedAt": "2026-04-17T23:58:42Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "APPROVED",
      "commit": {
        "oid": "922af58a8241953028a960c9697128ebc536e5f6"
      }
    }
  ]
}

auto-submit · 2026-04-18T00:01:07Z

autosubmit label was removed for flutter/flutter/185226, because This PR has not met approval requirements for merging. Changes were requested by {b-luk}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

cbracken · 2026-04-21T05:54:12Z

-/dev/devicelab/bin/tasks/animated_complex_opacity_perf_macos__e2e_summary.dart @cbracken @flutter/desktop
-/dev/devicelab/bin/tasks/basic_material_app_macos__compile.dart @cbracken @flutter/desktop
+/dev/devicelab/bin/tasks/animated_complex_opacity_perf_macos__e2e_summary.dart @loic-sharma @flutter/desktop
+/dev/devicelab/bin/tasks/basic_material_app_macos__compile.dart @loic-sharma @flutter/desktop


/me waves farewell to animated_complex_opacity_perf_macos__e2e_summary.dart and basic_material_app_macos__compile.dart. We had a good run, didn't we? 🥲

gaaclarke · 2026-05-15T18:30:48Z

This was just a test PR for an infra issue, but it's still a good change so i'll attempt to land it.

auto-submit · 2026-05-15T22:41:52Z

auto label is removed for flutter/flutter/185226, Failed to enqueue flutter/flutter/185226 with HTTP 400: Pull request Required status check "Merge Queue Guard" is expected..

flutter/flutter@3598686...259aeae 2026-05-19 [email protected] Roll Skia from 967ddb1aa561 to f1b406860c5e (2 revisions) (flutter/flutter#186731) 2026-05-19 [email protected] Roll Fuchsia Linux SDK from 5Ki-dBY4SpWdQMF_3... to -F9Ci3Opxt06MixDl... (flutter/flutter#186727) 2026-05-19 [email protected] Remove unused field in `ResourceExtractor` (flutter/flutter#186629) 2026-05-19 [email protected] Update Fuchsia tests to use realm_builder_server as a subpackage (flutter/flutter#186409) 2026-05-19 [email protected] Roll Skia from cebf49d034b8 to 967ddb1aa561 (4 revisions) (flutter/flutter#186720) 2026-05-19 [email protected] Roll pub packages (flutter/flutter#186721) 2026-05-19 [email protected] [macOS][gn] support both x64/arm64 macOS host clang toolchains for ASAN (flutter/flutter#186669) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in generate_coverage.py on arm64 Macs (flutter/flutter#186662) 2026-05-19 [email protected] Fix broken link in impeller golden_tests readme (flutter/flutter#186470) 2026-05-19 [email protected] Roll Skia from 27f7bba22600 to cebf49d034b8 (37 revisions) (flutter/flutter#186699) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in verify_exported.dart on arm64 Macs (flutter/flutter#186664) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in sanitizer_suppressions.sh on arm64 Macs (flutter/flutter#186663) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in copy_info_plist.py on arm64 Macs (flutter/flutter#186661) 2026-05-19 [email protected] Complete completer only once in hot restart tests (flutter/flutter#186702) 2026-05-18 [email protected] Testing autosubmit bot -- updating testowners (flutter/flutter#185226) 2026-05-18 [email protected] [ios] Correct handling for CADisplayLink paused-to-unpaused transitions (flutter/flutter#186457) 2026-05-18 [email protected] [Android][macOS][gn] support both x64/arm64 macOS host clang toolchains (flutter/flutter#186660) 2026-05-18 [email protected] Roll Packages from 32c84d6 to b9bdd37 (2 revisions) (flutter/flutter#186683) 2026-05-18 [email protected] [AGP 9] Upgrade Flutter Test Apps to AGP 9 (flutter/flutter#186200) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#11737) flutter/flutter@3598686...259aeae 2026-05-19 [email protected] Roll Skia from 967ddb1aa561 to f1b406860c5e (2 revisions) (flutter/flutter#186731) 2026-05-19 [email protected] Roll Fuchsia Linux SDK from 5Ki-dBY4SpWdQMF_3... to -F9Ci3Opxt06MixDl... (flutter/flutter#186727) 2026-05-19 [email protected] Remove unused field in `ResourceExtractor` (flutter/flutter#186629) 2026-05-19 [email protected] Update Fuchsia tests to use realm_builder_server as a subpackage (flutter/flutter#186409) 2026-05-19 [email protected] Roll Skia from cebf49d034b8 to 967ddb1aa561 (4 revisions) (flutter/flutter#186720) 2026-05-19 [email protected] Roll pub packages (flutter/flutter#186721) 2026-05-19 [email protected] [macOS][gn] support both x64/arm64 macOS host clang toolchains for ASAN (flutter/flutter#186669) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in generate_coverage.py on arm64 Macs (flutter/flutter#186662) 2026-05-19 [email protected] Fix broken link in impeller golden_tests readme (flutter/flutter#186470) 2026-05-19 [email protected] Roll Skia from 27f7bba22600 to cebf49d034b8 (37 revisions) (flutter/flutter#186699) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in verify_exported.dart on arm64 Macs (flutter/flutter#186664) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in sanitizer_suppressions.sh on arm64 Macs (flutter/flutter#186663) 2026-05-19 [email protected] [macOS][gn] Use arm64 clang in copy_info_plist.py on arm64 Macs (flutter/flutter#186661) 2026-05-19 [email protected] Complete completer only once in hot restart tests (flutter/flutter#186702) 2026-05-18 [email protected] Testing autosubmit bot -- updating testowners (flutter/flutter#185226) 2026-05-18 [email protected] [ios] Correct handling for CADisplayLink paused-to-unpaused transitions (flutter/flutter#186457) 2026-05-18 [email protected] [Android][macOS][gn] support both x64/arm64 macOS host clang toolchains (flutter/flutter#186660) 2026-05-18 [email protected] Roll Packages from 32c84d6 to b9bdd37 (2 revisions) (flutter/flutter#186683) 2026-05-18 [email protected] [AGP 9] Upgrade Flutter Test Apps to AGP 9 (flutter/flutter#186200) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Testing autosubmit bot -- updating testowners

ec6bd85

gaaclarke requested a review from b-luk April 17, 2026 23:26

gemini-code-assist Bot reviewed Apr 17, 2026

View reviewed changes

b-luk requested changes Apr 17, 2026

View reviewed changes

switched to loic

1a6b1c8

gaaclarke requested a review from b-luk April 17, 2026 23:45

b-luk previously approved these changes Apr 17, 2026

View reviewed changes

added another loic

922af58

gaaclarke dismissed b-luk’s stale review via 922af58 April 17, 2026 23:51

gaaclarke requested a review from jtmcdole April 17, 2026 23:52

jtmcdole approved these changes Apr 17, 2026

View reviewed changes

gaaclarke added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Apr 17, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2026

gaaclarke mentioned this pull request Apr 18, 2026

autosubmit blocks merging on stale "request changes" pr #185224

Closed

b-luk mentioned this pull request Apr 20, 2026

Made it so dismissed approvals don't block the autosubmit bot. flutter/cocoon#5025

Merged

8 tasks

Piinks added the team-infra Owned by Infrastructure team label Apr 20, 2026

cbracken reviewed Apr 21, 2026

View reviewed changes

cbracken approved these changes Apr 21, 2026

View reviewed changes

Merge branch 'master' into autosubmit-test

229c8ce

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2026

github-actions Bot removed the team-infra Owned by Infrastructure team label May 15, 2026

github-actions Bot removed the CICD Run CI/CD label May 15, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2026

Merge branch 'master' into autosubmit-test

356172b

flutter-dashboard Bot added the CICD Run CI/CD label May 18, 2026

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label May 18, 2026

auto-submit Bot added this pull request to the merge queue May 18, 2026

Merged via the queue into flutter:master with commit 9731852 May 19, 2026
58 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2026

engine-flutter-autoroll mentioned this pull request May 19, 2026

Roll Flutter from 3598686e42e3 to 259aeae0e0ba (19 revisions) flutter/packages#11737

Merged

Uh oh!

Conversation

gaaclarke commented Apr 17, 2026

Pre-launch Checklist

Uh oh!

gaaclarke commented Apr 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

b-luk left a comment

Choose a reason for hiding this comment

Uh oh!

b-luk commented Apr 17, 2026

Uh oh!

gaaclarke commented Apr 17, 2026

Uh oh!

gaaclarke commented Apr 17, 2026

Uh oh!

b-luk left a comment

Choose a reason for hiding this comment

Uh oh!

b-luk commented Apr 17, 2026

Uh oh!

b-luk commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auto-submit Bot commented Apr 18, 2026

Uh oh!

cbracken Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented May 15, 2026

Uh oh!

auto-submit Bot commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

b-luk commented Apr 18, 2026 •

edited

Loading

cbracken Apr 21, 2026 •

edited

Loading