Skip to content

Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)"#185203

Merged
cbracken merged 1 commit into
masterfrom
revert_ed9f5d7415e54b94fa11193de1dcf79007344415
Apr 17, 2026
Merged

Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)"#185203
cbracken merged 1 commit into
masterfrom
revert_ed9f5d7415e54b94fa11193de1dcf79007344415

Conversation

@auto-submit

@auto-submit auto-submit Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Reverts: #184643

Initiated by: cbracken

Reason for reverting: tests added are order dependent and break depending on random seed.

Original PR Author: Istiak-Ahmed78

Reviewed By: {justinmc, QuncCccccc, chunhtai, Piinks}

This change reverts the following previous change:
Fixes a bug in ImageInfo.isCloneOf where the scale property was being compared to itself (scale == scale) instead of comparing against the other object's scale (other.scale == scale). This caused the method to always return true for scale comparisons, incorrectly identifying ImageInfo objects with different scales as clones.

Root Cause

In packages/flutter/lib/src/painting/image_stream.dart, line 104:

// Before (bug)
return other.image.isCloneOf(image) && scale == scale && other.debugLabel == debugLabel;

// After (fix)
return other.image.isCloneOf(image) && other.scale == scale && other.debugLabel == debugLabel;

The scale == scale comparison is a typo that always evaluates to true, making the scale check ineffective.

Impact

This bug could cause:

  • Images not repainting when their scale changes
  • Incorrect caching behavior in ImageCache
  • Visual bugs where images render at wrong sizes
  • RawImage and DecorationImage widgets skipping necessary repaints

Tests

Added two regression tests to packages/flutter/test/painting/image_stream_test.dart:

  1. ImageInfo.isCloneOf returns false when scales differ - verifies the fix
  2. ImageInfo.isCloneOf returns true when all properties match - verifies correct behavior

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I added/updated tests for this change.
  • I used self-descriptive commit messages.

Fixes #184626

@auto-submit auto-submit Bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Apr 17, 2026
@github-actions github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 17, 2026
@cbracken cbracken added CICD Run CI/CD emergency Jump the queue; land PR in front of all others; only use for emergencies labels Apr 17, 2026
@flutter-dashboard

flutter-dashboard Bot commented Apr 17, 2026

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@cbracken
cbracken enabled auto-merge April 17, 2026 11:58
@cbracken
cbracken added this pull request to the merge queue Apr 17, 2026
@auto-submit auto-submit Bot removed the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Apr 17, 2026
@auto-submit

auto-submit Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

auto label is removed for flutter/flutter/185203, Failed to enqueue flutter/flutter/185203 with HTTP 400: Pull request is already in the queue.

Merged via the queue into master with commit 8e8a194 Apr 17, 2026
27 of 28 checks passed
@cbracken
cbracken deleted the revert_ed9f5d7415e54b94fa11193de1dcf79007344415 branch April 17, 2026 12:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2026
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2026
@engine-flutter-autoroll
8e8a19492 Reverts "Fix ImageInfo.isCloneOf to correctly compare scale…
401c196 
… values (fixes #184626) (#184643)" (flutter/flutter#185203)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 17, 2026
@engine-flutter-autoroll
Roll Flutter from 31f1802cb859 to 8e8a194923dc (22 revisions) (#11523)
2060cd3 
flutter/flutter@31f1802...8e8a194

2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203)
2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199)
2026-04-17 [email protected] [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151)
2026-04-17 [email protected] Remove unused `FlutterRunArguments.java` file  (flutter/flutter#184160)
2026-04-17 [email protected] Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192)
2026-04-17 [email protected] [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913)
2026-04-17 [email protected] `AnimationStyle` methods (flutter/flutter#182333)
2026-04-17 [email protected] Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332)
2026-04-17 [email protected] Revert "Unpin sdk package dependencies" (flutter/flutter#185186)
2026-04-16 [email protected] Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995)
2026-04-16 [email protected] Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173)
2026-04-16 [email protected] Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033)
2026-04-16 [email protected] [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112)
2026-04-16 [email protected] Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159)
2026-04-16 [email protected] [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051)
2026-04-16 [email protected] [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991)
2026-04-16 [email protected] Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143)
2026-04-16 [email protected] Unpin sdk package dependencies (flutter/flutter#184821)
2026-04-16 [email protected] Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643)
2026-04-16 [email protected] Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141)
2026-04-16 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185166)
2026-04-16 [email protected] Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Istiak-Ahmed78 added a commit to Istiak-Ahmed78/flutter that referenced this pull request Apr 19, 2026
@Istiak-Ahmed78
Revert "Reverts "Fix ImageInfo.isCloneOf to correctly compare scale v…
824e98f 
…alues (fixes flutter#184626) (flutter#184643)" (flutter#185203)"

This reverts commit 8e8a194.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 31f1802cb859 to 8e8a194923dc (22 revisions) (flutte…
0bc2767 
…r#11523)

flutter/flutter@31f1802...8e8a194

2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203)
2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199)
2026-04-17 [email protected] [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151)
2026-04-17 [email protected] Remove unused `FlutterRunArguments.java` file  (flutter/flutter#184160)
2026-04-17 [email protected] Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192)
2026-04-17 [email protected] [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913)
2026-04-17 [email protected] `AnimationStyle` methods (flutter/flutter#182333)
2026-04-17 [email protected] Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332)
2026-04-17 [email protected] Revert "Unpin sdk package dependencies" (flutter/flutter#185186)
2026-04-16 [email protected] Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995)
2026-04-16 [email protected] Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173)
2026-04-16 [email protected] Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033)
2026-04-16 [email protected] [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112)
2026-04-16 [email protected] Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159)
2026-04-16 [email protected] [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051)
2026-04-16 [email protected] [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991)
2026-04-16 [email protected] Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143)
2026-04-16 [email protected] Unpin sdk package dependencies (flutter/flutter#184821)
2026-04-16 [email protected] Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643)
2026-04-16 [email protected] Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141)
2026-04-16 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185166)
2026-04-16 [email protected] Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@cbracken cbracken

Labels

CICD Run CI/CD emergency Jump the queue; land PR in front of all others; only use for emergencies framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong scale comparison in ImageInfo.isCloneOf

2 participants

@fluttergithubbot @cbracken