Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors by reidbaker · Pull Request #185033 · flutter/flutter

reidbaker · 2026-04-14T15:59:29Z

Add a static analysis linter for skills authors in flutter/flutter

I want to call out that this is adding a dependency on repo we control but is not yet available in pub.dev.

Update deps also had me fix an build error caused by updating build_runner.

Pre-launch Checklist

gemini-code-assist

Code Review

This pull request adds documentation for validating skills and introduces an automated validation test using the dart_skills_lint package. The review feedback suggests pinning the git dependency to a specific commit hash to ensure deterministic builds and improving test isolation by restoring the global logger level after the test completes.

reidbaker · 2026-04-14T19:40:49Z

Test failures appear to be from tip of tree. Will wait until the tree is green the sync and rerun cicd.

jtmcdole · 2026-04-14T23:30:35Z

There's a license missing:

The following file does not have the right license header for dart files:
  /b/s/w/ir/x/w/flutter/dev/tools/test/validate_skills_test.dart
The expected license header is:
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

and the tools tests are failing

bkonyi · 2026-04-16T15:56:37Z

  url_launcher: any
  web: any
  webview_flutter: any
+  async: any


This change doesn't look like it was intended, or was it?

bad merge resolution that was required because head was broken. Fixed now.

bkonyi · 2026-04-16T16:05:24Z

I don't think we need to upgrade versions in the pubspecs to add the git dependency. If you revert those changes and run flutter update-packages --update-hashes that should be enough.

reidbaker · 2026-04-16T19:25:40Z

I don't think we need to upgrade versions in the pubspecs to add the git dependency. If you revert those changes and run flutter update-packages --update-hashes that should be enough.

FWIW I ran flutter update-packages because the test that failed lock file checking said that was the command to run. PR now only uses --update-hashes

…e instructions for new skills authors (flutter/flutter#185033)

flutter/flutter@31f1802...8e8a194 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203) 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199) 2026-04-17 [email protected] [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151) 2026-04-17 [email protected] Remove unused `FlutterRunArguments.java` file (flutter/flutter#184160) 2026-04-17 [email protected] Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192) 2026-04-17 [email protected] [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913) 2026-04-17 [email protected] `AnimationStyle` methods (flutter/flutter#182333) 2026-04-17 [email protected] Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332) 2026-04-17 [email protected] Revert "Unpin sdk package dependencies" (flutter/flutter#185186) 2026-04-16 [email protected] Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995) 2026-04-16 [email protected] Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173) 2026-04-16 [email protected] Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033) 2026-04-16 [email protected] [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112) 2026-04-16 [email protected] Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159) 2026-04-16 [email protected] [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051) 2026-04-16 [email protected] [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991) 2026-04-16 [email protected] Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143) 2026-04-16 [email protected] Unpin sdk package dependencies (flutter/flutter#184821) 2026-04-16 [email protected] Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643) 2026-04-16 [email protected] Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141) 2026-04-16 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185166) 2026-04-16 [email protected] Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@Directory

Add linting to skills repo and fix one skill that used _ instead of kebab case as is defined in the spec https://agentskills.io/specification#name-field. This is similar to the prs to add linting to flutter skills in flutter/flutter#185033 and dev/tool flutter/devtools#9770 AI Assisted pr: antigravity, dragonally Prompt: """ use the skill in /Users/reidbaker/Documents/flutter-skills/tool/dart_skills_lint/skills/dart-skills-lint-validation/SKILL.md to add a test to [dash_site](directory;file:///Users/reidbaker/Documents/dart-lang-site-www/tool/dash_site)/test that validates the skills in @Directory:agents/skills """ --- - [ ] I’ve reviewed the contributor guide and applied the relevant portions to this PR. - [x] This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/site-www/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Code changes should generally follow the [Dart style guide](https://dart.dev/effective-dart) and use `dart format`. - Updates to [code excerpts](https://github.com/dart-lang/site-shared/blob/main/packages/excerpter) indicated by `<?code-excerpt` need to be updated in their source `.dart` file as well. </details>

…r#11523) flutter/flutter@31f1802...8e8a194 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203) 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199) 2026-04-17 [email protected] [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151) 2026-04-17 [email protected] Remove unused `FlutterRunArguments.java` file (flutter/flutter#184160) 2026-04-17 [email protected] Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192) 2026-04-17 [email protected] [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913) 2026-04-17 [email protected] `AnimationStyle` methods (flutter/flutter#182333) 2026-04-17 [email protected] Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332) 2026-04-17 [email protected] Revert "Unpin sdk package dependencies" (flutter/flutter#185186) 2026-04-16 [email protected] Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995) 2026-04-16 [email protected] Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173) 2026-04-16 [email protected] Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033) 2026-04-16 [email protected] [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112) 2026-04-16 [email protected] Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159) 2026-04-16 [email protected] [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051) 2026-04-16 [email protected] [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991) 2026-04-16 [email protected] Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143) 2026-04-16 [email protected] Unpin sdk package dependencies (flutter/flutter#184821) 2026-04-16 [email protected] Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643) 2026-04-16 [email protected] Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141) 2026-04-16 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185166) 2026-04-16 [email protected] Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

reidbaker requested a review from jtmcdole as a code owner April 14, 2026 15:59

reidbaker requested a review from bkonyi April 14, 2026 15:59

gemini-code-assist Bot reviewed Apr 14, 2026

View reviewed changes

Comment thread dev/tools/pubspec.yaml

Comment thread dev/tools/test/validate_skills_test.dart

Comment thread dev/tools/test/validate_skills_test.dart

bkonyi previously approved these changes Apr 14, 2026

View reviewed changes

jtmcdole previously approved these changes Apr 14, 2026

View reviewed changes

Comment thread .agents/skills/README.md

reidbaker added the CICD Run CI/CD label Apr 14, 2026

reidbaker dismissed stale reviews from jtmcdole and bkonyi via 9de965f April 14, 2026 19:29

github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. CICD Run CI/CD and removed CICD Run CI/CD labels Apr 14, 2026

github-actions Bot removed the CICD Run CI/CD label Apr 14, 2026

reidbaker added the CICD Run CI/CD label Apr 14, 2026

github-actions Bot removed the CICD Run CI/CD label Apr 15, 2026

reidbaker added the CICD Run CI/CD label Apr 15, 2026

reidbaker requested review from bkonyi and jtmcdole April 15, 2026 15:14

github-actions Bot removed the CICD Run CI/CD label Apr 16, 2026

reidbaker added the CICD Run CI/CD label Apr 16, 2026

reidbaker mentioned this pull request Apr 16, 2026

Add documentation for overarching tests in flutter, add skill to help agents figure out where tests go #185148

Merged

10 tasks

github-actions Bot removed the CICD Run CI/CD label Apr 16, 2026

reidbaker added the CICD Run CI/CD label Apr 16, 2026

bkonyi reviewed Apr 16, 2026

View reviewed changes

reidbaker force-pushed the r-lint-flutter-flutter-skills branch from 33f503d to 9749e1e Compare April 16, 2026 19:23

github-actions Bot removed tool Affects the "flutter" command-line tool. See also t: labels. CICD Run CI/CD labels Apr 16, 2026

reidbaker requested a review from bkonyi April 16, 2026 19:24

reidbaker added the CICD Run CI/CD label Apr 16, 2026

Add test for skills repo and update readme instructions

0c3d241

reidbaker force-pushed the r-lint-flutter-flutter-skills branch from 9749e1e to 0c3d241 Compare April 16, 2026 21:25

github-actions Bot removed the CICD Run CI/CD label Apr 16, 2026

reidbaker added the CICD Run CI/CD label Apr 16, 2026

reidbaker mentioned this pull request Apr 16, 2026

Improve skill for using dart_skills_lint flutter/agent-plugins#86

Merged

8 tasks

jtmcdole approved these changes Apr 16, 2026

View reviewed changes

jtmcdole added this pull request to the merge queue Apr 16, 2026

Merged via the queue into flutter:master with commit 3d6ef4e Apr 17, 2026
161 of 162 checks passed

engine-flutter-autoroll mentioned this pull request Apr 17, 2026

Roll Flutter from 31f1802cb859 to 8e8a194923dc (22 revisions) flutter/packages#11523

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2026

3d6ef4ea1 Add dart_skills_lint to dev/tool with test and update readm…

15142e8

…e instructions for new skills authors (flutter/flutter#185033)

reidbaker deleted the r-lint-flutter-flutter-skills branch April 17, 2026 18:53

reidbaker mentioned this pull request Apr 27, 2026

Add skills linting as part of the test suite dart-lang/site-www#7264

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors#185033

Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors#185033
jtmcdole merged 1 commit into
flutter:masterfrom
reidbaker:r-lint-flutter-flutter-skills

reidbaker commented Apr 14, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker commented Apr 14, 2026

Uh oh!

jtmcdole commented Apr 14, 2026

Uh oh!

bkonyi Apr 16, 2026

Uh oh!

reidbaker Apr 16, 2026

Uh oh!

bkonyi commented Apr 16, 2026

Uh oh!

reidbaker commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

reidbaker commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker commented Apr 14, 2026

Uh oh!

jtmcdole commented Apr 14, 2026

Uh oh!

bkonyi Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

reidbaker Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

bkonyi commented Apr 16, 2026

Uh oh!

reidbaker commented Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

reidbaker commented Apr 14, 2026 •

edited

Loading