Skip to content

Reverts "Disable async mode with LLDB (#184768)"#184868

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert_eb4e55adca4c7e0ca1e87583c30cc403e775cf6b
Apr 10, 2026
Merged

Reverts "Disable async mode with LLDB (#184768)"#184868
auto-submit[bot] merged 1 commit into
masterfrom
revert_eb4e55adca4c7e0ca1e87583c30cc403e775cf6b

Conversation

@auto-submit

@auto-submit auto-submit Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Reverts: #184768

Initiated by: flar

Reason for reverting: #184867

Original PR Author: vashworth

Reviewed By: {hellohuanlin}

This change reverts the following previous change:
@mraleph proposed a better fix for the LLDB Xcode 26.4 breakage and I confirmed that it works.

This PR reverts the first fix and adopts the new one, which is to set LLDB to not use async mode.

For #184254.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@auto-submit auto-submit Bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Apr 10, 2026
@auto-submit auto-submit Bot requested review from a team as code owners April 10, 2026 06:28
@github-actions github-actions Bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team team-macos Owned by the macOS platform team platform-macos labels Apr 10, 2026
@auto-submit auto-submit Bot removed the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Apr 10, 2026
@auto-submit

auto-submit Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

auto label is removed for flutter/flutter/184868, Failed to enqueue flutter/flutter/184868 with HTTP 400: Pull request Required status check "Merge Queue Guard" is expected..

@flar flar added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Apr 10, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 10, 2026
@auto-submit

auto-submit Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

autosubmit label was removed for flutter/flutter/184868, because - The status or check suite cla/google has failed. Please fix the issues identified (or deflake) before re-applying this label.

@eyebrowsoffire eyebrowsoffire added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Apr 10, 2026
@flutter-dashboard

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 10, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Apr 10, 2026
Merged via the queue into master with commit 49233d0 Apr 10, 2026
179 of 180 checks passed
@auto-submit auto-submit Bot deleted the revert_eb4e55adca4c7e0ca1e87583c30cc403e775cf6b branch April 10, 2026 15:29
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Apr 10, 2026
<!-- start_original_pr_link -->
Reverts: flutter#184768
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: flar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: flutter#184867
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: vashworth
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {hellohuanlin}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
@mraleph proposed a [better
fix](flutter#184254 (comment))
for the LLDB Xcode 26.4 breakage and I confirmed that it works.

This PR reverts the first fix and adopts the new one, which is to set
LLDB to not use async mode.

For flutter#184254.

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 10, 2026
flutter/flutter@81c87ea...bf18e39

2026-04-10 [email protected] [flutter_tools] Fix arm64e incorrectly matching arm64 in regex check (flutter/flutter#184057)
2026-04-10 [email protected] Specify GitHub Repo in GH CLI calls for revert workflow. (flutter/flutter#184878)
2026-04-10 [email protected] Don't use `git add -N` in the sync engine workflow. (flutter/flutter#184882)
2026-04-10 [email protected] Roll Skia from af67d5555e35 to 25b01e5f4ea0 (14 revisions) (flutter/flutter#184865)
2026-04-10 [email protected] [Dot shorthands] Finish examples/api migration (flutter/flutter#183967)
2026-04-10 [email protected] Roll Dart SDK from 98a143f8873e to e715805ddbd3 (1 revision) (flutter/flutter#184864)
2026-04-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable async mode with LLDB (#184768)" (flutter/flutter#184868)
2026-04-09 [email protected] Skip freeze check in the merge queue (flutter/flutter#184854)
2026-04-09 [email protected] Remove unused variable in `ProcessTextPlugin.java` (flutter/flutter#184161)
2026-04-09 [email protected] Roll Fuchsia Linux SDK from pDXMXRIjEHTw7B0sk... to lZcRfPoCLnDttrf9P... (flutter/flutter#184842)
2026-04-09 [email protected] Roll Dart SDK from bd6280c3e8e9 to 98a143f8873e (5 revisions) (flutter/flutter#184824)
2026-04-09 [email protected] Remove `linux_android_emu_unstable android_engine_vulkan_tests` (flutter/flutter#184787)
2026-04-09 [email protected] Roll Packages from 0e0a032 to 1aa892c (9 revisions) (flutter/flutter#184829)
2026-04-09 [email protected] [record_use] Add experimental flag and test project (flutter/flutter#184719)
2026-04-09 [email protected] Disable async mode with LLDB (flutter/flutter#184768)
2026-04-09 [email protected] Update link for rolling forward to aligned Dart hash (flutter/flutter#184780)
2026-04-09 [email protected] Roll Skia from 4d0f5389e131 to af67d5555e35 (3 revisions) (flutter/flutter#184825)
2026-04-09 [email protected] UberSDFContent refactoring and handle stroke miter limit for stroked rects (flutter/flutter#184603)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
realmeylisdev added a commit to realmeylisdev/flutter that referenced this pull request Apr 11, 2026
…#184254)

Xcode 26.4's LLDB has a race condition where breakpoints randomly fail
to rearm after firing, causing EXC_BAD_ACCESS crashes on DartWorker
threads (~80% failure rate). This disables LLDB's async mode via
SetAsync(False) so breakpoint events are processed sequentially,
eliminating the race.

This re-lands the approach from flutter#184768 (reverted in flutter#184868 due to
test failures) with corrected tests that expect synchronous mode
output ('location added to breakpoint' instead of 'Process X resuming').

Also removes the manual stop/continue workaround from flutter#184690 and the
Xcode version dependency from the LLDB class, since SetAsync(False)
is safe on all LLDB versions.

Upstream bug: llvm/llvm-project#190956
mbcorona pushed a commit to mbcorona/flutter that referenced this pull request Apr 15, 2026
<!-- start_original_pr_link -->
Reverts: flutter#184768
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: flar
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: flutter#184867
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: vashworth
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {hellohuanlin}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
@mraleph proposed a [better
fix](flutter#184254 (comment))
for the LLDB Xcode 26.4 breakage and I confirmed that it works.

This PR reverts the first fix and adopts the new one, which is to set
LLDB to not use async mode.

For flutter#184254.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
@stuartmorgan-g stuartmorgan-g added platform-macos Building on or for macOS specifically and removed platform-macos labels Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop CICD Run CI/CD emergency Jump the queue; land PR in front of all others; only use for emergencies platform-ios iOS applications specifically platform-macos Building on or for macOS specifically team-ios Owned by iOS platform team team-macos Owned by the macOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants