refactor: Remove material imports from editable_text_scribble_test, editable_text_scribe_test, page_route_builder_test, radio_group_test, semantics_debugger_test, range_maintaining_scroll_physics_test, two_dimensional_scroll_view_test, routes_test, text_selection_test, selectable_region_test and text_golden_test#184798
Merged
auto-submit[bot] merged 5 commits intoApr 24, 2026
Conversation
github-actions
Bot
added
a: text input
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
rkishan516
force-pushed
the
simple-cross-imports-8
branch
from
b175749 to
5abc42c
Compare
rkishan516
force-pushed
the
simple-cross-imports-8
branch
from
5abc42c to
3f40857
Compare
rkishan516
force-pushed
the
simple-cross-imports-8
branch
from
3f40857 to
e4c9a80
Compare
rkishan516
force-pushed
the
simple-cross-imports-8
branch
from
e4c9a80 to
0ae6bea
Compare
rkishan516
force-pushed
the
simple-cross-imports-8
branch
from
0ae6bea to
858bfa8
Compare
10 tasks
rkishan516
force-pushed
the
simple-cross-imports-8
branch
from
858bfa8 to
057fb3f
Compare
57 tasks
rkishan516
force-pushed
the
simple-cross-imports-8
branch
from
4fda411 to
4e79142
Compare
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
justinmc
approved these changes
Apr 24, 2026
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 . I approved all of the goldens, thanks! They were easy approvals now, the only change was TestCheckbox's slightly different look compared with Checkbox, and a very slight difference between TextField and TestTextField.
justinmc
added
the
autosubmit
github-project-automation
Bot
moved this from Todo
to Done
in Test cross-imports Review Queue
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Apr 25, 2026
9 tasks
This was referenced Apr 26, 2026
6 tasks
pull Bot
pushed a commit
to chunfengyao/flutter
that referenced
this pull request
May 16, 2026
This PR removes Material imports from: - default_text_editing_shortcuts_test.dart - framework_test.dart - scrollable_in_overlay_test.dart Also moved `TestRadio` & `TestSlider` widgets to their respective separate files `radio_tester.dart` & `slider_tester.dart` part of: flutter#177415 dependent on flutter#184798 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: rkishan516 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes Material imports from
part of: #177415
Pre-launch Checklist
///).