SelectableRegion can dismiss context menu with keyboard shortcuts#184788
Merged
auto-submit[bot] merged 3 commits intoApr 11, 2026
Merged
Conversation
github-actions
Bot
added
the
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a DismissIntent handler to SelectableRegion to allow hiding the toolbar via keyboard shortcuts, along with a corresponding test case. The review identifies a potential crash when invoking the intent and suggests using Actions.maybeInvoke instead, while also recommending the addition of documentation for the new private method to align with repository style guidelines.
Renzo-Olivares
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2026
This was referenced Apr 11, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 11, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 12, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 13, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 13, 2026
flutter/flutter@bf18e39...2fa45e0 2026-04-13 [email protected] Test that the locked version of dependencies of sdk packages equal the lower bound (flutter/flutter#183395) 2026-04-13 [email protected] Roll Skia from 8d35796258a2 to 55ddd6bb8be5 (1 revision) (flutter/flutter#184952) 2026-04-12 [email protected] Roll Fuchsia Linux SDK from tEm4sdcM6twjxQ0w6... to K_2AkZL3Drs6cGE1q... (flutter/flutter#184930) 2026-04-12 [email protected] Roll Dart SDK from 77324e51833a to ef28089d6533 (1 revision) (flutter/flutter#184929) 2026-04-12 [email protected] Roll Skia from 6942f5774d65 to 8d35796258a2 (2 revisions) (flutter/flutter#184924) 2026-04-11 [email protected] Roll Dart SDK from 8fdbf58b58bd to 77324e51833a (1 revision) (flutter/flutter#184921) 2026-04-11 [email protected] Roll Fuchsia Linux SDK from lZcRfPoCLnDttrf9P... to tEm4sdcM6twjxQ0w6... (flutter/flutter#184917) 2026-04-11 [email protected] Roll Dart SDK from 7128b5b5142c to 8fdbf58b58bd (1 revision) (flutter/flutter#184906) 2026-04-11 [email protected] Roll Skia from 8cbf3db1a0db to 6942f5774d65 (1 revision) (flutter/flutter#184911) 2026-04-11 [email protected] `SelectableRegion` can dismiss context menu with keyboard shortcuts (flutter/flutter#184788) 2026-04-11 [email protected] Roll Skia from a8128c7adc49 to 8cbf3db1a0db (1 revision) (flutter/flutter#184904) 2026-04-10 [email protected] Roll Dart SDK from e715805ddbd3 to 7128b5b5142c (3 revisions) (flutter/flutter#184896) 2026-04-10 [email protected] Roll Skia from 7c8b85349a9a to a8128c7adc49 (2 revisions) (flutter/flutter#184899) 2026-04-10 [email protected] [web] Refactor LazyPath and separate immutable paths from path builders (flutter/flutter#177686) 2026-04-10 [email protected] Roll Skia from 25b01e5f4ea0 to 7c8b85349a9a (13 revisions) (flutter/flutter#184887) 2026-04-10 [email protected] Reduce boilerplate in FlutterPlatformViewsTest.mm (flutter/flutter#184555) 2026-04-10 [email protected] [macOS] Add move timer runloop mode to common modes (flutter/flutter#182295) 2026-04-10 [email protected] Roll Packages from 1aa892c to c2e3d1f (5 revisions) (flutter/flutter#184886) 2026-04-10 [email protected] Win32: Prevent mouse leave on WM_SYSKEYUP. (flutter/flutter#184835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
master-wayne7
pushed a commit
to master-wayne7/flutter
that referenced
this pull request
Apr 15, 2026
…lutter#184788) Part of flutter#182628 Adds support for `DismissIntent` in `SelectableRegion`, so it may dismiss the context menu when it is present and the "esc" key is pressed. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
mbcorona
pushed a commit
to mbcorona/flutter
that referenced
this pull request
Apr 15, 2026
…lutter#184788) Part of flutter#182628 Adds support for `DismissIntent` in `SelectableRegion`, so it may dismiss the context menu when it is present and the "esc" key is pressed. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11497) flutter/flutter@bf18e39...2fa45e0 2026-04-13 [email protected] Test that the locked version of dependencies of sdk packages equal the lower bound (flutter/flutter#183395) 2026-04-13 [email protected] Roll Skia from 8d35796258a2 to 55ddd6bb8be5 (1 revision) (flutter/flutter#184952) 2026-04-12 [email protected] Roll Fuchsia Linux SDK from tEm4sdcM6twjxQ0w6... to K_2AkZL3Drs6cGE1q... (flutter/flutter#184930) 2026-04-12 [email protected] Roll Dart SDK from 77324e51833a to ef28089d6533 (1 revision) (flutter/flutter#184929) 2026-04-12 [email protected] Roll Skia from 6942f5774d65 to 8d35796258a2 (2 revisions) (flutter/flutter#184924) 2026-04-11 [email protected] Roll Dart SDK from 8fdbf58b58bd to 77324e51833a (1 revision) (flutter/flutter#184921) 2026-04-11 [email protected] Roll Fuchsia Linux SDK from lZcRfPoCLnDttrf9P... to tEm4sdcM6twjxQ0w6... (flutter/flutter#184917) 2026-04-11 [email protected] Roll Dart SDK from 7128b5b5142c to 8fdbf58b58bd (1 revision) (flutter/flutter#184906) 2026-04-11 [email protected] Roll Skia from 8cbf3db1a0db to 6942f5774d65 (1 revision) (flutter/flutter#184911) 2026-04-11 [email protected] `SelectableRegion` can dismiss context menu with keyboard shortcuts (flutter/flutter#184788) 2026-04-11 [email protected] Roll Skia from a8128c7adc49 to 8cbf3db1a0db (1 revision) (flutter/flutter#184904) 2026-04-10 [email protected] Roll Dart SDK from e715805ddbd3 to 7128b5b5142c (3 revisions) (flutter/flutter#184896) 2026-04-10 [email protected] Roll Skia from 7c8b85349a9a to a8128c7adc49 (2 revisions) (flutter/flutter#184899) 2026-04-10 [email protected] [web] Refactor LazyPath and separate immutable paths from path builders (flutter/flutter#177686) 2026-04-10 [email protected] Roll Skia from 25b01e5f4ea0 to 7c8b85349a9a (13 revisions) (flutter/flutter#184887) 2026-04-10 [email protected] Reduce boilerplate in FlutterPlatformViewsTest.mm (flutter/flutter#184555) 2026-04-10 [email protected] [macOS] Add move timer runloop mode to common modes (flutter/flutter#182295) 2026-04-10 [email protected] Roll Packages from 1aa892c to c2e3d1f (5 revisions) (flutter/flutter#184886) 2026-04-10 [email protected] Win32: Prevent mouse leave on WM_SYSKEYUP. (flutter/flutter#184835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Istiak-Ahmed78
pushed a commit
to Istiak-Ahmed78/packages
that referenced
this pull request
Jun 19, 2026
…r#11497) flutter/flutter@bf18e39...2fa45e0 2026-04-13 [email protected] Test that the locked version of dependencies of sdk packages equal the lower bound (flutter/flutter#183395) 2026-04-13 [email protected] Roll Skia from 8d35796258a2 to 55ddd6bb8be5 (1 revision) (flutter/flutter#184952) 2026-04-12 [email protected] Roll Fuchsia Linux SDK from tEm4sdcM6twjxQ0w6... to K_2AkZL3Drs6cGE1q... (flutter/flutter#184930) 2026-04-12 [email protected] Roll Dart SDK from 77324e51833a to ef28089d6533 (1 revision) (flutter/flutter#184929) 2026-04-12 [email protected] Roll Skia from 6942f5774d65 to 8d35796258a2 (2 revisions) (flutter/flutter#184924) 2026-04-11 [email protected] Roll Dart SDK from 8fdbf58b58bd to 77324e51833a (1 revision) (flutter/flutter#184921) 2026-04-11 [email protected] Roll Fuchsia Linux SDK from lZcRfPoCLnDttrf9P... to tEm4sdcM6twjxQ0w6... (flutter/flutter#184917) 2026-04-11 [email protected] Roll Dart SDK from 7128b5b5142c to 8fdbf58b58bd (1 revision) (flutter/flutter#184906) 2026-04-11 [email protected] Roll Skia from 8cbf3db1a0db to 6942f5774d65 (1 revision) (flutter/flutter#184911) 2026-04-11 [email protected] `SelectableRegion` can dismiss context menu with keyboard shortcuts (flutter/flutter#184788) 2026-04-11 [email protected] Roll Skia from a8128c7adc49 to 8cbf3db1a0db (1 revision) (flutter/flutter#184904) 2026-04-10 [email protected] Roll Dart SDK from e715805ddbd3 to 7128b5b5142c (3 revisions) (flutter/flutter#184896) 2026-04-10 [email protected] Roll Skia from 7c8b85349a9a to a8128c7adc49 (2 revisions) (flutter/flutter#184899) 2026-04-10 [email protected] [web] Refactor LazyPath and separate immutable paths from path builders (flutter/flutter#177686) 2026-04-10 [email protected] Roll Skia from 25b01e5f4ea0 to 7c8b85349a9a (13 revisions) (flutter/flutter#184887) 2026-04-10 [email protected] Reduce boilerplate in FlutterPlatformViewsTest.mm (flutter/flutter#184555) 2026-04-10 [email protected] [macOS] Add move timer runloop mode to common modes (flutter/flutter#182295) 2026-04-10 [email protected] Roll Packages from 1aa892c to c2e3d1f (5 revisions) (flutter/flutter#184886) 2026-04-10 [email protected] Win32: Prevent mouse leave on WM_SYSKEYUP. (flutter/flutter#184835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #182628
Adds support for
DismissIntentinSelectableRegion, so it may dismiss the context menu when it is present and the "esc" key is pressed.Pre-launch Checklist
///).