[flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task by reidbaker · Pull Request #184731 · flutter/flutter

reidbaker · 2026-04-07T19:18:03Z

Migrates the evaluation of detectLowCompileSdkVersionOrNdkVersion from project.afterEvaluate to a modern Android Gradle Plugin (AGP) task-based approach.

Fixes #184415

Pre-launch Checklist

… task Migrates the evaluation of detectLowCompileSdkVersionOrNdkVersion from project.afterEvaluate to a modern Android Gradle Plugin (AGP) task-based approach.

gemini-code-assist

Code Review

This pull request refactors the Android SDK and NDK version validation logic into a dedicated Gradle task, ValidateCompileSdkVersionTask, which is now wired to run before the preBuild task. The changes include migrating the validation logic from FlutterPluginUtils and updating the test suite accordingly. Feedback was provided to improve Gradle performance by adhering to the Task Configuration Avoidance API, specifically by configuring the task lazily instead of forcing immediate realization.

reidbaker · 2026-04-07T19:20:43Z

Leaving in draft until tests pass.

- Applied ktlint formatting using CI configuration - Used editorconfig and ktlint-baseline from dev/bots/test/analyze-test-input - Validated all changes pass ktlint checks

…ment on github for ways to resolve false positives

…figuration avoidance working

…at automatically

gemini-code-assist

Code Review

This pull request refactors the Android SDK and NDK version validation logic by introducing a new 'ValidateCompileSdkVersionTask' and removing the legacy 'logPluginCompileSdkWarnings' and 'logPluginNdkWarnings' methods from 'FlutterPluginUtils'. The review identified several critical issues: missing imports for 'AndroidComponentsExtension', potential NullPointerExceptions when accessing Android extensions, and the need to restore default NDK version handling to prevent runtime crashes.

…ce and configuration cache compatible

fluttergithubbot · 2026-04-13T17:53:47Z

An existing Git SHA, bb497efbc32b1866d5045bfbbfe387bb6c8b3c52, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

gmackall · 2026-04-16T17:53:30Z

+                    val name = requireNotNull(plugin["name"] as? String) { "Missing valid \"name\" property for plugin object: $plugin" }
+                    val pluginProject = project.rootProject.findProject(":$name")
+                    if (pluginProject != null) {
+                        val androidExtensionWrapper =


Should this be pluginAndroidExtension and the existing extension be projectAndroidExtension ? The current naming makes it seem like one is a wrapper and one is the direct object

but these are just actually both the direct object right, just for the different projects

…light-gradle-checks

…11713) Manual roll requested by [email protected] flutter/flutter@23f6f58...0541913 2026-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Windows] Propagate the enabled accessibility state (#184501)" (flutter/flutter#186492) 2026-05-13 [email protected] [dev] Use super parameters in missed spots (flutter/flutter#186193) 2026-05-13 [email protected] [Windows] Propagate the enabled accessibility state (flutter/flutter#184501) 2026-05-13 [email protected] [flutter_tool] filter out MotionEvent-JNI warning spam from logcat (#174783) (flutter/flutter#186079) 2026-05-13 [email protected] Roll Packages from 93cbed6 to 2ec2236 (1 revision) (flutter/flutter#186464) 2026-05-13 [email protected] [web] Fix untriaged issues link label (flutter/flutter#186465) 2026-05-13 [email protected] [Impeller] Namespace user-supplied shaders to prevent entrypoint collisions (flutter/flutter#186332) 2026-05-13 [email protected] [flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task (flutter/flutter#184731) 2026-05-13 [email protected] Update the Flutter Gallery web app template files to support running with Wasm (flutter/flutter#186268) 2026-05-13 [email protected] [web] Use heap allocation for buffers that would consume too much space on the Wasm stack (flutter/flutter#186228) 2026-05-13 [email protected] Roll Skia from 56ca5896c0d9 to 27f7bba22600 (3 revisions) (flutter/flutter#186444) 2026-05-13 [email protected] Roll Fuchsia Linux SDK from z7ICmPtn4hspu02zk... to y6uQHA5xUN83IF395... (flutter/flutter#186442) 2026-05-13 [email protected] Roll Skia from 6385958d2feb to 56ca5896c0d9 (1 revision) (flutter/flutter#186441) 2026-05-13 [email protected] Roll Dart SDK from 9576691c37d8 to 8e30b88e4d5a (1 revision) (flutter/flutter#186429) 2026-05-13 [email protected] Roll Skia from 77a21bc723dc to 6385958d2feb (9 revisions) (flutter/flutter#186428) 2026-05-13 [email protected] Docs/improving docs for semantics UI lib (flutter/flutter#186125) 2026-05-12 [email protected] [Tool] Support glob patterns when parsing workspaces in FlutterProject (flutter/flutter#185715) 2026-05-12 [email protected] docs: fix overriden -> overridden in MediaQueryData dartdoc (flutter/flutter#186323) 2026-05-12 [email protected] [Test cross imports] No material in `test/foundation`, `test/gestures`, `test/semantics`, `test/services` (flutter/flutter#186144) 2026-05-12 [email protected] docs: fix "tha" -> "that" typo in widget_inspector_test comment (flutter/flutter#186322) 2026-05-12 [email protected] docs: Fix doubled-word typos in framework dartdoc (flutter/flutter#186319) 2026-05-12 [email protected] Roll pub packages (flutter/flutter#186418) 2026-05-12 [email protected] Bumped required mediatek vender sdk version. (flutter/flutter#186405) 2026-05-12 [email protected] Make DeepLinkJsonFromManifestTask Gradle task build cacheable (flutter/flutter#185903) 2026-05-12 [email protected] Harden dev tooling scripts against command injection and log leaks (flutter/flutter#186076) 2026-05-12 [email protected] Roll pub packages (flutter/flutter#186274) 2026-05-12 [email protected] [Flutter GPU] Allow allocating multi-mip textures and overwriting specific (mip, slice) levels (flutter/flutter#185890) 2026-05-12 [email protected] [web] Fix MenuAnchor dismiss when semantics enabled (flutter/flutter#183093) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#11713) Manual roll requested by [email protected] flutter/flutter@23f6f58...0541913 2026-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Windows] Propagate the enabled accessibility state (#184501)" (flutter/flutter#186492) 2026-05-13 [email protected] [dev] Use super parameters in missed spots (flutter/flutter#186193) 2026-05-13 [email protected] [Windows] Propagate the enabled accessibility state (flutter/flutter#184501) 2026-05-13 [email protected] [flutter_tool] filter out MotionEvent-JNI warning spam from logcat (#174783) (flutter/flutter#186079) 2026-05-13 [email protected] Roll Packages from 93cbed6 to 2ec2236 (1 revision) (flutter/flutter#186464) 2026-05-13 [email protected] [web] Fix untriaged issues link label (flutter/flutter#186465) 2026-05-13 [email protected] [Impeller] Namespace user-supplied shaders to prevent entrypoint collisions (flutter/flutter#186332) 2026-05-13 [email protected] [flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task (flutter/flutter#184731) 2026-05-13 [email protected] Update the Flutter Gallery web app template files to support running with Wasm (flutter/flutter#186268) 2026-05-13 [email protected] [web] Use heap allocation for buffers that would consume too much space on the Wasm stack (flutter/flutter#186228) 2026-05-13 [email protected] Roll Skia from 56ca5896c0d9 to 27f7bba22600 (3 revisions) (flutter/flutter#186444) 2026-05-13 [email protected] Roll Fuchsia Linux SDK from z7ICmPtn4hspu02zk... to y6uQHA5xUN83IF395... (flutter/flutter#186442) 2026-05-13 [email protected] Roll Skia from 6385958d2feb to 56ca5896c0d9 (1 revision) (flutter/flutter#186441) 2026-05-13 [email protected] Roll Dart SDK from 9576691c37d8 to 8e30b88e4d5a (1 revision) (flutter/flutter#186429) 2026-05-13 [email protected] Roll Skia from 77a21bc723dc to 6385958d2feb (9 revisions) (flutter/flutter#186428) 2026-05-13 [email protected] Docs/improving docs for semantics UI lib (flutter/flutter#186125) 2026-05-12 [email protected] [Tool] Support glob patterns when parsing workspaces in FlutterProject (flutter/flutter#185715) 2026-05-12 [email protected] docs: fix overriden -> overridden in MediaQueryData dartdoc (flutter/flutter#186323) 2026-05-12 [email protected] [Test cross imports] No material in `test/foundation`, `test/gestures`, `test/semantics`, `test/services` (flutter/flutter#186144) 2026-05-12 [email protected] docs: fix "tha" -> "that" typo in widget_inspector_test comment (flutter/flutter#186322) 2026-05-12 [email protected] docs: Fix doubled-word typos in framework dartdoc (flutter/flutter#186319) 2026-05-12 [email protected] Roll pub packages (flutter/flutter#186418) 2026-05-12 [email protected] Bumped required mediatek vender sdk version. (flutter/flutter#186405) 2026-05-12 [email protected] Make DeepLinkJsonFromManifestTask Gradle task build cacheable (flutter/flutter#185903) 2026-05-12 [email protected] Harden dev tooling scripts against command injection and log leaks (flutter/flutter#186076) 2026-05-12 [email protected] Roll pub packages (flutter/flutter#186274) 2026-05-12 [email protected] [Flutter GPU] Allow allocating multi-mip textures and overwriting specific (mip, slice) levels (flutter/flutter#185890) 2026-05-12 [email protected] [web] Fix MenuAnchor dismiss when semantics enabled (flutter/flutter#183093) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP…

920b620

… task Migrates the evaluation of detectLowCompileSdkVersionOrNdkVersion from project.afterEvaluate to a modern Android Gradle Plugin (AGP) task-based approach.

reidbaker requested a review from a team as a code owner April 7, 2026 19:18

github-actions Bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 7, 2026

Merge branch 'master' into i184415-migrate-pre-flight-gradle-checks

e9d26f2

reidbaker added the CICD Run CI/CD label Apr 7, 2026

reidbaker marked this pull request as draft April 7, 2026 19:20

gemini-code-assist Bot reviewed Apr 7, 2026

View reviewed changes

Comment thread packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt Outdated

reidbaker added 3 commits April 9, 2026 11:18

Format Kotlin files to match CI standards

18acc4a

- Applied ktlint formatting using CI configuration - Used editorconfig and ktlint-baseline from dev/bots/test/analyze-test-input - Validated all changes pass ktlint checks

Use configuration api instead

2a64d95

Remove codepaths for unspecified ndk versions and add a link to a com…

e49b576

…ment on github for ways to resolve false positives

github-actions Bot removed the CICD Run CI/CD label Apr 9, 2026

reidbaker added 3 commits April 9, 2026 12:29

remove illegal arument tests that became hard to mock when we got con…

a8a6201

…figuration avoidance working

Update readme with ktlint commands and rules so that agents will form…

f3f6108

…at automatically

Merge origin/main and preserve KGP detection logic and tests

81461be

reidbaker added the CICD Run CI/CD label Apr 9, 2026

Add test for registration of task

fafd40b

github-actions Bot removed the CICD Run CI/CD label Apr 9, 2026

reidbaker added the CICD Run CI/CD label Apr 9, 2026

reidbaker marked this pull request as ready for review April 9, 2026 21:30

reidbaker requested a review from jesswrd April 9, 2026 21:30

gemini-code-assist Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt

Comment thread packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt

Comment thread packages/flutter_tools/gradle/src/main/kotlin/FlutterPluginUtils.kt Outdated

Make detectLowCompileSdkVersionOrNdkVersion use configuration avoidan…

e860f81

…ce and configuration cache compatible

github-actions Bot removed the CICD Run CI/CD label Apr 10, 2026

reidbaker added the CICD Run CI/CD label Apr 10, 2026

formatting

bb497ef

github-actions Bot removed the CICD Run CI/CD label Apr 13, 2026

reidbaker added CICD Run CI/CD and removed CICD Run CI/CD labels Apr 13, 2026

reidbaker added the CICD Run CI/CD label Apr 13, 2026

reidbaker requested a review from gmackall April 13, 2026 18:47

gmackall previously approved these changes Apr 16, 2026

View reviewed changes

reidbaker added the waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 28, 2026

reidbaker added 2 commits May 12, 2026 15:34

rename for readability

80fdbf3

Merge remote-tracking branch 'origin/main' into i184415-migrate-pre-f…

7a81292

…light-gradle-checks

reidbaker dismissed gmackall’s stale review via 7a81292 May 12, 2026 19:53

github-actions Bot removed the CICD Run CI/CD label May 12, 2026

reidbaker added CICD Run CI/CD and removed waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds labels May 12, 2026

gmackall approved these changes May 13, 2026

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2026

auto-submit Bot added this pull request to the merge queue May 13, 2026

Merged via the queue into flutter:master with commit 2650dc5 May 13, 2026
165 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task#184731

[flutter_tools] Migrate detectLowCompileSdkVersionOrNdkVersion to AGP task#184731
auto-submit[bot] merged 13 commits into
flutter:masterfrom
reidbaker:i184415-migrate-pre-flight-gradle-checks

reidbaker commented Apr 7, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

reidbaker commented Apr 7, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fluttergithubbot commented Apr 13, 2026

Uh oh!

gmackall Apr 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

reidbaker commented Apr 7, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

reidbaker commented Apr 7, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fluttergithubbot commented Apr 13, 2026

Uh oh!

gmackall Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants