Reverts "Apply rect clipping to surface views (#184471)"#184724
Reverts "Apply rect clipping to surface views (#184471)"#184724auto-submit[bot] wants to merge 1 commit into
Conversation
This reverts commit a488da3.
auto-submit
Bot
added
the
revert of
github-actions
Bot
added
platform-android
auto-submit
Bot
removed
the
revert of
|
auto label is removed for flutter/flutter/184724, Failed to enqueue flutter/flutter/184724 with HTTP 400: GraphQL mutate failed. |
gmackall
added
the
revert of
|
auto label is removed for flutter/flutter/184724, Failed to enqueue flutter/flutter/184724 with HTTP 400: GraphQL mutate failed. |
auto-submit
Bot
removed
the
revert of
gmackall
added
the
revert of
auto-submit
Bot
removed
the
revert of
|
auto label is removed for flutter/flutter/184724, Failed to enqueue flutter/flutter/184724 with HTTP 400: GraphQL mutate failed. |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
reidbaker
added
emergency
auto-submit
Bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter/184724, Failed to enqueue flutter/flutter/184724 with HTTP 400: GraphQL mutate failed. |
|
Emergency label because the tree is not only red but this is blocking all prs from having passing tests. Approval of goldens before the reverted change landed did not seem to prevent issues and approval after also is not unblocking presubmits. |
reidbaker
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter/184724, Failed to enqueue flutter/flutter/184724 with HTTP 400: GraphQL mutate failed. |
To be clear, this is a skia gold bug. There is something wrong with the new digests which prevents them from being approved. So this is a desperate attempt to remove and recreate them be reverting and relanding |
Pull request was closed
…er#184728) This reverts commit a488da3 because the bot is failing to do so in flutter#184724 Revert because skia gold seems bugged w.r.t. the original pr, so try relanding it to reset skia gold state
3 participants
Reverts: #184471
Initiated by: gmackall
Reason for reverting: Skia gold seems seriously confused about this PR (likely a bug). I think the only solution we can easily come up with is to just revert and re land
Original PR Author: gmackall
Reviewed By: {mboetger, reidbaker}
This change reverts the following previous change:
Fixes #175546
Upper image is unclipped, bottom is clipped: