Use full goto.google.com hostname for go/ links#184679
Merged
Merged
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates internal documentation links from http://go/ to https://goto.google.com/ across several Markdown files. Feedback includes corrections for typos, capitalization, and grammatical errors in the modified documentation lines to improve readability and consistency.
| instructions [here](http://go/flutter-luci-playbook#remove-duplicated-cipd-tags). | ||
| Then, re-upload the correct Java version pacakge to CIPD. No newline at end of file | ||
| instructions [here](https://goto.google.com/flutter-luci-playbook#remove-duplicated-cipd-tags). | ||
| Then, re-upload the correct Java version pacakge to CIPD. |
Contributor
There was a problem hiding this comment.
There is a typo in this line: 'pacakge' should be 'package'.
Suggested change
| Then, re-upload the correct Java version pacakge to CIPD. | |
| Then, re-upload the correct Java version package to CIPD. |
References
- Optimize for readability: Documentation should be clear and free of typos. (link)
|
|
||
| 1. If you encounter a serious P0 flutter production Google3 or a GitHub issue, triage the issue and check if the issue is already part of Flutter's bad build [tracker](http://go/flutter-bad-builds). | ||
| If the issue is not listed in Flutter bad builds [tracker](http://go/flutter-bad-builds), check that it meets the below criteria to qualify for bad builds visibility - | ||
| 1. If you encounter a serious P0 flutter production Google3 or a GitHub issue, triage the issue and check if the issue is already part of Flutter's bad build [tracker](https://goto.google.com/flutter-bad-builds). |
Contributor
There was a problem hiding this comment.
Minor improvements: 'flutter' should be capitalized as 'Flutter' for consistency, and 'bad build tracker' should be pluralized as 'bad builds tracker' to match the rest of the document.
Suggested change
| 1. If you encounter a serious P0 flutter production Google3 or a GitHub issue, triage the issue and check if the issue is already part of Flutter's bad build [tracker](https://goto.google.com/flutter-bad-builds). | |
| 1. If you encounter a serious P0 Flutter production Google3 or a GitHub issue, triage the issue and check if the issue is already part of Flutter's bad builds [tracker](https://goto.google.com/flutter-bad-builds). |
References
- Optimize for readability: Documentation should follow consistent capitalization and terminology. (link)
| 2. If there is a buganizer for this already and no GitHub issue, create a GitHub bug in the GitHub repo. Label the GitHub bug with label _a: production_ and _customer: google_. | ||
|
|
||
| 3. Add following information to Flutter bad builds visibility [tracker](http://go/flutter-bad-builds) | ||
| 3. Add following information to Flutter bad builds visibility [tracker](https://goto.google.com/flutter-bad-builds) |
Contributor
There was a problem hiding this comment.
Grammar: 'Add following information' should be 'Add the following information'.
Suggested change
| 3. Add following information to Flutter bad builds visibility [tracker](https://goto.google.com/flutter-bad-builds) | |
| 3. Add the following information to Flutter bad builds visibility [tracker](https://goto.google.com/flutter-bad-builds) |
References
- Optimize for readability: Documentation should be grammatically correct. (link)
| 5. Once a fix has been merged, enter the “End bad build commit hash 1 URL”. | ||
|
|
||
| 6. There are cases when a fix is merged as part of 2 different commits. In that case, you can use the "End bad build commit hash 2 URL" column to populate the second commits hash information. Automation will take care of finding the corresponding End bad build commit CL based on the End bad build commit URL you entered. No newline at end of file | ||
| 6. There are cases when a fix is merged as part of 2 different commits. In that case, you can use the "End bad build commit hash 2 URL" column to populate the second commits hash information. Automation will take care of finding the corresponding End bad build commit CL based on the End bad build commit URL you entered. |
Contributor
There was a problem hiding this comment.
Grammar: 'second commits hash' should be 'second commit's hash' to correctly indicate possession.
Suggested change
| 6. There are cases when a fix is merged as part of 2 different commits. In that case, you can use the "End bad build commit hash 2 URL" column to populate the second commits hash information. Automation will take care of finding the corresponding End bad build commit CL based on the End bad build commit URL you entered. | |
| 6. There are cases when a fix is merged as part of 2 different commits. In that case, you can use the "End bad build commit hash 2 URL" column to populate the second commit's hash information. Automation will take care of finding the corresponding End bad build commit CL based on the End bad build commit URL you entered. |
References
- Optimize for readability: Documentation should be grammatically correct. (link)
reidbaker
approved these changes
Apr 6, 2026
b-luk
added
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 7, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 7, 2026
flutter/flutter@9cd60b5...a0924c7 2026-04-07 [email protected] Reland "[data_assets] Cleanup tests" (flutter/flutter#184714) 2026-04-07 [email protected] Use the WindowRegistry in the multiple_windows example app (flutter/flutter#184579) 2026-04-07 [email protected] Introduce command to build a swift package for SwiftPM add to app integration (flutter/flutter#184660) 2026-04-07 [email protected] Have `flutter create` create a pubspec.lock to ensure pinned versions are being used. (flutter/flutter#175352) 2026-04-07 [email protected] [widgets/raw_menu_anchor.dart] Always call onClose and onCloseRequested on descendants before parent. (flutter/flutter#182357) 2026-04-07 [email protected] `WindowsPlugin` should not crash when ffiPlugin enabled (flutter/flutter#184695) 2026-04-06 [email protected] Use full goto.google.com hostname for go/ links (flutter/flutter#184679) 2026-04-06 [email protected] Apply rect clipping to surface views (flutter/flutter#184471) 2026-04-06 [email protected] [A11y] Allow percentage strings like "50%" as `SemanticsValue` for `ProgressIndicator` (flutter/flutter#183670) 2026-04-06 [email protected] Fix invisible accessibility element before scroll view (flutter/flutter#184155) 2026-04-06 [email protected] Roll Skia from 163dfdf500c7 to e264d870a380 (2 revisions) (flutter/flutter#184674) 2026-04-06 [email protected] Keep last character obscured when toggling obscureText (flutter/flutter#183488) 2026-04-06 [email protected] Parse scheme file with XML parser for SwiftPM migrator (flutter/flutter#184525) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mbcorona
pushed a commit
to mbcorona/flutter
that referenced
this pull request
Apr 15, 2026
It is best practice to use the full hostname, because it works in certain situations where go/ does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is best practice to use the full hostname, because it works in certain situations where go/ does not.