Even more awaits v2 by victorsanni · Pull Request #184552 · flutter/flutter

victorsanni · 2026-04-03T00:58:26Z

gemini-code-assist

Code Review

This pull request adds missing await keywords to several asynchronous method calls within the Flutter framework and its tests, including dispose, handleRawKeyMessage, and route handling methods. The reviewer suggests using await instead of unawaited for reassembleApplication calls in test files to ensure the reassembly process is fully completed before the test continues, which would also permit the removal of the dart:async imports.

gemini-code-assist · 2026-04-03T01:00:33Z

    );
    debugDisableShadows = false;
-    tester.binding.reassembleApplication();
+    unawaited(tester.binding.reassembleApplication());


Consider using await here instead of unawaited to ensure the reassemble process completes before the test continues. This is consistent with the intent of this PR and improves test reliability.

await tester.binding.reassembleApplication();

References

The Flutter style guide emphasizes optimizing for readability. Using await in tests is generally more readable and predictable than unawaited followed by pump when dealing with futures that have side effects. ^(link)

Using await causes test failures.

gemini-code-assist · 2026-04-03T01:00:33Z

    );
    debugDisableShadows = false;
-    tester.binding.reassembleApplication();
+    unawaited(tester.binding.reassembleApplication());


Consider using await here instead of unawaited to ensure the reassemble process completes before the test continues.

await tester.binding.reassembleApplication();

References

The Flutter style guide emphasizes optimizing for readability. Using await in tests is generally more readable and predictable than unawaited followed by pump when dealing with futures that have side effects. ^(link)

Using await causes test failures.

gemini-code-assist · 2026-04-03T01:00:33Z

        // We need the runTest to setup the fake async in the test binding.
        await binding.runTest(() async {
-          binding.reassembleApplication();
+          unawaited(binding.reassembleApplication());


Consider using await here instead of unawaited. Awaiting reassembleApplication ensures that all asynchronous work triggered by the reassemble is finished before calling pump.

await binding.reassembleApplication();

References

The Flutter style guide emphasizes optimizing for readability. Using await in tests is generally more readable and predictable than unawaited followed by pump when dealing with futures that have side effects. ^(link)

dkwingsmt · 2026-04-03T23:03:26Z

    final ControllerT controller = await createNewViewController(id);
    if (!mounted) {
-      controller.dispose();
+      await controller.dispose();


This might not be desirable because _createNewUiKitView's returned future is not used. I suggest process its error within _createNewUiKitView. Maybe wrap the full body within a big try and report error at the end. (Then maybe unawaited it?)

dkwingsmt · 2026-04-03T23:09:35Z

    await tester.pumpWidget(const TestWidgetsApp(home: Text('Hello World')));
    await tester.pump();
-    tester.binding.reassembleApplication();
+    unawaited(tester.binding.reassembleApplication());


It seems that all usages of reassembleApplication must be unawaited in unit tests. If you're confident that this is the correct pattern, I think we should add a new method to the tester binding that performs unawaited(tester.binding.reassembleApplication()) and document its usage.

In some cases using unawaited causes test failures so I ignored instead. Should I just mark this function as awaitNotRequired?

I am confused too. It seems to me that unawaited is equivalent to awaitNotRequired. Do you have an idea?

Actually the test failures weren't caused by the unawaited but by importing dart:async. I don't understand why.

It seems to me that unawaited is equivalent to awaitNotRequired. Do you have an idea?

I think if all the callsites of a function should be unawaited it's best to just apply the annotation. But for reassembleApplication there are some callsites where it is awaited?

victorsanni · 2026-04-06T21:35:45Z

    );
    debugDisableShadows = false;
-    tester.binding.reassembleApplication();
+    unawaited(tester.binding.reassembleApplication());


Using await causes test failures.

victorsanni · 2026-04-06T21:35:58Z

    );
    debugDisableShadows = false;
-    tester.binding.reassembleApplication();
+    unawaited(tester.binding.reassembleApplication());


Using await causes test failures.

victorsanni · 2026-04-06T21:36:25Z

        final TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized();
        // We need the runTest to setup the fake async in the test binding.
        await binding.runTest(() async {
+          // ignore: unawaited_futures


unawaited here causes failures so I replaced with ignore.

auto-submit · 2026-04-08T09:32:22Z

auto label is removed for flutter/flutter/184552, Failed to enqueue flutter/flutter/184552 with HTTP 400: GraphQL mutate failed.

auto-submit · 2026-04-08T14:43:06Z

auto label is removed for flutter/flutter/184552, Failed to enqueue flutter/flutter/184552 with HTTP 400: GraphQL mutate failed.

fluttergithubbot · 2026-04-08T15:55:36Z

An existing Git SHA, aae2c3f7b8bda6b579d996d576f6ad06c77c2d5d, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

auto-submit · 2026-04-08T17:23:10Z

auto label is removed for flutter/flutter/184552, Failed to enqueue flutter/flutter/184552 with HTTP 400: GraphQL mutate failed.

eyebrowsoffire · 2026-04-08T18:07:24Z

Sorry about the opaque error message here. I pulled from our logs and here is the error:

Pull request New changes require approval from someone other than dkwingsmt because they were the last pusher.

The next version of cocoon will have these messages inline in the failure message that autosubmit posts when it fails to enqueue the PR.

flutter/flutter@05e0ae0...81c87ea 2026-04-09 [email protected] Remove last material dependency from cupertino tests (flutter/flutter#184781) 2026-04-09 [email protected] Roll Skia from 7c46cb639dba to 4d0f5389e131 (7 revisions) (flutter/flutter#184812) 2026-04-09 [email protected] Make `windowing_test` follow repo analyzer rules (flutter/flutter#184752) 2026-04-09 [email protected] Improve documentation of `frictionFactor` function (flutter/flutter#184509) 2026-04-09 [email protected] Roll Skia from d2b0bd12576a to 7c46cb639dba (1 revision) (flutter/flutter#184796) 2026-04-09 [email protected] Roll Fuchsia GN SDK from JLBh4Z9PKsjIJcqDU... to SEfYx3xgueX3aFAY3... (flutter/flutter#184797) 2026-04-09 [email protected] Fixed freeze flow (flutter/flutter#184793) 2026-04-09 [email protected] Roll pub packages (flutter/flutter#184795) 2026-04-09 [email protected] Roll Skia from e9ed4fc9f154 to d2b0bd12576a (36 revisions) (flutter/flutter#184791) 2026-04-08 [email protected] [Android] Allow sensitive content to gracefully fail when unregistering host before registering (flutter/flutter#184789) 2026-04-08 [email protected] Refactor: remove material from autocomplete_test, scrollable_restoration_test, semantics_tester_generate_test_semantics_expression_for_current_semantics_tree_test (flutter/flutter#184615) 2026-04-08 [email protected] Warn about the use of TestSemantics (flutter/flutter#184369) 2026-04-08 [email protected] Change freeze flow to pull_request_target (flutter/flutter#184785) 2026-04-08 [email protected] Update to the beta dart version for 3.44 branch cut. (flutter/flutter#184770) 2026-04-08 [email protected] [Dot shorthands] Migrate examples/api/test (flutter/flutter#183966) 2026-04-08 [email protected] [fuchsia] Give AOT runners the ability to copy FFI callback thunks. (flutter/flutter#184696) 2026-04-08 [email protected] Add await or ignore lint to invokeMethod callsites (flutter/flutter#182870) 2026-04-08 [email protected] Correctly handle failure to read /proc/self/exe link (flutter/flutter#184700) 2026-04-08 [email protected] Roll Skia from e264d870a380 to e9ed4fc9f154 (11 revisions) (flutter/flutter#184713) 2026-04-08 [email protected] Roll Packages from 5299279 to 0e0a032 (5 revisions) (flutter/flutter#184720) 2026-04-08 [email protected] Roll pub packages (flutter/flutter#184772) 2026-04-08 [email protected] Roll Fuchsia Linux SDK from 1rcChbOv4nSTVkUxs... to pDXMXRIjEHTw7B0sk... (flutter/flutter#184722) 2026-04-08 [email protected] Remove navigator_utils cross-imports from cupertino tests (flutter/flutter#184282) 2026-04-08 [email protected] Even more awaits v2 (flutter/flutter#184552) 2026-04-08 [email protected] Allow personal skills to be gitignored (flutter/flutter#184727) 2026-04-08 [email protected] [ci] mac_arm64 build_test re-enable shard 1 presubmit (flutter/flutter#184751) 2026-04-08 [email protected] Fix repo check on code freeze (flutter/flutter#184771) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Part of flutter#181513 --------- Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Kate Lovett <[email protected]>

Even more awaits v2

4bab3aa

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: routes Navigator, Router, and related APIs. labels Apr 3, 2026

gemini-code-assist Bot reviewed Apr 3, 2026

View reviewed changes

victorsanni added the CICD Run CI/CD label Apr 3, 2026

Merge branch 'master' into more-unawaited-error-handling

9b6106a

github-actions Bot removed the CICD Run CI/CD label Apr 3, 2026

victorsanni added the CICD Run CI/CD label Apr 3, 2026

Fix failing test

b394a0e

github-actions Bot removed the CICD Run CI/CD label Apr 3, 2026

Merge branch 'master' into more-unawaited-error-handling

1ce217b

victorsanni added the CICD Run CI/CD label Apr 3, 2026

victorsanni requested a review from dkwingsmt April 3, 2026 20:23

dkwingsmt reviewed Apr 3, 2026

View reviewed changes

victorsanni commented Apr 6, 2026

View reviewed changes

Add error handling and test for _createNewUiKitView

a721469

github-actions Bot removed the CICD Run CI/CD label Apr 6, 2026

Merge branch 'master' into more-unawaited-error-handling

6b98aed

victorsanni requested a review from dkwingsmt April 6, 2026 21:44

victorsanni added the CICD Run CI/CD label Apr 6, 2026

Fix linux analyze

5396070

github-actions Bot removed the CICD Run CI/CD label Apr 7, 2026

Merge branch 'master' into more-unawaited-error-handling

0169142

victorsanni added the CICD Run CI/CD label Apr 7, 2026

dkwingsmt previously approved these changes Apr 8, 2026

View reviewed changes

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2026

auto-submit Bot added this pull request to the merge queue Apr 8, 2026

github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 8, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2026

Merge branch 'master' into more-unawaited-error-handling

ed76766

dkwingsmt approved these changes Apr 8, 2026

View reviewed changes

dkwingsmt added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Apr 8, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2026

Piinks mentioned this pull request Apr 8, 2026

Autosubmit failing to execute #184764

Closed

4 tasks

victorsanni added autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Apr 8, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2026

Piinks added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Apr 8, 2026

Merge branch 'master' into more-unawaited-error-handling

fb83b23

github-actions Bot removed the CICD Run CI/CD label Apr 8, 2026

eyebrowsoffire added the CICD Run CI/CD label Apr 8, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2026

eyebrowsoffire approved these changes Apr 8, 2026

View reviewed changes

eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2026

auto-submit Bot added this pull request to the merge queue Apr 8, 2026

Merged via the queue into flutter:master with commit a443575 Apr 8, 2026
83 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2026

victorsanni deleted the more-unawaited-error-handling branch April 9, 2026 05:02

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2026

a443575b6 Even more awaits v2 (flutter/flutter#184552)

2ade34c

engine-flutter-autoroll mentioned this pull request Apr 9, 2026

Roll Flutter from 05e0ae02600d to 81c87ea165df (27 revisions) flutter/packages#11477

Merged

mbcorona pushed a commit to mbcorona/flutter that referenced this pull request Apr 15, 2026

Even more awaits v2 (flutter#184552)

6d171d2

Part of flutter#181513 --------- Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Kate Lovett <[email protected]>

Conversation

victorsanni commented Apr 3, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Apr 8, 2026

Uh oh!

auto-submit Bot commented Apr 8, 2026

Uh oh!

fluttergithubbot commented Apr 8, 2026

Uh oh!

auto-submit Bot commented Apr 8, 2026

Uh oh!

eyebrowsoffire commented Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dkwingsmt Apr 4, 2026 •

edited

Loading