Repository navigation
Add useLogicalPixels to ResizeImage for logical pixel cache sizing #184549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
2f15554
00a4e2f
683426a
d5a26bb
4ebb86f
7c19dfe
332dab8
a6c4457
33d73e2
c3b34d1
bca9e56
0068006
4290474
70921da
f5c76da
feae619
8f891e1
ad9d840
735b911
8951079
8d67b19
cb98425
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1302,6 +1302,9 @@ class ResizeImage extends ImageProvider<ResizeImageKey> { | |
|
|
||
| /// Whether [width] and [height] are interpreted as logical pixels rather | ||
| /// than physical pixels. | ||
| /// | ||
| /// Set this to true when [width] and [height] describe the image's on-screen | ||
| /// size in logical pixels. | ||
| final bool useLogicalPixels; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we also want to call this out in the docs for
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Specified the pixel type in f5c76da.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Maybe rename to useLogicalSize to match useLogicalCacheSize? Just a thought, up to you.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed to |
||
|
|
||
| /// Composes the `provider` in a [ResizeImage] only when `cacheWidth` and | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done here as well in 735b911.