Skip to content

Reverts "Even more awaits (#184042)"#184426

Closed
auto-submit[bot] wants to merge 1 commit into
masterfrom
revert_697701baedd7d70db8a2dc70be0bdf1fc06b2d28
Closed

Reverts "Even more awaits (#184042)"#184426
auto-submit[bot] wants to merge 1 commit into
masterfrom
revert_697701baedd7d70db8a2dc70be0bdf1fc06b2d28

Conversation

@auto-submit

@auto-submit auto-submit Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Reverts: #184042

Initiated by: bkonyi

Reason for reverting: Breaking tree due to LateInitializationError caused by code similar to tearDownAll(driver.close) which results in driver being accessed immediately before the test is run.

Original PR Author: victorsanni

Reviewed By: {dkwingsmt}

This change reverts the following previous change:
Fixes #184315
Part of #181513

@auto-submit auto-submit Bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Mar 31, 2026
@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. labels Mar 31, 2026
@auto-submit

auto-submit Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

auto label is removed for flutter/flutter/184426, Failed to enqueue flutter/flutter/184426 with HTTP 400: GraphQL mutate failed.

@auto-submit auto-submit Bot removed the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Mar 31, 2026
@gaaclarke

Copy link
Copy Markdown
Member

@bkonyi I think the revert label broke. I'm not sure if there is a way for us to jam this through.

@gaaclarke gaaclarke enabled auto-merge March 31, 2026 20:28
@gaaclarke gaaclarke added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Mar 31, 2026
@auto-submit auto-submit Bot removed the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Mar 31, 2026
@auto-submit

auto-submit Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

auto label is removed for flutter/flutter/184426, Failed to enqueue flutter/flutter/184426 with HTTP 400: GraphQL mutate failed.

@gaaclarke

Copy link
Copy Markdown
Member

I'm going to create a manual revert. I'm not confident this will work.

@gaaclarke

Copy link
Copy Markdown
Member

close in lieu of #184429

@gaaclarke gaaclarke closed this Mar 31, 2026
auto-merge was automatically disabled March 31, 2026 21:17

Pull request was closed

github-merge-queue Bot pushed a commit that referenced this pull request Apr 1, 2026
This reverts commit 697701b.

This is a manual revert from
#184426. That process seems
broken.
ahmedsameha1 pushed a commit to ahmedsameha1/flutter that referenced this pull request Apr 14, 2026
This reverts commit 697701b.

This is a manual revert from
flutter#184426. That process seems
broken.
mbcorona pushed a commit to mbcorona/flutter that referenced this pull request Apr 15, 2026
This reverts commit 697701b.

This is a manual revert from
flutter#184426. That process seems
broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

examples/: missing await on FlutterDriver.close() in 3 test drivers

3 participants