Repository navigation
Conversation
Move the API 31 fontWeightAdjustment field access behind a dedicated helper so the direct field reference stays out of AccessibilityBridge's main code path. Also fall back to bold-text unsupported if an affected runtime still throws NoSuchFieldError during startup. See flutter#184286.
github-actions
Bot
added
platform-android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fontWeightAdjustmentfield access behind a dedicated helper inengine/src/flutter/shell/platform/android/io/flutter/view/AccessibilityBridge.java@DoNotInlineso the field access stays out of the main code pathNoSuchFieldErrorContext
This follows up on #184286.
AndroidX Compose hardened the same access pattern in July 2024, and this mirrors that shape while keeping the engine change to a single file.
I do not have a public repro project yet, so I am opening this as a draft to get feedback on the patch shape before I spend more time on a standalone reproducer.