Remove clipboard_utils cross-imports from material and cupertino tests by xfce0 · Pull Request #184278 · flutter/flutter

xfce0 · 2026-03-28T12:45:53Z

MockClipboard is a small (30-line) test utility with a trivial implementation, so duplication is the appropriate strategy per the issue guidelines. The file is copied into both test/material/ and
test/cupertino/, and all imports are updated to reference the local copy.

Pre-launch Checklist

gemini-code-assist

Code Review

This pull request relocates the MockClipboard utility to the cupertino and material test directories and updates several test files to use these local versions. Review feedback identifies a missing break statement in the Clipboard.setData case of the handleMethodCall method and recommends replacing the dynamic type for clipboardData with Map<String, dynamic> to improve type safety and align with Effective Dart guidelines.

gemini-code-assist · 2026-03-28T12:47:38Z

+  dynamic clipboardData = <String, dynamic>{'text': null};
+
+  Future<Object?> handleMethodCall(MethodCall methodCall) async {
+    switch (methodCall.method) {
+      case 'Clipboard.getData':
+        return clipboardData;
+      case 'Clipboard.hasStrings':
+        if (hasStringsThrows) {
+          throw Exception();
+        }
+        final clipboardDataMap = clipboardData as Map<String, dynamic>?;
+        final text = clipboardDataMap?['text'] as String?;
+        return <String, bool>{'value': text != null && text.isNotEmpty};
+      case 'Clipboard.setData':
+        clipboardData = methodCall.arguments;
+    }
+    return null;
+  }


There are a couple of issues here:

The clipboardData field is dynamic. For better type safety and readability, it should be strongly typed as Map<String, dynamic>. This aligns with Effective Dart guidelines to avoid dynamic.

The case 'Clipboard.setData' is missing a break; statement, which will cause a compilation error as Dart does not allow fall-through in non-empty case blocks.

The suggested change addresses both points.

Suggested change

dynamic clipboardData = <String, dynamic>{'text': null};

Future<Object?> handleMethodCall(MethodCall methodCall) async {

switch (methodCall.method) {

case 'Clipboard.getData':

return clipboardData;

case 'Clipboard.hasStrings':

if (hasStringsThrows) {

throw Exception();

}

final clipboardDataMap = clipboardData as Map<String, dynamic>?;

final text = clipboardDataMap?['text'] as String?;

return <String, bool>{'value': text != null && text.isNotEmpty};

case 'Clipboard.setData':

clipboardData = methodCall.arguments;

}

return null;

}

Map<String, dynamic> clipboardData = <String, dynamic>{'text': null};

Future<Object?> handleMethodCall(MethodCall methodCall) async {

switch (methodCall.method) {

case 'Clipboard.getData':

return clipboardData;

case 'Clipboard.hasStrings':

if (hasStringsThrows) {

throw Exception();

}

final text = clipboardData['text'] as String?;

return <String, bool>{'value': text != null && text.isNotEmpty};

case 'Clipboard.setData':

clipboardData = methodCall.arguments as Map<String, dynamic>;

break;

}

return null;

}

References

The repository style guide recommends following Effective Dart (line 20), which advises against using dynamic when a more specific type is available. Using Map<String, dynamic> improves readability and type safety. ^(link)

Good catch, fixed both issues — typed clipboardData as Map<String, dynamic> and added break. Applied to both copies. Thanks!

gemini-code-assist · 2026-03-28T12:47:38Z

+  dynamic clipboardData = <String, dynamic>{'text': null};
+
+  Future<Object?> handleMethodCall(MethodCall methodCall) async {
+    switch (methodCall.method) {
+      case 'Clipboard.getData':
+        return clipboardData;
+      case 'Clipboard.hasStrings':
+        if (hasStringsThrows) {
+          throw Exception();
+        }
+        final clipboardDataMap = clipboardData as Map<String, dynamic>?;
+        final text = clipboardDataMap?['text'] as String?;
+        return <String, bool>{'value': text != null && text.isNotEmpty};
+      case 'Clipboard.setData':
+        clipboardData = methodCall.arguments;
+    }
+    return null;
+  }


There are a couple of issues here:

The clipboardData field is dynamic. For better type safety and readability, it should be strongly typed as Map<String, dynamic>. This aligns with Effective Dart guidelines to avoid dynamic.

The case 'Clipboard.setData' is missing a break; statement, which will cause a compilation error as Dart does not allow fall-through in non-empty case blocks.

The suggested change addresses both points.

Suggested change

dynamic clipboardData = <String, dynamic>{'text': null};

Future<Object?> handleMethodCall(MethodCall methodCall) async {

switch (methodCall.method) {

case 'Clipboard.getData':

return clipboardData;

case 'Clipboard.hasStrings':

if (hasStringsThrows) {

throw Exception();

}

final clipboardDataMap = clipboardData as Map<String, dynamic>?;

final text = clipboardDataMap?['text'] as String?;

return <String, bool>{'value': text != null && text.isNotEmpty};

case 'Clipboard.setData':

clipboardData = methodCall.arguments;

}

return null;

}

Map<String, dynamic> clipboardData = <String, dynamic>{'text': null};

Future<Object?> handleMethodCall(MethodCall methodCall) async {

switch (methodCall.method) {

case 'Clipboard.getData':

return clipboardData;

case 'Clipboard.hasStrings':

if (hasStringsThrows) {

throw Exception();

}

final text = clipboardData['text'] as String?;

return <String, bool>{'value': text != null && text.isNotEmpty};

case 'Clipboard.setData':

clipboardData = methodCall.arguments as Map<String, dynamic>;

break;

}

return null;

}

References

The repository style guide recommends following Effective Dart (line 20), which advises against using dynamic when a more specific type is available. Using Map<String, dynamic> improves readability and type safety. ^(link)

Same fix applied here as well.

victorsanni · 2026-04-01T21:14:06Z

Hi @xfce0, this PR is currently targeting main, can you repurpose it to target master? Thanks.

justinmc

LGTM 👍 .I think I agree with the decision to duplicate here. We could always move it to flutter_test later if people want to use it. Thanks for helping out with this migration!

The base branch was changed.

xfce0 · 2026-04-02T09:00:55Z

Done, retargeted to master. Thank you!

xfce0 · 2026-04-03T10:12:04Z

Rebased onto the latest master.

justinmc

LGTM 👍

flutter-dashboard · 2026-04-04T00:59:49Z

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

victorsanni · 2026-04-04T01:00:03Z

Hi @xfce0, can you fix the merge conflict in this PR?

justinmc

LGTM. There were analyzer failures again but I've pushed a merge commit to hopefully resolve them.

victorsanni

Thanks for this PR. Can you run dart format packages/flutter/test/material/adaptive_text_selection_toolbar_test.dart packages/flutter/test/material/text_selection_test.dart packages/flutter/test/material/selectable_text_test.dart packages/flutter/test/cupertino/text_field_test.dart packages/flutter/test/material/text_field_test.dart

to fix the failing linux analyze check? Thanks!

fluttergithubbot · 2026-05-10T09:33:22Z

An existing Git SHA, b9009e248f9adce0ee78f2ac61b153ed64882dbc, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

AbdeMohlbi · 2026-05-12T08:11:20Z

@xfce0 can you format the files again ?

dkwingsmt · 2026-05-20T18:15:09Z

Seems like there are still some analyzer error left. (from triage)

xfce0 · 2026-05-29T12:03:11Z

Hi @justinmc @victorsanni — all CI checks are now passing (87 checks green). Could you please re-review when you have a moment? Thanks!

justinmc

So sorry for all of the back and forth here, but would it be possible to undo the formatting changes? The formatting check is now disabled so the PR should still pass.

gemini-code-assist Bot reviewed Mar 28, 2026

View reviewed changes

dkwingsmt added this to Test cross-imports Review Queue Apr 1, 2026

github-project-automation Bot moved this to Todo in Test cross-imports Review Queue Apr 1, 2026

victorsanni previously approved these changes Apr 1, 2026

View reviewed changes

victorsanni requested a review from justinmc April 1, 2026 21:17

justinmc previously approved these changes Apr 1, 2026

View reviewed changes

justinmc added the CICD Run CI/CD label Apr 1, 2026

justinmc mentioned this pull request Apr 1, 2026

(Test cross-imports) Don't cross-import test utils #182636

Open

github-actions Bot removed the CICD Run CI/CD label Apr 1, 2026

xfce0 changed the base branch from main to master April 2, 2026 08:48

xfce0 force-pushed the fix-test-cross-imports branch from a47d8f9 to 03bc3fb Compare April 2, 2026 09:00

loic-sharma requested a review from justinmc April 2, 2026 20:38

xfce0 force-pushed the fix-test-cross-imports branch from 03bc3fb to 51464b3 Compare April 3, 2026 10:13

justinmc previously approved these changes Apr 3, 2026

View reviewed changes

victorsanni previously approved these changes Apr 4, 2026

View reviewed changes

victorsanni added the CICD Run CI/CD label Apr 4, 2026

xfce0 dismissed stale reviews from victorsanni and justinmc via 7f4a285 April 4, 2026 05:41

xfce0 force-pushed the fix-test-cross-imports branch from 51464b3 to 7f4a285 Compare April 4, 2026 05:41

dkwingsmt requested review from justinmc and victorsanni May 6, 2026 18:20

github-actions Bot removed the CICD Run CI/CD label May 6, 2026

justinmc previously approved these changes May 6, 2026

View reviewed changes

justinmc added the CICD Run CI/CD label May 6, 2026

github-actions Bot removed the CICD Run CI/CD label May 8, 2026

victorsanni previously approved these changes May 8, 2026

View reviewed changes

victorsanni added the CICD Run CI/CD label May 8, 2026

xfce0 dismissed stale reviews from victorsanni and justinmc via b9009e2 May 10, 2026 09:32

xfce0 force-pushed the fix-test-cross-imports branch from 166dd19 to b9009e2 Compare May 10, 2026 09:32

github-actions Bot removed the CICD Run CI/CD label May 10, 2026

AbdeMohlbi added the CICD Run CI/CD label May 10, 2026

github-actions Bot removed the CICD Run CI/CD label May 10, 2026

AbdeMohlbi added the CICD Run CI/CD label May 10, 2026

github-actions Bot removed the CICD Run CI/CD label May 10, 2026

xfce0 force-pushed the fix-test-cross-imports branch from 9c81ec8 to f909984 Compare May 10, 2026 16:30

AbdeMohlbi added the CICD Run CI/CD label May 11, 2026

xfce0 added 5 commits May 23, 2026 13:49

Remove clipboard_utils cross-imports from material and cupertino tests

ccd654f

Fix analyzer issues: directives_ordering and unnecessary_breaks

d17775d

Trigger Build

d889e7e

Trigger CI run

e56fd24

Fix formatting in test files using Flutter dart format

a2c6a9f

victorsanni approved these changes May 29, 2026

View reviewed changes

justinmc reviewed Jun 4, 2026

View reviewed changes

justinmc mentioned this pull request Jun 4, 2026

Remove feedback_tester cross-imports from material tests #184279

Open

10 tasks

Conversation

xfce0 commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

xfce0 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

xfce0 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

victorsanni commented Apr 1, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

xfce0 commented Apr 2, 2026

Uh oh!

xfce0 commented Apr 3, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard Bot commented Apr 4, 2026

Uh oh!

victorsanni commented Apr 4, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

fluttergithubbot commented May 10, 2026

Uh oh!

AbdeMohlbi commented May 12, 2026

Uh oh!

dkwingsmt commented May 20, 2026

Uh oh!

xfce0 commented May 29, 2026

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

xfce0 commented Mar 28, 2026 •

edited

Loading