[data_assets] Cleanup tests#184209
Conversation
9b26dbe to
c727628
Compare
c727628 to
b91ad02
Compare
b91ad02 to
a0230a7
Compare
a0230a7 to
0e4e081
Compare
|
@jtmcdole I'm not sure who to ping on this one. You? If not please cc the right person. I can't seem to get the bots happy with new integration test projects:
What is the way forward here? (Having test projects in Dart Strings is not the way forward IMO, that's what this PR is trying to fix.) |
2656b4c to
7c67468
Compare
|
auto label is removed for flutter/flutter/184209, Failed to enqueue flutter/flutter/184209 with HTTP 400: GraphQL mutate failed. |
Hi @dcharkes, it looks like this PR is the first commit that fails I've suppressed it while investigating it |
@hellohuanlin It looks like this PR might have made the test slower? I didn't change the test significantly it still runs the same amount of Flutter commands. (But 16 minutes to 35-36 minutes is a big jump!) Edit: I don't see the test that I changed in the relevant logs. Maybe something else became slower? |
|
@dcharkes noob question: how can you tell it fails because things get slower? I think i'm gonna revert it first. the longer we suppress the test the higher the risk. |
|
Reason for revert: breaks the tree |
This reverts commit e13b5e6.
flutter/flutter@0f401ee...7245c3f 2026-04-03 [email protected] Roll Skia from c07c67045b6d to 5d847ba5c4aa (1 revision) (flutter/flutter#184570) 2026-04-03 [email protected] Roll Dart SDK from 3c7a79045b8b to 46f49142acd9 (1 revision) (flutter/flutter#184567) 2026-04-03 [email protected] Roll ICU from ee5f27adc28b to ff7995a708a1 (5 revisions) (flutter/flutter#184566) 2026-04-03 [email protected] Roll Skia from 9ae8231be181 to c07c67045b6d (4 revisions) (flutter/flutter#184562) 2026-04-03 [email protected] Roll Fuchsia Linux SDK from BFLjk6Uwd0gs_Hkdk... to PpL3Bn2YMb2h9LbdK... (flutter/flutter#184556) 2026-04-03 [email protected] Roll Skia from 0566b2f5f0d1 to 9ae8231be181 (1 revision) (flutter/flutter#184547) 2026-04-03 [email protected] Roll Dart SDK from 6008eaddd589 to 3c7a79045b8b (3 revisions) (flutter/flutter#184551) 2026-04-03 [email protected] Fix wide gamut macos integration test (flutter/flutter#184427) 2026-04-02 [email protected] forward an application name to DDS (flutter/flutter#184459) 2026-04-02 [email protected] Roll Skia from 973117cfa875 to 0566b2f5f0d1 (8 revisions) (flutter/flutter#184534) 2026-04-02 [email protected] Support different joins for stroked rects in uber_sdf, fix incorrect aa (flutter/flutter#184395) 2026-04-02 [email protected] [ Widget Preview ] Handle collections and records in custom preview annotations (flutter/flutter#184518) 2026-04-02 [email protected] Moves android_semantics_integration_test out of staging (flutter/flutter#184079) 2026-04-02 [email protected] Roll Packages from b3fcf14 to 66bf7ec (4 revisions) (flutter/flutter#184514) 2026-04-02 [email protected] Fix line breaks being lost when copying after selection gesture in SelectableRegion (flutter/flutter#184421) 2026-04-02 [email protected] Add plugin version to SwiftPM package symlink directory (flutter/flutter#183668) 2026-04-02 [email protected] Add our own wrapper for `CommonExtension` due to change in signature from 8.x->9.0 (flutter/flutter#184433) 2026-04-02 [email protected] [Android] Use EdgeToEdge.enable/WindowCompat for edge-to-edge mode instead of deprecated View flags (flutter/flutter#183072) 2026-04-02 [email protected] [data_assets] Cleanup tests (flutter/flutter#184209) 2026-04-02 [email protected] Enable SPM by default on Stable (flutter/flutter#184495) 2026-04-02 [email protected] Roll Dart SDK from d84bdfeb45eb to 6008eaddd589 (2 revisions) (flutter/flutter#184513) 2026-04-02 [email protected] Reland "Even more awaits" (flutter/flutter#184467) 2026-04-02 [email protected] Roll Skia from bb9fd8653739 to 973117cfa875 (2 revisions) (flutter/flutter#184498) 2026-04-02 [email protected] [ Widget Preview ] Use analysis server for widget preview detection (flutter/flutter#184473) 2026-04-02 [email protected] [web_ui] Fix avoid_type_to_string lint violation (flutter/flutter#184342) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
<!-- start_original_pr_link --> Reverts: #184209 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: hellohuanlin <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Breaks `Mac_x64 build_tests_2_4`. See https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_x64%20build_tests_2_4/11979/overview. Test running time regressed from 15-16 minutes ish to 36 minutes. The tree is toggling between red & green, so i guess our timeout is likely close to 35 minutes or so? <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: dcharkes <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {goderbauer} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This cleans up the data_assets experiment testing. * Use integration test projects, which are statically analyzed, formatted, etc. * This forces us to be explicit about the `package:data_assets` dependency. * This means the test projects will roll their dependencies with the dependency auto roller. (The test project was still using `native_assets_cli` which has been replaced with `hooks` and `data_assets`.) * Pin `package:data_assets`, because it's experimental, and we might do breaking changes. Also makes the test projects more useful: * The `data_assets_app` now displays the assets in the UI. (Not only prints to the console for the integration tests.) * The `data_assets_package` now actually uses its asset. And cleans up the test projects: * Move the test files into the `data/` dir. * Give the test data assets a proper extension. I saw weird behavior on Windows: * DevFS doesn't pick up the writes to the Dart files, not even with flushing or sleeps: `Compiling dart to kernel with 0 updated files` leading to a state where the Dart variable contents don't get updated while the data assets do. This integration test is not really about Dart hot restart, so I've skipped those checks on Windows. * This reproduces locally in the integration test, but not when running the app and editing the file. The checks in dev/bots/analyze.dart also required some updates: * The template files check didn't allow for the HTML license. P.S. Sorry for all the generated Flutter scaffolding. It seems that that is the way it's done in the integration test directory. (The package with the data assets is clean, but the Flutter app ...) <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
|
This PR caused the The This PR added a new test to It should be possible to reland this PR by increasing the number of |
|
Thanks for the help @jason-simmons 🙏 |
Relands #184209 adding a mac shard as suggested in #184209 (comment). For adding a shard, I followed #154444, which suggests it's contained in the single `.ci.yaml` file, and the new shard names need to have `bringup: true`. ---- Original PR description: This cleans up the data_assets experiment testing. * Use integration test projects, which are statically analyzed, formatted, etc. * This forces us to be explicit about the `package:data_assets` dependency. * This means the test projects will roll their dependencies with the dependency auto roller. (The test project was still using `native_assets_cli` which has been replaced with `hooks` and `data_assets`.) * Pin `package:data_assets`, because it's experimental, and we might do breaking changes. Also makes the test projects more useful: * The `data_assets_app` now displays the assets in the UI. (Not only prints to the console for the integration tests.) * The `data_assets_package` now actually uses its asset. And cleans up the test projects: * Move the test files into the `data/` dir. * Give the test data assets a proper extension. I saw weird behavior on Windows: * DevFS doesn't pick up the writes to the Dart files, not even with flushing or sleeps: `Compiling dart to kernel with 0 updated files` leading to a state where the Dart variable contents don't get updated while the data assets do. This integration test is not really about Dart hot restart, so I've skipped those checks on Windows. * This reproduces locally in the integration test, but not when running the app and editing the file. The checks in dev/bots/analyze.dart also required some updates: * The template files check didn't allow for the HTML license. P.S. Sorry for all the generated Flutter scaffolding. It seems that that is the way it's done in the integration test directory. (The package with the data assets is clean, but the Flutter app ...)
This cleans up the data_assets experiment testing. * Use integration test projects, which are statically analyzed, formatted, etc. * This forces us to be explicit about the `package:data_assets` dependency. * This means the test projects will roll their dependencies with the dependency auto roller. (The test project was still using `native_assets_cli` which has been replaced with `hooks` and `data_assets`.) * Pin `package:data_assets`, because it's experimental, and we might do breaking changes. Also makes the test projects more useful: * The `data_assets_app` now displays the assets in the UI. (Not only prints to the console for the integration tests.) * The `data_assets_package` now actually uses its asset. And cleans up the test projects: * Move the test files into the `data/` dir. * Give the test data assets a proper extension. I saw weird behavior on Windows: * DevFS doesn't pick up the writes to the Dart files, not even with flushing or sleeps: `Compiling dart to kernel with 0 updated files` leading to a state where the Dart variable contents don't get updated while the data assets do. This integration test is not really about Dart hot restart, so I've skipped those checks on Windows. * This reproduces locally in the integration test, but not when running the app and editing the file. The checks in dev/bots/analyze.dart also required some updates: * The template files check didn't allow for the HTML license. P.S. Sorry for all the generated Flutter scaffolding. It seems that that is the way it's done in the integration test directory. (The package with the data assets is clean, but the Flutter app ...)
<!-- start_original_pr_link --> Reverts: flutter#184209 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: hellohuanlin <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: Breaks `Mac_x64 build_tests_2_4`. See https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_x64%20build_tests_2_4/11979/overview. Test running time regressed from 15-16 minutes ish to 36 minutes. The tree is toggling between red & green, so i guess our timeout is likely close to 35 minutes or so? <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: dcharkes <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {goderbauer} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This cleans up the data_assets experiment testing. * Use integration test projects, which are statically analyzed, formatted, etc. * This forces us to be explicit about the `package:data_assets` dependency. * This means the test projects will roll their dependencies with the dependency auto roller. (The test project was still using `native_assets_cli` which has been replaced with `hooks` and `data_assets`.) * Pin `package:data_assets`, because it's experimental, and we might do breaking changes. Also makes the test projects more useful: * The `data_assets_app` now displays the assets in the UI. (Not only prints to the console for the integration tests.) * The `data_assets_package` now actually uses its asset. And cleans up the test projects: * Move the test files into the `data/` dir. * Give the test data assets a proper extension. I saw weird behavior on Windows: * DevFS doesn't pick up the writes to the Dart files, not even with flushing or sleeps: `Compiling dart to kernel with 0 updated files` leading to a state where the Dart variable contents don't get updated while the data assets do. This integration test is not really about Dart hot restart, so I've skipped those checks on Windows. * This reproduces locally in the integration test, but not when running the app and editing the file. The checks in dev/bots/analyze.dart also required some updates: * The template files check didn't allow for the HTML license. P.S. Sorry for all the generated Flutter scaffolding. It seems that that is the way it's done in the integration test directory. (The package with the data assets is clean, but the Flutter app ...) <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
Relands flutter#184209 adding a mac shard as suggested in flutter#184209 (comment). For adding a shard, I followed flutter#154444, which suggests it's contained in the single `.ci.yaml` file, and the new shard names need to have `bringup: true`. ---- Original PR description: This cleans up the data_assets experiment testing. * Use integration test projects, which are statically analyzed, formatted, etc. * This forces us to be explicit about the `package:data_assets` dependency. * This means the test projects will roll their dependencies with the dependency auto roller. (The test project was still using `native_assets_cli` which has been replaced with `hooks` and `data_assets`.) * Pin `package:data_assets`, because it's experimental, and we might do breaking changes. Also makes the test projects more useful: * The `data_assets_app` now displays the assets in the UI. (Not only prints to the console for the integration tests.) * The `data_assets_package` now actually uses its asset. And cleans up the test projects: * Move the test files into the `data/` dir. * Give the test data assets a proper extension. I saw weird behavior on Windows: * DevFS doesn't pick up the writes to the Dart files, not even with flushing or sleeps: `Compiling dart to kernel with 0 updated files` leading to a state where the Dart variable contents don't get updated while the data assets do. This integration test is not really about Dart hot restart, so I've skipped those checks on Windows. * This reproduces locally in the integration test, but not when running the app and editing the file. The checks in dev/bots/analyze.dart also required some updates: * The template files check didn't allow for the HTML license. P.S. Sorry for all the generated Flutter scaffolding. It seems that that is the way it's done in the integration test directory. (The package with the data assets is clean, but the Flutter app ...)


This cleans up the data_assets experiment testing.
package:data_assetsdependency.native_assets_cliwhich has been replaced withhooksanddata_assets.)package:data_assets, because it's experimental, and we might do breaking changes.Also makes the test projects more useful:
data_assets_appnow displays the assets in the UI. (Not only prints to the console for the integration tests.)data_assets_packagenow actually uses its asset.And cleans up the test projects:
data/dir.I saw weird behavior on Windows:
Compiling dart to kernel with 0 updated filesleading to a state where the Dart variable contents don't get updated while the data assets do. This integration test is not really about Dart hot restart, so I've skipped those checks on Windows.The checks in dev/bots/analyze.dart also required some updates:
P.S. Sorry for all the generated Flutter scaffolding. It seems that that is the way it's done in the integration test directory. (The package with the data assets is clean, but the Flutter app ...)