Skip to content

Remove unused FlutterRunArguments.java file #184160

Merged
auto-submit[bot] merged 8 commits into
flutter:masterfrom
AbdeMohlbi:remove_unused_file
Apr 17, 2026
Merged

Remove unused FlutterRunArguments.java file #184160
auto-submit[bot] merged 8 commits into
flutter:masterfrom
AbdeMohlbi:remove_unused_file

Conversation

@AbdeMohlbi

@AbdeMohlbi AbdeMohlbi commented Mar 25, 2026

Copy link
Copy Markdown
Member

This change removes an unused file.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions Bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Mar 25, 2026
@AbdeMohlbi AbdeMohlbi added the CICD Run CI/CD label Mar 25, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Mar 25, 2026
@AbdeMohlbi AbdeMohlbi added the CICD Run CI/CD label Mar 25, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Mar 26, 2026
@AbdeMohlbi AbdeMohlbi added the CICD Run CI/CD label Mar 26, 2026
@AbdeMohlbi AbdeMohlbi changed the title remove unused files Remove unused FlutterRunArguments.java file Mar 26, 2026
@AbdeMohlbi
AbdeMohlbi marked this pull request as ready for review March 26, 2026 17:15
@AbdeMohlbi
AbdeMohlbi requested a review from a team as a code owner March 26, 2026 17:15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the FlutterRunArguments.java source file and its reference in the Android platform's BUILD.gn file. I have no feedback to provide.

@gaaclarke
gaaclarke requested a review from camsim99 March 30, 2026 17:51
@AbdeMohlbi AbdeMohlbi added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2026
@auto-submit

auto-submit Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/184160, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@AbdeMohlbi AbdeMohlbi added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Apr 1, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2026
@auto-submit

auto-submit Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/184160, because - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 9, 2026
@AbdeMohlbi AbdeMohlbi added the CICD Run CI/CD label Apr 9, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 13, 2026
@camsim99 camsim99 added the CICD Run CI/CD label Apr 13, 2026
@camsim99

Copy link
Copy Markdown
Contributor

@AbdeMohlbi Do you mind taking a look at the test failures?

@AbdeMohlbi AbdeMohlbi added CICD Run CI/CD and removed CICD Run CI/CD labels Apr 14, 2026
@AbdeMohlbi
AbdeMohlbi requested review from camsim99 and removed request for camsim99 April 14, 2026 22:27
@AbdeMohlbi AbdeMohlbi added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2026
@auto-submit

auto-submit Bot commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/184160, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@AbdeMohlbi

Copy link
Copy Markdown
Member Author

Is it possible that this file is used somewhere which causes the google tests to fail, @reidbaker can you please take a look when you have time ?

@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 15, 2026
@camsim99

Copy link
Copy Markdown
Contributor

The failures don't look related. My guess is we need this PR to pick up #185082

@camsim99 camsim99 added the CICD Run CI/CD label Apr 15, 2026
@AbdeMohlbi AbdeMohlbi added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Apr 17, 2026
Merged via the queue into flutter:master with commit c5e3c2f Apr 17, 2026
197 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 17, 2026
flutter/flutter@31f1802...8e8a194

2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203)
2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199)
2026-04-17 [email protected] [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151)
2026-04-17 [email protected] Remove unused `FlutterRunArguments.java` file  (flutter/flutter#184160)
2026-04-17 [email protected] Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192)
2026-04-17 [email protected] [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913)
2026-04-17 [email protected] `AnimationStyle` methods (flutter/flutter#182333)
2026-04-17 [email protected] Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332)
2026-04-17 [email protected] Revert "Unpin sdk package dependencies" (flutter/flutter#185186)
2026-04-16 [email protected] Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995)
2026-04-16 [email protected] Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173)
2026-04-16 [email protected] Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033)
2026-04-16 [email protected] [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112)
2026-04-16 [email protected] Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159)
2026-04-16 [email protected] [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051)
2026-04-16 [email protected] [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991)
2026-04-16 [email protected] Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143)
2026-04-16 [email protected] Unpin sdk package dependencies (flutter/flutter#184821)
2026-04-16 [email protected] Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643)
2026-04-16 [email protected] Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141)
2026-04-16 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185166)
2026-04-16 [email protected] Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…r#11523)

flutter/flutter@31f1802...8e8a194

2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203)
2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199)
2026-04-17 [email protected] [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151)
2026-04-17 [email protected] Remove unused `FlutterRunArguments.java` file  (flutter/flutter#184160)
2026-04-17 [email protected] Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192)
2026-04-17 [email protected] [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913)
2026-04-17 [email protected] `AnimationStyle` methods (flutter/flutter#182333)
2026-04-17 [email protected] Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332)
2026-04-17 [email protected] Revert "Unpin sdk package dependencies" (flutter/flutter#185186)
2026-04-16 [email protected] Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995)
2026-04-16 [email protected] Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173)
2026-04-16 [email protected] Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033)
2026-04-16 [email protected] [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112)
2026-04-16 [email protected] Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159)
2026-04-16 [email protected] [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051)
2026-04-16 [email protected] [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991)
2026-04-16 [email protected] Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143)
2026-04-16 [email protected] Unpin sdk package dependencies (flutter/flutter#184821)
2026-04-16 [email protected] Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643)
2026-04-16 [email protected] Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141)
2026-04-16 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185166)
2026-04-16 [email protected] Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-android Android applications specifically team-android Owned by Android platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants