[iOS] Clarify provisioning profile error instructions#184051
Conversation
c2f0972 to
0745d22
Compare
….com/mozammal-hossain/flutter into fix/167595-ios-signing-error-message * 'fix/167595-ios-signing-error-message' of https://github.com/mozammal-hossain/flutter: [iOS] Clarify provisioning profile error instructions Roll Dart SDK from 788e347194a6 to f504293598f2 (1 revision) (flutter#184048) Roll Skia from fb6acef456ea to 62841a512deb (2 revisions) (flutter#184046) [Slider] Remove value indicator painter when animation is dismissed (flutter#182991) Manual roll ICU from 7971660ba630 to ee5f27adc28b (1 revision) (flutter#184041) Add scrollPadding property to DropdownMenu (flutter#183109) Roll pub packages (flutter#183895) Roll Skia from c2b58922e37d to fb6acef456ea (1 revision) (flutter#184033) Roll Dart SDK from b172bea4f008 to 788e347194a6 (2 revisions) (flutter#184035) chore: deflake Linux_android_emu android_display_cutout (flutter#183522) Add note about gclient sync network failures and workaround (flutter#183794) Roll Skia from a81bf411a5cb to c2b58922e37d (3 revisions) (flutter#184016) refactor(web): use positive logic and platform defaults for accessibility features (flutter#183907) [android][a11y] set "android.widget.ProgressBar" according to semantics role (flutter#183897) Add progress bar to artifact downloads (flutter#182836) Add windows instruction to `Forcing Flutter Tools Snapshot Regeneration` (flutter#183977)
There was a problem hiding this comment.
Code Review
This pull request improves the clarity of the iOS provisioning profile error message, making it more actionable for developers. The changes are well-implemented and include corresponding test updates. I have one minor suggestion to improve consistency in the command-line output.
| logger.printError(' 2. In Runner > Signing & Capabilities, verify:'); | ||
| logger.printError( | ||
| 'Verify that the Bundle Identifier in your project is your signing id in Xcode', | ||
| ' - Team is selected and valid for your Apple Developer account', |
There was a problem hiding this comment.
Nit: "Team" is set to a valid Apple Developer account
There was a problem hiding this comment.
Updated as per your suggestion
| ' - Team is selected and valid for your Apple Developer account', | ||
| ); | ||
| logger.printError(' open ios/Runner.xcworkspace'); | ||
| logger.printError(' - Bundle Identifier matches your provisioning profile'); |
There was a problem hiding this comment.
This is a bit unclear. Most people would just use auto managed profile
There was a problem hiding this comment.
Updated this line. Is it ok now?
| logger.printError( | ||
| 'Verify that the Bundle Identifier in your project is your signing id in Xcode', | ||
| ' - Bundle Identifier is correct for your app (with automatic signing, ' | ||
| 'Xcode manages the provisioning profile)', |
There was a problem hiding this comment.
It's possible that developers don't use automatic signing. Can you mention both cases? (one with automatic signing, and one with manual signing)?
There was a problem hiding this comment.
Updated. this time, I've explicitly mentioned, automatic and manual signing.
|
@LouiseHsu , I've updated this branch with the flutter main branch. Could you please review it again? |
LouiseHsu
left a comment
There was a problem hiding this comment.
lgtm, can you fix the failing analyze test?
ok, I'm on it. |
|
I've given single quote on the log messages |
|
This branch was behind of flutter main, so it has blocked by github action. could you please add the ci/cd again? |
|
@LouiseHsu would you like to approve this PR, as it has passed all the test caes? |
|
@hellohuanlin please approve this PR. |
i was going to approve last week but looks like google testing is stuck. let me try again. |
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
|
@hellohuanlin could you please approve it again? |
flutter/flutter@31f1802...8e8a194 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203) 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199) 2026-04-17 [email protected] [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151) 2026-04-17 [email protected] Remove unused `FlutterRunArguments.java` file (flutter/flutter#184160) 2026-04-17 [email protected] Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192) 2026-04-17 [email protected] [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913) 2026-04-17 [email protected] `AnimationStyle` methods (flutter/flutter#182333) 2026-04-17 [email protected] Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332) 2026-04-17 [email protected] Revert "Unpin sdk package dependencies" (flutter/flutter#185186) 2026-04-16 [email protected] Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995) 2026-04-16 [email protected] Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173) 2026-04-16 [email protected] Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033) 2026-04-16 [email protected] [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112) 2026-04-16 [email protected] Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159) 2026-04-16 [email protected] [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051) 2026-04-16 [email protected] [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991) 2026-04-16 [email protected] Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143) 2026-04-16 [email protected] Unpin sdk package dependencies (flutter/flutter#184821) 2026-04-16 [email protected] Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643) 2026-04-16 [email protected] Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141) 2026-04-16 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185166) 2026-04-16 [email protected] Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#11523) flutter/flutter@31f1802...8e8a194 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (#184643)" (flutter/flutter#185203) 2026-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (#185192)" (flutter/flutter#185199) 2026-04-17 [email protected] [iOS] Migrate FlutterLaunchEngine to Swift (flutter/flutter#185151) 2026-04-17 [email protected] Remove unused `FlutterRunArguments.java` file (flutter/flutter#184160) 2026-04-17 [email protected] Roll Fuchsia Test Scripts from R2EllDf4DgBXVNuiN... to dQ4PjIJB5kZFU8Y32... (flutter/flutter#185192) 2026-04-17 [email protected] [Impeller] Fix morphology filter asymmetric dilation/erosion (flutter/flutter#184913) 2026-04-17 [email protected] `AnimationStyle` methods (flutter/flutter#182333) 2026-04-17 [email protected] Fix _scheduleSystemFontsUpdate assertion during non-idle scheduler phase (flutter/flutter#184332) 2026-04-17 [email protected] Revert "Unpin sdk package dependencies" (flutter/flutter#185186) 2026-04-16 [email protected] Clarify why the `child` is nullable in `AnimatedTransitionBuilder` (flutter/flutter#182995) 2026-04-16 [email protected] Roll Fuchsia Linux SDK from IdBT8fSMYrYSip65j... to di3JdYrdE9OFu8Iyl... (flutter/flutter#185173) 2026-04-16 [email protected] Add dart_skills_lint to dev/tool with test and update readme instructions for new skills authors (flutter/flutter#185033) 2026-04-16 [email protected] [Impeller] Provide std::optional getter for stroke property (flutter/flutter#185112) 2026-04-16 [email protected] Validate itemExtent with geometry in RenderSliverFixedExtentBoxAdaptor (flutter/flutter#185159) 2026-04-16 [email protected] [iOS] Clarify provisioning profile error instructions (flutter/flutter#184051) 2026-04-16 [email protected] [Widget Preview] Fix flaky integration test timeout during flutter clean (flutter/flutter#184991) 2026-04-16 [email protected] Roll Dart SDK from fbddcbe0cd96 to 7c2564c18770 (2 revisions) (flutter/flutter#185143) 2026-04-16 [email protected] Unpin sdk package dependencies (flutter/flutter#184821) 2026-04-16 [email protected] Fix ImageInfo.isCloneOf to correctly compare scale values (fixes #184626) (flutter/flutter#184643) 2026-04-16 [email protected] Roll Skia from 391cdbe3ffe9 to d8415c5d7b91 (2 revisions) (flutter/flutter#185141) 2026-04-16 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#185166) 2026-04-16 [email protected] Revert "Move widget_preview_scaffold into pub workspace" (flutter/flutter#185164) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
What is this PR changing or adding, and why?
This PR improves the iOS provisioning profile/code-signing failure message in
flutter_toolsto make the cause and remediation steps clearer.Previously, the output used generic wording and limited guidance.
Now, the message explicitly states that code signing failed and provides concrete, ordered steps in Xcode to resolve team/account/bundle-identifier configuration issues. This should reduce confusion and speed up troubleshooting when running on physical iOS devices.
Fixes #167595.
What changed
Error: could not code sign the application.ios/Runner.xcworkspaceRunner > Signing & Capabilities(Team + Bundle Identifier)Xcode Settings > AccountsProduct > Buildand fix reported signing issuesbuild_ios_test.dartbuild_ipa_test.dartIf you had to change anything in the flutter/tests repo
No changes were made in the
flutter/testsrepo.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.