Skip to content

Draft: Linux fix sibling - #184028

Closed
richardexfo wants to merge 6 commits into
flutter:masterfrom
richardexfo:multi-window-test
Closed

richardexfo wants to merge 6 commits into
flutter:masterfrom
richardexfo:multi-window-test

Conversation

@richardexfo

Copy link
Copy Markdown
Contributor

Draft MR with my setup in .devcontainer
Changes to fl_compositor_opengl.cc to fix memory leak with sibling on OpenGL ES.
Testing multiple_windows runs fine on my Lenovo laptop with Ubuntu.
@robert-ancell am I doing something wrong in my setup or test?

@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop team-linux Owned by the Linux platform team labels Mar 23, 2026
Comment thread .devcontainer/Dockerfile

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base image for devcontainer

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Develop inside a devcontainer with the Wayland display accessible.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra setup needed for building the engine.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script to build the engine

@richardexfo richardexfo Mar 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script to build the example, copy the engine locally and run the test. Works fine with and without my changes.

@richardexfo

Copy link
Copy Markdown
Contributor Author

@robert-ancell what do you think of my setup and test?

@Piinks

Piinks commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Greetings from stale PR triage! 👋
Is this change still on your radar?

@richardexfo

Copy link
Copy Markdown
Contributor Author

This is PR contains my dev environment to reproduce a test issue @robert-ancell reported on my changes. I was waiting for his feedback to figure out what is wrong.
While I don't plan to submit all the changes, the PR is still useful to understand the test issue.

@richardexfo

Copy link
Copy Markdown
Contributor Author

moved the content of the pull request to my own repo richardexfo#1
closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically team-linux Owned by the Linux platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants